All of lore.kernel.org
 help / color / mirror / Atom feed
* [fru-device and intel-ipmi-oem] ipmitool fru print can not output psu information
@ 2019-03-19 11:02 John Wang
  2019-03-19 21:20 ` Vijay Khemka
  0 siblings, 1 reply; 4+ messages in thread
From: John Wang @ 2019-03-19 11:02 UTC (permalink / raw)
  To: OpenBMC Maillist

By checking the code, I found that fru-device seems to need to be used
with intel-ipmi-oem,
and it seems that no additional configuration is required(correct??).

On my machine,there are two FRU,one is /etc/fru/baseboard.fru.bin,the
other is psu fru.
(There is only one psu).

But,ipmitool fru print can only output the fru of baseboard.
$ ipmitool -I lanplus -H 100.2.76.213 -U root -P 0penBmc fru print
FRU Device Description : Builtin FRU Device (ID 0)

fru-device found psu itself and had the correct output on dbus:
busctl tree xyz.openbmc_project.FruDevice
└─/xyz
  └─/xyz/openbmc_project
    └─/xyz/openbmc_project/FruDevice
      ├─/xyz/openbmc_project/FruDevice/DPS_800AB_16_A
      └─/xyz/openbmc_project/FruDevice/ON5263M5
busctl introspect xyz.openbmc_project.FruDevice
/xyz/openbmc_project/FruDevice/DPS_800AB_16_A:      -
.ADDRESS                            property  u         80
  emits-change
.BUS                                property  u         5
  emits-change
.Common_Format_Version              property  s         "1"
  emits-change
.PRODUCT_LANGUAGE_CODE              property  s         "25"
  emits-change
.PRODUCT_MANUFACTURER               property  s         "DELTA"
  emits-change
.PRODUCT_PART_NUMBER                property  s         "          "
  emits-change
.PRODUCT_PRODUCT_NAME               property  s         "DPS-800AB-16
A" emits-change
.PRODUCT_SERIAL_NUMBER              property  s
"HERD1629002309" emits-change
.PRODUCT_VERSION                    property  s         "S2F"
  emits-change

Intel-ipmi-oem:
Commit fcce83df799d9580f48b7f793989c9c96bc882e0
Author: James Feist <james.feist@linux.intel.com>
Date: Fri Mar 1 15:46:19 2019 -0800

The configuration of psu in entity-manager is as follows:
[
    {
        "Exposes": [
            {
                "Address": "0x58",
                "Bus": "$bus",
                "Name": "Delta DPS-800AB-16 PSU Device",
                "Type": "pmbus"
            },
{
                "Address": "$address",
                "Bus": "$bus",
                "Name": "Delta DPS-800AB-16 PSU FRU",
                "Type": "EEPROM"
            }

        ],
        "Name": "PSU",
        "Probe":
"xyz.openbmc_project.FruDevice({'PRODUCT_PRODUCT_NAME': 'DPS-800AB-16
A'})",
        "Type": "PowerSupply",
        "xyz.openbmc_project.Inventory.Decorator.Asset": {
            "Manufacturer": "$PRODUCT_MANUFACTURER",
            "Model": "$PRODUCT_PRODUCT_NAME",
            "PartNumber": "$PRODUCT_PART_NUMBER",
            "SerialNumber": "$PRODUCT_SERIAL_NUMBER"
        }
    }
]


Can anyone help me figure out what configuration information is missing?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [fru-device and intel-ipmi-oem] ipmitool fru print can not output psu information
  2019-03-19 11:02 [fru-device and intel-ipmi-oem] ipmitool fru print can not output psu information John Wang
@ 2019-03-19 21:20 ` Vijay Khemka
  2019-03-19 21:35   ` James Feist
  0 siblings, 1 reply; 4+ messages in thread
From: Vijay Khemka @ 2019-03-19 21:20 UTC (permalink / raw)
  To: John Wang, OpenBMC Maillist

Hi John,
You need to define your fru device name in a configuration file which is .json for entity manager probe to succeed. Please look at 
https://github.com/openbmc/entity-manager/tree/master/configurations

You need a separate configuration for your board.

Regards
-Vijay

On 3/19/19, 4:10 AM, "openbmc on behalf of John Wang" <openbmc-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of wangzqbj@inspur.com> wrote:

    By checking the code, I found that fru-device seems to need to be used
    with intel-ipmi-oem,
    and it seems that no additional configuration is required(correct??).
    
    On my machine,there are two FRU,one is /etc/fru/baseboard.fru.bin,the
    other is psu fru.
    (There is only one psu).
    
    But,ipmitool fru print can only output the fru of baseboard.
    $ ipmitool -I lanplus -H 100.2.76.213 -U root -P 0penBmc fru print
    FRU Device Description : Builtin FRU Device (ID 0)
    
    fru-device found psu itself and had the correct output on dbus:
    busctl tree xyz.openbmc_project.FruDevice
    └─/xyz
      └─/xyz/openbmc_project
        └─/xyz/openbmc_project/FruDevice
          ├─/xyz/openbmc_project/FruDevice/DPS_800AB_16_A
          └─/xyz/openbmc_project/FruDevice/ON5263M5
    busctl introspect xyz.openbmc_project.FruDevice
    /xyz/openbmc_project/FruDevice/DPS_800AB_16_A:      -
    .ADDRESS                            property  u         80
      emits-change
    .BUS                                property  u         5
      emits-change
    .Common_Format_Version              property  s         "1"
      emits-change
    .PRODUCT_LANGUAGE_CODE              property  s         "25"
      emits-change
    .PRODUCT_MANUFACTURER               property  s         "DELTA"
      emits-change
    .PRODUCT_PART_NUMBER                property  s         "          "
      emits-change
    .PRODUCT_PRODUCT_NAME               property  s         "DPS-800AB-16
    A" emits-change
    .PRODUCT_SERIAL_NUMBER              property  s
    "HERD1629002309" emits-change
    .PRODUCT_VERSION                    property  s         "S2F"
      emits-change
    
    Intel-ipmi-oem:
    Commit fcce83df799d9580f48b7f793989c9c96bc882e0
    Author: James Feist <james.feist@linux.intel.com>
    Date: Fri Mar 1 15:46:19 2019 -0800
    
    The configuration of psu in entity-manager is as follows:
    [
        {
            "Exposes": [
                {
                    "Address": "0x58",
                    "Bus": "$bus",
                    "Name": "Delta DPS-800AB-16 PSU Device",
                    "Type": "pmbus"
                },
    {
                    "Address": "$address",
                    "Bus": "$bus",
                    "Name": "Delta DPS-800AB-16 PSU FRU",
                    "Type": "EEPROM"
                }
    
            ],
            "Name": "PSU",
            "Probe":
    "xyz.openbmc_project.FruDevice({'PRODUCT_PRODUCT_NAME': 'DPS-800AB-16
    A'})",
            "Type": "PowerSupply",
            "xyz.openbmc_project.Inventory.Decorator.Asset": {
                "Manufacturer": "$PRODUCT_MANUFACTURER",
                "Model": "$PRODUCT_PRODUCT_NAME",
                "PartNumber": "$PRODUCT_PART_NUMBER",
                "SerialNumber": "$PRODUCT_SERIAL_NUMBER"
            }
        }
    ]
    
    
    Can anyone help me figure out what configuration information is missing?
    


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [fru-device and intel-ipmi-oem] ipmitool fru print can not output psu information
  2019-03-19 21:20 ` Vijay Khemka
@ 2019-03-19 21:35   ` James Feist
  2019-03-19 21:38     ` Vijay Khemka
  0 siblings, 1 reply; 4+ messages in thread
From: James Feist @ 2019-03-19 21:35 UTC (permalink / raw)
  To: Vijay Khemka, John Wang, OpenBMC Maillist


> You need a separate configuration for your board.

This should not be needed.

> 
> Regards
> -Vijay
> 
> On 3/19/19, 4:10 AM, "openbmc on behalf of John Wang" <openbmc-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of wangzqbj@inspur.com> wrote:
> 
>      By checking the code, I found that fru-device seems to need to be used
>      with intel-ipmi-oem,
>      and it seems that no additional configuration is required(correct??).

Should be true.

>      
>      On my machine,there are two FRU,one is /etc/fru/baseboard.fru.bin,the
>      other is psu fru.
>      (There is only one psu).
>      
>      But,ipmitool fru print can only output the fru of baseboard.
>      $ ipmitool -I lanplus -H 100.2.76.213 -U root -P 0penBmc fru print
>      FRU Device Description : Builtin FRU Device (ID 0)
>      
>      fru-device found psu itself and had the correct output on dbus:
>      busctl tree xyz.openbmc_project.FruDevice
>      └─/xyz
>        └─/xyz/openbmc_project
>          └─/xyz/openbmc_project/FruDevice
>            ├─/xyz/openbmc_project/FruDevice/DPS_800AB_16_A
>            └─/xyz/openbmc_project/FruDevice/ON5263 >      busctl introspect xyz.openbmc_project.FruDevice
>      /xyz/openbmc_project/FruDevice/DPS_800AB_16_A:      -
>      .ADDRESS                            property  u         80
>        emits-change
>      .BUS                                property  u         5
>        emits-change
>      .Common_Format_Version              property  s         "1"
>        emits-change
>      .PRODUCT_LANGUAGE_CODE              property  s         "25"
>        emits-change
>      .PRODUCT_MANUFACTURER               property  s         "DELTA"
>        emits-change
>      .PRODUCT_PART_NUMBER                property  s         "          "
>        emits-change
>      .PRODUCT_PRODUCT_NAME               property  s         "DPS-800AB-16
>      A" emits-change
>      .PRODUCT_SERIAL_NUMBER              property  s
>      "HERD1629002309" emits-change
>      .PRODUCT_VERSION                    property  s         "S2F"
>        emits-change

This should be all that is needed. The baseboard itself works without 
any sdr data due to ipmitool implementation treading ID 0 special. It is 
probably failing somewhere with the sdr creation / reading. I would 
check that `ipmitool sdr elist fru` is returning an sdr for that fru.

https://github.com/openbmc/intel-ipmi-oem/blob/master/src/storagecommands.cpp#L400 
is where the FruSDR are created. This also requires SDR commands here: 
https://github.com/openbmc/intel-ipmi-oem/blob/master/src/sensorcommands.cpp#L886

- James

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [fru-device and intel-ipmi-oem] ipmitool fru print can not output psu information
  2019-03-19 21:35   ` James Feist
@ 2019-03-19 21:38     ` Vijay Khemka
  0 siblings, 0 replies; 4+ messages in thread
From: Vijay Khemka @ 2019-03-19 21:38 UTC (permalink / raw)
  To: James Feist, John Wang, OpenBMC Maillist



On 3/19/19, 2:35 PM, "James Feist" <james.feist@linux.intel.com> wrote:

    
    > You need a separate configuration for your board.
    
    This should not be needed.
I agree as this is not required if you only need fru data but for all sensors information it is required to have configuration file.
    
    > 
    > Regards
    > -Vijay
    > 
    > On 3/19/19, 4:10 AM, "openbmc on behalf of John Wang" <openbmc-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of wangzqbj@inspur.com> wrote:
    > 
    >      By checking the code, I found that fru-device seems to need to be used
    >      with intel-ipmi-oem,
    >      and it seems that no additional configuration is required(correct??).
    
    Should be true.
    
    >      
    >      On my machine,there are two FRU,one is /etc/fru/baseboard.fru.bin,the
    >      other is psu fru.
    >      (There is only one psu).
    >      
    >      But,ipmitool fru print can only output the fru of baseboard.
    >      $ ipmitool -I lanplus -H 100.2.76.213 -U root -P 0penBmc fru print
    >      FRU Device Description : Builtin FRU Device (ID 0)
    >      
    >      fru-device found psu itself and had the correct output on dbus:
    >      busctl tree xyz.openbmc_project.FruDevice
    >      └─/xyz
    >        └─/xyz/openbmc_project
    >          └─/xyz/openbmc_project/FruDevice
    >            ├─/xyz/openbmc_project/FruDevice/DPS_800AB_16_A
    >            └─/xyz/openbmc_project/FruDevice/ON5263 >      busctl introspect xyz.openbmc_project.FruDevice
    >      /xyz/openbmc_project/FruDevice/DPS_800AB_16_A:      -
    >      .ADDRESS                            property  u         80
    >        emits-change
    >      .BUS                                property  u         5
    >        emits-change
    >      .Common_Format_Version              property  s         "1"
    >        emits-change
    >      .PRODUCT_LANGUAGE_CODE              property  s         "25"
    >        emits-change
    >      .PRODUCT_MANUFACTURER               property  s         "DELTA"
    >        emits-change
    >      .PRODUCT_PART_NUMBER                property  s         "          "
    >        emits-change
    >      .PRODUCT_PRODUCT_NAME               property  s         "DPS-800AB-16
    >      A" emits-change
    >      .PRODUCT_SERIAL_NUMBER              property  s
    >      "HERD1629002309" emits-change
    >      .PRODUCT_VERSION                    property  s         "S2F"
    >        emits-change
    
    This should be all that is needed. The baseboard itself works without 
    any sdr data due to ipmitool implementation treading ID 0 special. It is 
    probably failing somewhere with the sdr creation / reading. I would 
    check that `ipmitool sdr elist fru` is returning an sdr for that fru.
    
    https://github.com/openbmc/intel-ipmi-oem/blob/master/src/storagecommands.cpp#L400 
    is where the FruSDR are created. This also requires SDR commands here: 
    https://github.com/openbmc/intel-ipmi-oem/blob/master/src/sensorcommands.cpp#L886
    
    - James
    
    


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-19 21:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 11:02 [fru-device and intel-ipmi-oem] ipmitool fru print can not output psu information John Wang
2019-03-19 21:20 ` Vijay Khemka
2019-03-19 21:35   ` James Feist
2019-03-19 21:38     ` Vijay Khemka

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.