From: Jussi Maki <joamaki@gmail.com>
To: Jonathan Toppins <jtoppins@redhat.com>
Cc: "netdev @ vger . kernel . org" <netdev@vger.kernel.org>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] bonding: fix NULL deref in bond_rr_gen_slave_id
Date: Tue, 20 Sep 2022 12:08:56 +0200 [thread overview]
Message-ID: <CAHn8xcnRXq95WB9YQW1JLgZtQ0ey0LedLKT=DYr025iyqjvhxw@mail.gmail.com> (raw)
In-Reply-To: <3cd65bdf26ba7b64c8ade801820562c426b90109.1663628505.git.jtoppins@redhat.com>
On Tue, Sep 20, 2022 at 1:09 AM Jonathan Toppins <jtoppins@redhat.com> wrote:
>
> Fix a NULL dereference of the struct bonding.rr_tx_counter member because
> if a bond is initially created with an initial mode != zero (Round Robin)
> the memory required for the counter is never created and when the mode is
> changed there is never any attempt to verify the memory is allocated upon
> switching modes.
Thanks for the fix and sorry for missing the mode change path in the
original patch.
Acked-by: Jussi Maki <joamaki@gmail.com>
next prev parent reply other threads:[~2022-09-20 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 23:08 [PATCH net 0/2] bonding: fix NULL deref in bond_rr_gen_slave_id Jonathan Toppins
2022-09-19 23:08 ` [PATCH net 1/2] selftests: bonding: cause oops " Jonathan Toppins
2022-09-20 0:01 ` Jay Vosburgh
2022-09-20 0:21 ` Jonathan Toppins
2022-09-19 23:08 ` [PATCH net 2/2] bonding: fix NULL deref " Jonathan Toppins
2022-09-20 10:08 ` Jussi Maki [this message]
2022-09-20 12:59 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHn8xcnRXq95WB9YQW1JLgZtQ0ey0LedLKT=DYr025iyqjvhxw@mail.gmail.com' \
--to=joamaki@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.