All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Toppins <jtoppins@redhat.com>
To: "netdev @ vger . kernel . org" <netdev@vger.kernel.org>
Subject: [PATCH net 0/2] bonding: fix NULL deref in bond_rr_gen_slave_id
Date: Mon, 19 Sep 2022 19:08:44 -0400	[thread overview]
Message-ID: <cover.1663628505.git.jtoppins@redhat.com> (raw)

Fix a NULL dereference of the struct bonding.rr_tx_counter member because
if a bond is initially created with an initial mode != zero (Round Robin)
the memory required for the counter is never created and when the mode is
changed there is never any attempt to verify the memory is allocated upon
switching modes.

The first patch provides a selftest to demonstrate the issue and the
second patch fixes the issue.

Jonathan Toppins (2):
  selftests: bonding: cause oops in bond_rr_gen_slave_id
  bonding: fix NULL deref in bond_rr_gen_slave_id

 drivers/net/bonding/bond_main.c               | 15 +++---
 .../selftests/drivers/net/bonding/Makefile    |  3 +-
 .../bonding/bond-arp-interval-causes-panic.sh | 48 +++++++++++++++++++
 3 files changed, 56 insertions(+), 10 deletions(-)
 create mode 100755 tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh

-- 
2.31.1


             reply	other threads:[~2022-09-19 23:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 23:08 Jonathan Toppins [this message]
2022-09-19 23:08 ` [PATCH net 1/2] selftests: bonding: cause oops in bond_rr_gen_slave_id Jonathan Toppins
2022-09-20  0:01   ` Jay Vosburgh
2022-09-20  0:21     ` Jonathan Toppins
2022-09-19 23:08 ` [PATCH net 2/2] bonding: fix NULL deref " Jonathan Toppins
2022-09-20 10:08   ` Jussi Maki
2022-09-20 12:59   ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1663628505.git.jtoppins@redhat.com \
    --to=jtoppins@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.