From: Andy Shevchenko <andy.shevchenko@gmail.com> To: "Russell King (Oracle)" <linux@armlinux.org.uk> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Alexandre Belloni" <alexandre.belloni@bootlin.com>, "Michael Turquette" <mturquette@baylibre.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Lee Jones" <lee.jones@linaro.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@vger.kernel.org>, "Ludovic Desroches" <Ludovic.Desroches@microchip.com>, "Oleksij Rempel" <o.rempel@pengutronix.de>, "Alexandru Ardelean" <aardelean@deviqon.com>, linux-pwm@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>, "Mark Brown" <broonie@kernel.org>, "Jonathan Cameron" <Jonathan.Cameron@huawei.com>, "linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>, "Alessandro Zummo" <a.zummo@towertech.it>, "Stephen Boyd" <sboyd@kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-spi <linux-spi@vger.kernel.org>, "Wolfram Sang" <wsa@kernel.org>, "Sascha Hauer" <kernel@pengutronix.de>, "Andrew Morton" <akpm@linux-foundation.org>, "Linus Torvalds" <torvalds@linux-foundation.org>, "Claudiu Beznea" <Claudiu.Beznea@microchip.com> Subject: Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks] Date: Mon, 2 Aug 2021 20:13:05 +0300 [thread overview] Message-ID: <CAHp75VcpA0vOwN8gBj2iikXW2dw+KCgZEM=QJ5Jx6UWqww=iCw@mail.gmail.com> (raw) In-Reply-To: <20210802163824.GK22278@shell.armlinux.org.uk> On Mon, Aug 2, 2021 at 7:38 PM Russell King (Oracle) <linux@armlinux.org.uk> wrote: > On Mon, Aug 02, 2021 at 05:27:55PM +0200, Uwe Kleine-König wrote: > > Hello Russell, > > On Mon, Aug 02, 2021 at 10:48:10AM +0100, Russell King (Oracle) wrote: ... > > > There have been several different approaches to wrapping things up, > > > but here's a question: should we make it easier to do the lazy thing > > > (get+enable) or should we make it easier to be power efficient? > > > Shouldn't we be encouraging people to write power efficient drivers? > > > > Yeah, sounds compelling, but I wonder if that's of practical importance. > > How many driver authors do you expect to lure into making a better > > driver just because devm_clk_get_prepared() doesn't exist? In contrast: > > How many drivers become simpler with devm_clk_get_prepared() and so > > it becomes easier to maintain them and easier to spot bugs? > > In the absence of devm_clk_get_prepared(), is it better that several > > frameworks (or drivers) open code it? > > It probably depends on where you stand on power management and power > efficiency issues. Personally, I would like to see more effort put > into drivers to make them more power efficient, and I believe in the > coming years, power efficiency is going to become a big issue. While in the ideal world I 100% agree with the approach, IRL we have to deal with constantly degrading quality of the code and instead of thinking about power management and efficiency the absence of APIs such as discussed provokes not only creating the power management inefficient code, but also memory leaks here and there. -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: "Russell King (Oracle)" <linux@armlinux.org.uk> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Alexandre Belloni" <alexandre.belloni@bootlin.com>, "Michael Turquette" <mturquette@baylibre.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Lee Jones" <lee.jones@linaro.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@vger.kernel.org>, "Ludovic Desroches" <Ludovic.Desroches@microchip.com>, "Oleksij Rempel" <o.rempel@pengutronix.de>, "Alexandru Ardelean" <aardelean@deviqon.com>, linux-pwm@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>, "Mark Brown" <broonie@kernel.org>, "Jonathan Cameron" <Jonathan.Cameron@huawei.com>, "linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>, "Alessandro Zummo" <a.zummo@towertech.it>, "Stephen Boyd" <sboyd@kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-spi <linux-spi@vger.kernel.org>, "Wolfram Sang" <wsa@kernel.org>, "Sascha Hauer" <kernel@pengutronix.de>, "Andrew Morton" <akpm@linux-foundation.org>, "Linus Torvalds" <torvalds@linux-foundation.org>, "Claudiu Beznea" <Claudiu.Beznea@microchip.com> Subject: Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks] Date: Mon, 2 Aug 2021 20:13:05 +0300 [thread overview] Message-ID: <CAHp75VcpA0vOwN8gBj2iikXW2dw+KCgZEM=QJ5Jx6UWqww=iCw@mail.gmail.com> (raw) In-Reply-To: <20210802163824.GK22278@shell.armlinux.org.uk> On Mon, Aug 2, 2021 at 7:38 PM Russell King (Oracle) <linux@armlinux.org.uk> wrote: > On Mon, Aug 02, 2021 at 05:27:55PM +0200, Uwe Kleine-König wrote: > > Hello Russell, > > On Mon, Aug 02, 2021 at 10:48:10AM +0100, Russell King (Oracle) wrote: ... > > > There have been several different approaches to wrapping things up, > > > but here's a question: should we make it easier to do the lazy thing > > > (get+enable) or should we make it easier to be power efficient? > > > Shouldn't we be encouraging people to write power efficient drivers? > > > > Yeah, sounds compelling, but I wonder if that's of practical importance. > > How many driver authors do you expect to lure into making a better > > driver just because devm_clk_get_prepared() doesn't exist? In contrast: > > How many drivers become simpler with devm_clk_get_prepared() and so > > it becomes easier to maintain them and easier to spot bugs? > > In the absence of devm_clk_get_prepared(), is it better that several > > frameworks (or drivers) open code it? > > It probably depends on where you stand on power management and power > efficiency issues. Personally, I would like to see more effort put > into drivers to make them more power efficient, and I believe in the > coming years, power efficiency is going to become a big issue. While in the ideal world I 100% agree with the approach, IRL we have to deal with constantly degrading quality of the code and instead of thinking about power management and efficiency the absence of APIs such as discussed provokes not only creating the power management inefficient code, but also memory leaks here and there. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-02 17:13 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 17:41 [PATCH v7 0/6] clk: provide new devm helpers for prepared and enabled clocks Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 1/6] clk: generalize devm_clk_get() a bit Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 2/6] clk: Provide new devm_clk_helpers for prepared and enabled clocks Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 3/6] pwm: atmel: Simplify using devm_clk_get_prepared() Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 4/6] rtc: at91sam9: Simplify using devm_clk_get_enabled() Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 5/6] i2c: imx: " Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 6/6] spi: davinci: " Uwe Kleine-König 2021-05-11 7:58 ` [PATCH v7 0/6] clk: provide new devm helpers for prepared and enabled clocks Alexandru Ardelean 2021-05-11 7:58 ` Alexandru Ardelean 2021-05-24 11:09 ` Uwe Kleine-König 2021-05-24 11:09 ` Uwe Kleine-König 2021-06-09 20:21 ` [PULL] Add variants of devm_clk_get for prepared and enabled clocks " Uwe Kleine-König 2021-06-25 17:14 ` Uwe Kleine-König 2021-06-25 17:14 ` Uwe Kleine-König 2021-07-05 8:01 ` Uwe Kleine-König 2021-07-05 8:01 ` Uwe Kleine-König 2021-07-22 6:06 ` Uwe Kleine-König 2021-07-22 6:06 ` Uwe Kleine-König 2021-07-22 7:40 ` Wolfram Sang 2021-07-22 7:40 ` Wolfram Sang 2021-07-22 8:18 ` Uwe Kleine-König 2021-07-22 8:18 ` Uwe Kleine-König 2021-07-22 12:07 ` Wolfram Sang 2021-07-22 12:07 ` Wolfram Sang [not found] ` <CAHp75VfC=s12Unw3+Cn0ag71mM5i90=Jbwj4nYwB5cPKiUTRSA@mail.gmail.com> 2021-07-23 9:13 ` Uwe Kleine-König 2021-07-23 9:13 ` Uwe Kleine-König 2021-07-26 9:18 ` Claudiu.Beznea 2021-07-26 9:18 ` Claudiu.Beznea 2021-07-26 9:52 ` Andy Shevchenko 2021-07-26 9:52 ` Andy Shevchenko 2021-07-26 12:32 ` Wolfram Sang 2021-07-26 12:32 ` Wolfram Sang 2021-07-26 13:28 ` Andy Shevchenko 2021-07-26 13:28 ` Andy Shevchenko 2021-07-26 17:40 ` Wolfram Sang 2021-07-26 17:40 ` Wolfram Sang 2021-07-28 20:25 ` About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks] Uwe Kleine-König 2021-07-28 20:25 ` Uwe Kleine-König 2021-07-28 20:40 ` Russell King (Oracle) 2021-07-28 20:40 ` Russell King (Oracle) 2021-07-31 7:41 ` Stephen Boyd 2021-07-31 7:41 ` Stephen Boyd 2021-07-31 8:07 ` Andy Shevchenko 2021-07-31 8:07 ` Andy Shevchenko 2021-07-31 12:00 ` Uwe Kleine-König 2021-07-31 12:00 ` Uwe Kleine-König 2021-08-02 9:36 ` Jonathan Cameron 2021-08-02 9:36 ` Jonathan Cameron 2021-08-02 9:48 ` Russell King (Oracle) 2021-08-02 9:48 ` Russell King (Oracle) 2021-08-02 15:27 ` Uwe Kleine-König 2021-08-02 15:27 ` Uwe Kleine-König 2021-08-02 16:38 ` Russell King (Oracle) 2021-08-02 16:38 ` Russell King (Oracle) 2021-08-02 17:13 ` Andy Shevchenko [this message] 2021-08-02 17:13 ` Andy Shevchenko 2021-08-02 20:28 ` Russell King (Oracle) 2021-08-02 20:28 ` Russell King (Oracle) 2021-08-03 8:11 ` Stephen Boyd 2021-08-03 8:11 ` Stephen Boyd 2021-08-03 10:40 ` Uwe Kleine-König 2021-08-03 10:40 ` Uwe Kleine-König 2021-08-06 0:26 ` Stephen Boyd 2021-08-06 0:26 ` Stephen Boyd 2021-09-14 13:22 ` Uwe Kleine-König 2021-09-14 13:22 ` Uwe Kleine-König 2021-09-14 13:52 ` Mark Brown 2021-09-14 13:52 ` Mark Brown 2021-08-03 7:44 ` Stephen Boyd 2021-08-03 7:44 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75VcpA0vOwN8gBj2iikXW2dw+KCgZEM=QJ5Jx6UWqww=iCw@mail.gmail.com' \ --to=andy.shevchenko@gmail.com \ --cc=Claudiu.Beznea@microchip.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=Ludovic.Desroches@microchip.com \ --cc=a.zummo@towertech.it \ --cc=aardelean@deviqon.com \ --cc=akpm@linux-foundation.org \ --cc=alexandre.belloni@bootlin.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mturquette@baylibre.com \ --cc=o.rempel@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wsa@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.