All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Krivenok <krivenok.dmitry@gmail.com>
To: Jerry Hoemann <Jerry.Hoemann@hpe.com>
Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net,
	Len Brown <lenb@kernel.org>,
	dan.j.williams@intel.com, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru
Date: Tue, 10 Nov 2015 18:05:15 +0300	[thread overview]
Message-ID: <CAJN_NGY0Zop4=_NrW8Y3md7Up9FRq9voQ2UYiTPgXCv9XP8u5A@mail.gmail.com> (raw)
In-Reply-To: <20151109215904.GB33245@tevye.fc.hp.com>

> Is your concern readibility or size of generated code (or both?)
>
> I'll look to consolidating the debug printing in next version as additional patch.

Just a minor style comment, not critical.

> If we had a longer list, I would definitely say yes.  Not so sure with
> just two types.  I'll take a look for the next version.

The same, just a style comment.

>   list_for_each_entry(nvdimm_bus, &nvdimm_bus_list, list) {
> - if (nvdimm_bus->id == id) {
> + if (nvdimm_bus->id != id)

I noticed another minor issue. You have switched from "==" to "!="
here, but you didn't add "break" after ioctl is handled for the found
bus.

Thanks,
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Krivenok <krivenok.dmitry@gmail.com>
To: Jerry Hoemann <Jerry.Hoemann@hpe.com>
Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net,
	Len Brown <lenb@kernel.org>,
	dan.j.williams@intel.com, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org
Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru
Date: Tue, 10 Nov 2015 18:05:15 +0300	[thread overview]
Message-ID: <CAJN_NGY0Zop4=_NrW8Y3md7Up9FRq9voQ2UYiTPgXCv9XP8u5A@mail.gmail.com> (raw)
In-Reply-To: <20151109215904.GB33245@tevye.fc.hp.com>

> Is your concern readibility or size of generated code (or both?)
>
> I'll look to consolidating the debug printing in next version as additional patch.

Just a minor style comment, not critical.

> If we had a longer list, I would definitely say yes.  Not so sure with
> just two types.  I'll take a look for the next version.

The same, just a style comment.

>   list_for_each_entry(nvdimm_bus, &nvdimm_bus_list, list) {
> - if (nvdimm_bus->id == id) {
> + if (nvdimm_bus->id != id)

I noticed another minor issue. You have switched from "==" to "!="
here, but you didn't add "break" after ioctl is handled for the found
bus.

Thanks,
Dmitry

  reply	other threads:[~2015-11-10 15:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07 14:02 [PATCH 3/4] nvdimm: Add IOCTL pass thru Dmitry Krivenok
2015-11-07 14:02 ` Dmitry Krivenok
2015-11-09 21:59 ` Jerry Hoemann
2015-11-09 21:59   ` Jerry Hoemann
2015-11-10 15:05   ` Dmitry Krivenok [this message]
2015-11-10 15:05     ` Dmitry Krivenok
2015-11-11 21:44     ` Jerry Hoemann
2015-11-11 21:44       ` Jerry Hoemann
2015-11-11 21:52       ` Dmitry Krivenok
2015-11-11 21:52         ` Dmitry Krivenok
2015-11-12 15:33         ` Jerry Hoemann
2015-11-12 15:33           ` Jerry Hoemann
  -- strict thread matches above, loose matches on Subject: below --
2015-11-06 22:27 [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann
2015-11-06 22:27 ` [PATCH 3/4] nvdimm: Add IOCTL pass thru Jerry Hoemann
2015-11-06 22:27   ` Jerry Hoemann
2015-11-10 16:24   ` Jeff Moyer
2015-11-10 21:36     ` Jerry Hoemann
2015-11-10 21:45       ` Jeff Moyer
2015-11-10 22:15         ` Jerry Hoemann
2015-11-10 21:54   ` Jeff Moyer
2015-11-11  1:42     ` Jerry Hoemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJN_NGY0Zop4=_NrW8Y3md7Up9FRq9voQ2UYiTPgXCv9XP8u5A@mail.gmail.com' \
    --to=krivenok.dmitry@gmail.com \
    --cc=Jerry.Hoemann@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=rjw@rjwysocki.net \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.