From: "Rafael J. Wysocki" <rafael@kernel.org> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Ioana Ciornei <ciorneiioana@gmail.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Heiner Kallweit <hkallweit1@gmail.com>, netdev <netdev@vger.kernel.org>, Grant Likely <grant.likely@arm.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Jeremy Linton <jeremy.linton@arm.com>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Russell King - ARM Linux admin <linux@armlinux.org.uk>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Marcin Wojtas <mw@semihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>, Randy Dunlap <rdunlap@infradead.org>, Calvin Johnson <calvin.johnson@oss.nxp.com>, Cristi Sovaiala <cristian.sovaiala@nxp.com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Madalin Bucur <madalin.bucur@nxp.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Diana Madalina Craciun <diana.craciun@nxp.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "linux.cj" <linux.cj@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Len Brown <lenb@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Ioana Ciornei <ioana.ciornei@nxp.com> Subject: Re: [PATCH net-next v9 03/15] net: phy: Introduce phy related fwnode functions Date: Fri, 11 Jun 2021 13:40:59 +0200 [thread overview] Message-ID: <CAJZ5v0ipvAodoFhU4XK+cL2tf-0jExtMd2QUarMK0QPJQyeJxg@mail.gmail.com> (raw) In-Reply-To: <CAHp75VcfEbMecsGprNW33OtiddVw1MhmOVrtb9Gx4tKL5BjvYw@mail.gmail.com> On Fri, Jun 11, 2021 at 1:26 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Fri, Jun 11, 2021 at 1:54 PM Ioana Ciornei <ciorneiioana@gmail.com> wrote: > > > > From: Calvin Johnson <calvin.johnson@oss.nxp.com> > > > > Define fwnode_phy_find_device() to iterate an mdiobus and find the > > phy device of the provided phy fwnode. Additionally define > > device_phy_find_device() to find phy device of provided device. > > > > Define fwnode_get_phy_node() to get phy_node using named reference. > > using a named > > ... > > > +struct fwnode_handle *fwnode_get_phy_node(struct fwnode_handle *fwnode) > > +{ > > + struct fwnode_handle *phy_node; > > + > > + /* Only phy-handle is used for ACPI */ > > + phy_node = fwnode_find_reference(fwnode, "phy-handle", 0); > > + if (is_acpi_node(fwnode) || !IS_ERR(phy_node)) > > + return phy_node; > > + phy_node = fwnode_find_reference(fwnode, "phy", 0); > > + if (IS_ERR(phy_node)) > > + phy_node = fwnode_find_reference(fwnode, "phy-device", 0); > > + return phy_node; > > Looking into the patterns in this code I would perhaps refactor it the > following way: > > /* First try "phy-handle" as most common in use */ > phy_node = fwnode_find_reference(fwnode, "phy-handle", 0); > /* Only phy-handle is used for ACPI */ > if (is_acpi_node(fwnode)) > return phy_node; > if (!IS_ERR(phy_node)) > return phy_node; I'm not sure why you want the above to be two if () statements instead of one? I would change the ordering anyway, that is if (!IS_ERR(phy_node) || is_acpi_node(fwnode)) return phy_node; And I think that the is_acpi_node() check is there to return the error code right away so as to avoid returning a "not found" error later. But I'm not sure if this is really necessary. Namely, if nothing depends on the specific error code returned by this function, it would be somewhat cleaner to let the code below run if phy_node is an error pointer in the ACPI case, because in that case the code below will produce an error pointer anyway. > /* Try "phy" reference */ > phy_node = fwnode_find_reference(fwnode, "phy", 0); > if (!IS_ERR(phy_node)) > return phy_node; > /* At last try "phy-device" reference */ > return fwnode_find_reference(fwnode, "phy-device", 0); > > > +}
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rafael@kernel.org> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Ioana Ciornei <ciorneiioana@gmail.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Heiner Kallweit <hkallweit1@gmail.com>, netdev <netdev@vger.kernel.org>, Grant Likely <grant.likely@arm.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Jeremy Linton <jeremy.linton@arm.com>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Russell King - ARM Linux admin <linux@armlinux.org.uk>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Marcin Wojtas <mw@semihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>, Randy Dunlap <rdunlap@infradead.org>, Calvin Johnson <calvin.johnson@oss.nxp.com>, Cristi Sovaiala <cristian.sovaiala@nxp.com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Madalin Bucur <madalin.bucur@nxp.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Diana Madalina Craciun <diana.craciun@nxp.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "linux.cj" <linux.cj@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Len Brown <lenb@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Ioana Ciornei <ioana.ciornei@nxp.com> Subject: Re: [PATCH net-next v9 03/15] net: phy: Introduce phy related fwnode functions Date: Fri, 11 Jun 2021 13:40:59 +0200 [thread overview] Message-ID: <CAJZ5v0ipvAodoFhU4XK+cL2tf-0jExtMd2QUarMK0QPJQyeJxg@mail.gmail.com> (raw) In-Reply-To: <CAHp75VcfEbMecsGprNW33OtiddVw1MhmOVrtb9Gx4tKL5BjvYw@mail.gmail.com> On Fri, Jun 11, 2021 at 1:26 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Fri, Jun 11, 2021 at 1:54 PM Ioana Ciornei <ciorneiioana@gmail.com> wrote: > > > > From: Calvin Johnson <calvin.johnson@oss.nxp.com> > > > > Define fwnode_phy_find_device() to iterate an mdiobus and find the > > phy device of the provided phy fwnode. Additionally define > > device_phy_find_device() to find phy device of provided device. > > > > Define fwnode_get_phy_node() to get phy_node using named reference. > > using a named > > ... > > > +struct fwnode_handle *fwnode_get_phy_node(struct fwnode_handle *fwnode) > > +{ > > + struct fwnode_handle *phy_node; > > + > > + /* Only phy-handle is used for ACPI */ > > + phy_node = fwnode_find_reference(fwnode, "phy-handle", 0); > > + if (is_acpi_node(fwnode) || !IS_ERR(phy_node)) > > + return phy_node; > > + phy_node = fwnode_find_reference(fwnode, "phy", 0); > > + if (IS_ERR(phy_node)) > > + phy_node = fwnode_find_reference(fwnode, "phy-device", 0); > > + return phy_node; > > Looking into the patterns in this code I would perhaps refactor it the > following way: > > /* First try "phy-handle" as most common in use */ > phy_node = fwnode_find_reference(fwnode, "phy-handle", 0); > /* Only phy-handle is used for ACPI */ > if (is_acpi_node(fwnode)) > return phy_node; > if (!IS_ERR(phy_node)) > return phy_node; I'm not sure why you want the above to be two if () statements instead of one? I would change the ordering anyway, that is if (!IS_ERR(phy_node) || is_acpi_node(fwnode)) return phy_node; And I think that the is_acpi_node() check is there to return the error code right away so as to avoid returning a "not found" error later. But I'm not sure if this is really necessary. Namely, if nothing depends on the specific error code returned by this function, it would be somewhat cleaner to let the code below run if phy_node is an error pointer in the ACPI case, because in that case the code below will produce an error pointer anyway. > /* Try "phy" reference */ > phy_node = fwnode_find_reference(fwnode, "phy", 0); > if (!IS_ERR(phy_node)) > return phy_node; > /* At last try "phy-device" reference */ > return fwnode_find_reference(fwnode, "phy-device", 0); > > > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-11 11:41 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-11 10:53 [PATCH net-next v9 00/15] ACPI support for dpaa2 driver Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 01/15] Documentation: ACPI: DSD: Document MDIO PHY Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 02/15] net: phy: Introduce fwnode_mdio_find_device() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 11:20 ` Andy Shevchenko 2021-06-11 11:20 ` Andy Shevchenko 2021-06-11 10:53 ` [PATCH net-next v9 03/15] net: phy: Introduce phy related fwnode functions Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 11:26 ` Andy Shevchenko 2021-06-11 11:26 ` Andy Shevchenko 2021-06-11 11:40 ` Rafael J. Wysocki [this message] 2021-06-11 11:40 ` Rafael J. Wysocki 2021-06-11 12:08 ` Russell King (Oracle) 2021-06-11 12:08 ` Russell King (Oracle) 2021-06-11 12:31 ` Rafael J. Wysocki 2021-06-11 12:31 ` Rafael J. Wysocki 2021-06-11 10:53 ` [PATCH net-next v9 04/15] of: mdio: Refactor of_phy_find_device() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 11:28 ` Andy Shevchenko 2021-06-11 11:28 ` Andy Shevchenko 2021-06-11 11:30 ` Andy Shevchenko 2021-06-11 11:30 ` Andy Shevchenko 2021-06-11 11:35 ` Russell King (Oracle) 2021-06-11 11:35 ` Russell King (Oracle) 2021-06-11 10:53 ` [PATCH net-next v9 05/15] net: phy: Introduce fwnode_get_phy_id() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 06/15] of: mdio: Refactor of_get_phy_id() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 07/15] net: mii_timestamper: check NULL in unregister_mii_timestamper() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 08/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-15 20:15 ` andy 2021-06-11 10:53 ` [PATCH net-next v9 09/15] of: mdio: Refactor of_mdiobus_register_phy() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 10/15] ACPI: utils: Introduce acpi_get_local_address() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 11/15] net: mdio: Add ACPI support code for mdio Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 12/15] net/fsl: Use [acpi|of]_mdiobus_register Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 10:53 ` [PATCH net-next v9 13/15] net: phylink: introduce phylink_fwnode_phy_connect() Ioana Ciornei 2021-06-11 10:53 ` Ioana Ciornei 2021-06-11 11:17 ` Russell King (Oracle) 2021-06-11 11:17 ` Russell King (Oracle) 2021-06-15 20:18 ` andy 2021-06-11 10:54 ` [PATCH net-next v9 14/15] net: phylink: Refactor phylink_of_phy_connect() Ioana Ciornei 2021-06-11 10:54 ` Ioana Ciornei 2021-06-11 11:18 ` Russell King (Oracle) 2021-06-11 11:18 ` Russell King (Oracle) 2021-06-11 10:54 ` [PATCH net-next v9 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Ioana Ciornei 2021-06-11 10:54 ` Ioana Ciornei 2021-06-11 20:20 ` [PATCH net-next v9 00/15] ACPI support for dpaa2 driver patchwork-bot+netdevbpf 2021-06-11 20:20 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJZ5v0ipvAodoFhU4XK+cL2tf-0jExtMd2QUarMK0QPJQyeJxg@mail.gmail.com \ --to=rafael@kernel.org \ --cc=andrew@lunn.ch \ --cc=andy.shevchenko@gmail.com \ --cc=calvin.johnson@oss.nxp.com \ --cc=ciorneiioana@gmail.com \ --cc=cristian.sovaiala@nxp.com \ --cc=davem@davemloft.net \ --cc=diana.craciun@nxp.com \ --cc=f.fainelli@gmail.com \ --cc=florinlaurentiu.chiculita@nxp.com \ --cc=grant.likely@arm.com \ --cc=heikki.krogerus@linux.intel.com \ --cc=hkallweit1@gmail.com \ --cc=ioana.ciornei@nxp.com \ --cc=jeremy.linton@arm.com \ --cc=jon@solid-run.com \ --cc=kuba@kernel.org \ --cc=laurentiu.tudor@nxp.com \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux.cj@gmail.com \ --cc=linux@armlinux.org.uk \ --cc=madalin.bucur@nxp.com \ --cc=mw@semihalf.com \ --cc=netdev@vger.kernel.org \ --cc=pieter.jansenvv@bamboosystems.io \ --cc=rdunlap@infradead.org \ --cc=rjw@rjwysocki.net \ --cc=saravanak@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.