All of lore.kernel.org
 help / color / mirror / Atom feed
From: jim.cromie@gmail.com
To: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>,
	daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	Sean Paul <seanpaul@chromium.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers
Date: Wed, 28 Jul 2021 10:39:48 -0400	[thread overview]
Message-ID: <CAJfuBxw2uAZozKgG58KvFnQfw8hzcqrzUfN=B0ucYDkU=h40=A@mail.gmail.com> (raw)
In-Reply-To: <20210721175526.22020-4-sean@poorly.run>

On Wed, Jul 21, 2021 at 1:55 PM Sean Paul <sean@poorly.run> wrote:
>
> From: Sean Paul <seanpaul@chromium.org>
>
> Use drm logging helpers to add support for the upcoming tracefs
> implementation.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-sean@poorly.run #v5
>
> Changes in v5:
> -Added to the set
> Changes in v6:
> -None
> ---
>  drivers/gpu/drm/i915/i915_utils.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index f9e780dee9de..d858c92c6997 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -30,10 +30,9 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>         vaf.va = &args;
>
>         if (is_error)
> -               dev_printk(level, kdev, "%pV", &vaf);
> +               drm_dev_printk(kdev, level, "%pV", &vaf);
>         else
> -               dev_printk(level, kdev, "[" DRM_NAME ":%ps] %pV",
> -                          __builtin_return_address(0), &vaf);
> +               drm_err(&dev_priv->drm, "%pV", &vaf);

its slightly jarring to see drm_err() in the !is_err branch.
warn or notice seems better.


>
>         va_end(args);
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>

WARNING: multiple messages have this Message-ID (diff)
From: jim.cromie@gmail.com
To: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>,
	daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, ppaalanen@gmail.com,
	Sean Paul <seanpaul@chromium.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers
Date: Wed, 28 Jul 2021 10:39:48 -0400	[thread overview]
Message-ID: <CAJfuBxw2uAZozKgG58KvFnQfw8hzcqrzUfN=B0ucYDkU=h40=A@mail.gmail.com> (raw)
In-Reply-To: <20210721175526.22020-4-sean@poorly.run>

On Wed, Jul 21, 2021 at 1:55 PM Sean Paul <sean@poorly.run> wrote:
>
> From: Sean Paul <seanpaul@chromium.org>
>
> Use drm logging helpers to add support for the upcoming tracefs
> implementation.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-sean@poorly.run #v5
>
> Changes in v5:
> -Added to the set
> Changes in v6:
> -None
> ---
>  drivers/gpu/drm/i915/i915_utils.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index f9e780dee9de..d858c92c6997 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -30,10 +30,9 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>         vaf.va = &args;
>
>         if (is_error)
> -               dev_printk(level, kdev, "%pV", &vaf);
> +               drm_dev_printk(kdev, level, "%pV", &vaf);
>         else
> -               dev_printk(level, kdev, "[" DRM_NAME ":%ps] %pV",
> -                          __builtin_return_address(0), &vaf);
> +               drm_err(&dev_priv->drm, "%pV", &vaf);

its slightly jarring to see drm_err() in the !is_err branch.
warn or notice seems better.


>
>         va_end(args);
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-07-28 14:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 17:55 [RESEND PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs Sean Paul
2021-07-21 17:55 ` [RESEND PATCH v6 01/14] drm/mipi_dbi: Convert pr_debug calls to DRM_DEBUG_DRIVER Sean Paul
2021-07-28 15:41   ` jim.cromie
2021-07-21 17:55 ` [RESEND PATCH v6 02/14] drm/sil164: Convert dev_printk to drm_dev_dbg Sean Paul
2021-07-28 14:34   ` jim.cromie
2021-07-21 17:55 ` [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers Sean Paul
2021-07-21 17:55   ` [Intel-gfx] " Sean Paul
2021-07-28 14:39   ` jim.cromie [this message]
2021-07-28 14:39     ` jim.cromie
2021-07-21 17:55 ` [RESEND PATCH v6 04/14] drm/msm/dpu: Replace definitions for dpu debug macros Sean Paul
2021-07-21 17:55   ` Sean Paul
2021-08-05 14:00   ` Dmitry Baryshkov
2021-09-17 18:23   ` [Freedreno] " abhinavk
2021-07-21 17:55 ` [RESEND PATCH v6 05/14] drm/print: rename drm_debug* to be more syslog-centric Sean Paul
2021-07-28 16:03   ` jim.cromie
2021-07-28 16:13   ` jim.cromie
2021-09-17 18:24   ` abhinavk
2021-09-17 18:25   ` abhinavk
2021-07-21 17:55 ` [RESEND PATCH v6 06/14] drm/amd: Gate i2c transaction logs on drm_debug_syslog Sean Paul
2021-07-21 17:55   ` Sean Paul
2021-07-21 17:55 ` [RESEND PATCH v6 07/14] drm/etnaviv: Change buffer dump checks to target syslog Sean Paul
2021-07-21 20:54   ` Lucas Stach
2021-07-21 17:55 ` [Nouveau] [RESEND PATCH v6 08/14] drm/nouveau: Change debug checks to specifically " Sean Paul
2021-07-21 17:55   ` Sean Paul
2021-07-21 17:55 ` [RESEND PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog Sean Paul
2021-07-21 17:55   ` [Intel-gfx] " Sean Paul
2021-07-21 17:55 ` [RESEND PATCH v6 10/14] drm/print: Add drm_debug_category_printer Sean Paul
2021-09-17 18:27   ` abhinavk
2021-07-21 17:55 ` [RESEND PATCH v6 11/14] drm/mst: Convert debug printers to debug category printers Sean Paul
2021-07-27 19:25   ` Lyude Paul
2021-07-21 17:55 ` [RESEND PATCH v6 12/14] drm/i915: Use debug category printer for welcome message Sean Paul
2021-07-21 17:55   ` [Intel-gfx] " Sean Paul
2021-07-21 17:55 ` [RESEND PATCH v6 13/14] drm/atomic: Use debug category printer for atomic state printer Sean Paul
2021-09-17 18:27   ` abhinavk
2021-07-21 17:55 ` [RESEND PATCH v6 14/14] drm/print: Add tracefs support to the drm logging helpers Sean Paul
2021-07-21 17:55   ` Sean Paul
2021-07-26 20:50   ` Rodrigo Siqueira
2021-07-26 20:50     ` Rodrigo Siqueira
2021-07-29 20:24   ` jim.cromie
2021-07-29 20:24     ` jim.cromie
2021-07-29 20:33     ` jim.cromie
2021-07-29 20:33       ` jim.cromie
2021-09-17 18:17   ` abhinavk
2021-07-22  7:49 ` [RESEND PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs Pekka Paalanen
2021-07-22 13:48   ` Sean Paul
2021-07-22 13:49     ` Sean Paul
2021-07-23  8:02     ` Pekka Paalanen
2021-09-17 17:58 ` abhinavk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfuBxw2uAZozKgG58KvFnQfw8hzcqrzUfN=B0ucYDkU=h40=A@mail.gmail.com' \
    --to=jim.cromie@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.