[meta-raspberrypi][PATCH] bluez5: add functions for raspberrypi0-wifi

[meta-raspberrypi][PATCH] bluez5: add functions for raspberrypi0-wifi

[Yusuke Mitsuki]

I could not use bluetooth with raspberrypi0-wifi.
hciattach on raspberrypi0-wifi failed because BCM43430A1.hcd is not found.

Functions in bluez5_%.bbappend should be enabled with raspberrypi0-wifi too.

I know that these changes are redundant.

If you have any ideas for better solution, let me know.


Yusuke Mitsuki (1):
  bluez5: add functions for raspberrypi0-wifi

 recipes-connectivity/bluez5/bluez5_%.bbappend | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

-- 
2.7.4

[meta-raspberrypi][PATCH] bluez5: add functions for raspberrypi0-wifi

[Yusuke Mitsuki]

hciattach on raspberrypi0-wifi failed because BCM43430A1.hcd is not found.

Paches that in order to use bluetooth with BCM43430 are not enabled.
Functions are only enabled with raspberrypi3 in bluez5_%.bbappend like as follows:

- SRC_URI_append_raspberrypi3
- do_install_append_raspberrypi3()
- FILES_${PN}_append_raspberrypi3
- SYSTEMD_SERVICE_${PN}_append_raspberrypi3

These should be enabled with raspberrypi0-wifi too.

Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
---
 recipes-connectivity/bluez5/bluez5_%.bbappend | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend b/recipes-connectivity/bluez5/bluez5_%.bbappend
index 956d776..075dc2b 100644
--- a/recipes-connectivity/bluez5/bluez5_%.bbappend
+++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
@@ -24,3 +24,28 @@ FILES_${PN}_append_raspberrypi3 = " \
     "
 
 SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
+
+SRC_URI_append_raspberrypi0-wifi = " \
+    file://BCM43430A1.hcd \
+    file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
+    file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch \
+    file://0003-Increase-firmware-load-timeout-to-30s.patch \
+    file://0004-Move-the-43xx-firmware-into-lib-firmware.patch \
+    file://brcm43438.service \
+    "
+
+do_install_append_raspberrypi0-wifi() {
+    install -d ${D}/lib/firmware/brcm/
+    install -m 0644 ${WORKDIR}/BCM43430A1.hcd ${D}/lib/firmware/brcm/BCM43430A1.hcd
+
+    if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}; then
+        install -d ${D}${systemd_unitdir}/system
+        install -m 0644 ${WORKDIR}/brcm43438.service ${D}${systemd_unitdir}/system
+    fi
+}
+
+FILES_${PN}_append_raspberrypi0-wifi = " \
+    /lib/firmware/brcm/BCM43430A1.hcd \
+    "
+
+SYSTEMD_SERVICE_${PN}_append_raspberrypi0-wifi = " brcm43438.service"
-- 
2.7.4

Re: [meta-raspberrypi][PATCH] bluez5: add functions for raspberrypi0-wifi

[Paul Barker]

On Thu, Aug 24, 2017 at 1:05 PM, Yusuke Mitsuki
<mickey.happygolucky@gmail.com> wrote:
> hciattach on raspberrypi0-wifi failed because BCM43430A1.hcd is not found.
>
> Paches that in order to use bluetooth with BCM43430 are not enabled.
> Functions are only enabled with raspberrypi3 in bluez5_%.bbappend like as follows:
>
> - SRC_URI_append_raspberrypi3
> - do_install_append_raspberrypi3()
> - FILES_${PN}_append_raspberrypi3
> - SYSTEMD_SERVICE_${PN}_append_raspberrypi3
>
> These should be enabled with raspberrypi0-wifi too.
>
> Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
> ---
>  recipes-connectivity/bluez5/bluez5_%.bbappend | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend b/recipes-connectivity/bluez5/bluez5_%.bbappend
> index 956d776..075dc2b 100644
> --- a/recipes-connectivity/bluez5/bluez5_%.bbappend
> +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
> @@ -24,3 +24,28 @@ FILES_${PN}_append_raspberrypi3 = " \
>      "
>
>  SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
> +
> +SRC_URI_append_raspberrypi0-wifi = " \
> +    file://BCM43430A1.hcd \
> +    file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
> +    file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch \
> +    file://0003-Increase-firmware-load-timeout-to-30s.patch \
> +    file://0004-Move-the-43xx-firmware-into-lib-firmware.patch \
> +    file://brcm43438.service \
> +    "
> +
> +do_install_append_raspberrypi0-wifi() {
> +    install -d ${D}/lib/firmware/brcm/
> +    install -m 0644 ${WORKDIR}/BCM43430A1.hcd ${D}/lib/firmware/brcm/BCM43430A1.hcd
> +
> +    if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}; then
> +        install -d ${D}${systemd_unitdir}/system
> +        install -m 0644 ${WORKDIR}/brcm43438.service ${D}${systemd_unitdir}/system
> +    fi
> +}
> +
> +FILES_${PN}_append_raspberrypi0-wifi = " \
> +    /lib/firmware/brcm/BCM43430A1.hcd \
> +    "
> +
> +SYSTEMD_SERVICE_${PN}_append_raspberrypi0-wifi = " brcm43438.service"

I don't like the amount of duplication here. Could you define some
common variables and use those in the appends? This will make it
easier to change/upgrade in the future and avoid risk of the
duplicates falling out of sync with each other.

Eg.

    RPI_WIFI_SOURCES = "...."

    SRC_URI_append_raspberrypi3 = "${RPI_WIFI_SOURCES}"
    SRC_URI_append_raspberrypi0-wifi = "${RPI_WIFI_SOURCES}"

-- 
Paul Barker
Togán Labs Ltd

Re: [meta-raspberrypi][PATCH] bluez5: add functions for raspberrypi0-wifi

[Yusuke Mitsuki]

[-- Attachment #1: Type: text/plain, Size: 2845 bytes --]

okay. I will try.

2017-08-25 17:51 GMT+09:00 Paul Barker <pbarker@toganlabs.com>:

> On Thu, Aug 24, 2017 at 1:05 PM, Yusuke Mitsuki
> <mickey.happygolucky@gmail.com> wrote:
> > hciattach on raspberrypi0-wifi failed because BCM43430A1.hcd is not
> found.
> >
> > Paches that in order to use bluetooth with BCM43430 are not enabled.
> > Functions are only enabled with raspberrypi3 in bluez5_%.bbappend like
> as follows:
> >
> > - SRC_URI_append_raspberrypi3
> > - do_install_append_raspberrypi3()
> > - FILES_${PN}_append_raspberrypi3
> > - SYSTEMD_SERVICE_${PN}_append_raspberrypi3
> >
> > These should be enabled with raspberrypi0-wifi too.
> >
> > Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
> > ---
> >  recipes-connectivity/bluez5/bluez5_%.bbappend | 25
> +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend
> b/recipes-connectivity/bluez5/bluez5_%.bbappend
> > index 956d776..075dc2b 100644
> > --- a/recipes-connectivity/bluez5/bluez5_%.bbappend
> > +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
> > @@ -24,3 +24,28 @@ FILES_${PN}_append_raspberrypi3 = " \
> >      "
> >
> >  SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
> > +
> > +SRC_URI_append_raspberrypi0-wifi = " \
> > +    file://BCM43430A1.hcd \
> > +    file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
> > +    file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch
> \
> > +    file://0003-Increase-firmware-load-timeout-to-30s.patch \
> > +    file://0004-Move-the-43xx-firmware-into-lib-firmware.patch \
> > +    file://brcm43438.service \
> > +    "
> > +
> > +do_install_append_raspberrypi0-wifi() {
> > +    install -d ${D}/lib/firmware/brcm/
> > +    install -m 0644 ${WORKDIR}/BCM43430A1.hcd ${D}/lib/firmware/brcm/
> BCM43430A1.hcd
> > +
> > +    if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true',
> 'false', d)}; then
> > +        install -d ${D}${systemd_unitdir}/system
> > +        install -m 0644 ${WORKDIR}/brcm43438.service
> ${D}${systemd_unitdir}/system
> > +    fi
> > +}
> > +
> > +FILES_${PN}_append_raspberrypi0-wifi = " \
> > +    /lib/firmware/brcm/BCM43430A1.hcd \
> > +    "
> > +
> > +SYSTEMD_SERVICE_${PN}_append_raspberrypi0-wifi = " brcm43438.service"
>
> I don't like the amount of duplication here. Could you define some
> common variables and use those in the appends? This will make it
> easier to change/upgrade in the future and avoid risk of the
> duplicates falling out of sync with each other.
>
> Eg.
>
>     RPI_WIFI_SOURCES = "...."
>
>     SRC_URI_append_raspberrypi3 = "${RPI_WIFI_SOURCES}"
>     SRC_URI_append_raspberrypi0-wifi = "${RPI_WIFI_SOURCES}"
>
> --
> Paul Barker
> Togán Labs Ltd
>

[-- Attachment #2: Type: text/html, Size: 3911 bytes --]

Re: [meta-raspberrypi][PATCH] bluez5: add functions for raspberrypi0-wifi

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 3127 bytes --]

On Fri, Aug 25, 2017 at 9:17 PM, Yusuke Mitsuki <
mickey.happygolucky@gmail.com> wrote:

> okay. I will try.
>
> 2017-08-25 17:51 GMT+09:00 Paul Barker <pbarker@toganlabs.com>:
>
>> On Thu, Aug 24, 2017 at 1:05 PM, Yusuke Mitsuki
>> <mickey.happygolucky@gmail.com> wrote:
>> > hciattach on raspberrypi0-wifi failed because BCM43430A1.hcd is not
>> found.
>> >
>> > Paches that in order to use bluetooth with BCM43430 are not enabled.
>> > Functions are only enabled with raspberrypi3 in bluez5_%.bbappend like
>> as follows:
>> >
>> > - SRC_URI_append_raspberrypi3
>> > - do_install_append_raspberrypi3()
>> > - FILES_${PN}_append_raspberrypi3
>> > - SYSTEMD_SERVICE_${PN}_append_raspberrypi3
>> >
>> > These should be enabled with raspberrypi0-wifi too.
>> >
>> > Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
>> > ---
>> >  recipes-connectivity/bluez5/bluez5_%.bbappend | 25
>> +++++++++++++++++++++++++
>> >  1 file changed, 25 insertions(+)
>> >
>> > diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend
>> b/recipes-connectivity/bluez5/bluez5_%.bbappend
>> > index 956d776..075dc2b 100644
>> > --- a/recipes-connectivity/bluez5/bluez5_%.bbappend
>> > +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
>> > @@ -24,3 +24,28 @@ FILES_${PN}_append_raspberrypi3 = " \
>> >      "
>> >
>> >  SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
>> > +
>> > +SRC_URI_append_raspberrypi0-wifi = " \
>> > +    file://BCM43430A1.hcd \
>> > +    file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
>> > +    file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch
>> \
>> > +    file://0003-Increase-firmware-load-timeout-to-30s.patch \
>> > +    file://0004-Move-the-43xx-firmware-into-lib-firmware.patch \
>> > +    file://brcm43438.service \
>> > +    "
>> > +
>> > +do_install_append_raspberrypi0-wifi() {
>> > +    install -d ${D}/lib/firmware/brcm/
>> > +    install -m 0644 ${WORKDIR}/BCM43430A1.hcd
>> ${D}/lib/firmware/brcm/BCM43430A1.hcd
>> > +
>> > +    if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true',
>> 'false', d)}; then
>> > +        install -d ${D}${systemd_unitdir}/system
>> > +        install -m 0644 ${WORKDIR}/brcm43438.service
>> ${D}${systemd_unitdir}/system
>> > +    fi
>> > +}
>> > +
>> > +FILES_${PN}_append_raspberrypi0-wifi = " \
>> > +    /lib/firmware/brcm/BCM43430A1.hcd \
>> > +    "
>> > +
>> > +SYSTEMD_SERVICE_${PN}_append_raspberrypi0-wifi = " brcm43438.service"
>>
>> I don't like the amount of duplication here. Could you define some
>> common variables and use those in the appends? This will make it
>> easier to change/upgrade in the future and avoid risk of the
>> duplicates falling out of sync with each other.
>>
>> Eg.
>>
>>     RPI_WIFI_SOURCES = "...."
>>
>>     SRC_URI_append_raspberrypi3 = "${RPI_WIFI_SOURCES}"
>>     SRC_URI_append_raspberrypi0-wifi = "${RPI_WIFI_SOURCES}"
>>
>>
I know Michal worked on this not long ago. Michal, could you give us some
hints here? Maybe backport the changes in resinOS?


--
Andrei Gherzan

[-- Attachment #2: Type: text/html, Size: 4715 bytes --]

Re: [meta-raspberrypi][PATCH] bluez5: add functions for raspberrypi0-wifi

[Yusuke Mitsuki]

[-- Attachment #1: Type: text/plain, Size: 3505 bytes --]

Sorry I am late.
I could not get time enough for this work.

I will send patches soon.

By the way, If the Michal's  work that Andrei pointed and my patches are
similar, please drop my patches.



2017-09-04 20:05 GMT+09:00 Andrei Gherzan <andrei@gherzan.ro>:

>
>
> On Fri, Aug 25, 2017 at 9:17 PM, Yusuke Mitsuki <
> mickey.happygolucky@gmail.com> wrote:
>
>> okay. I will try.
>>
>> 2017-08-25 17:51 GMT+09:00 Paul Barker <pbarker@toganlabs.com>:
>>
>>> On Thu, Aug 24, 2017 at 1:05 PM, Yusuke Mitsuki
>>> <mickey.happygolucky@gmail.com> wrote:
>>> > hciattach on raspberrypi0-wifi failed because BCM43430A1.hcd is not
>>> found.
>>> >
>>> > Paches that in order to use bluetooth with BCM43430 are not enabled.
>>> > Functions are only enabled with raspberrypi3 in bluez5_%.bbappend like
>>> as follows:
>>> >
>>> > - SRC_URI_append_raspberrypi3
>>> > - do_install_append_raspberrypi3()
>>> > - FILES_${PN}_append_raspberrypi3
>>> > - SYSTEMD_SERVICE_${PN}_append_raspberrypi3
>>> >
>>> > These should be enabled with raspberrypi0-wifi too.
>>> >
>>> > Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
>>> > ---
>>> >  recipes-connectivity/bluez5/bluez5_%.bbappend | 25
>>> +++++++++++++++++++++++++
>>> >  1 file changed, 25 insertions(+)
>>> >
>>> > diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend
>>> b/recipes-connectivity/bluez5/bluez5_%.bbappend
>>> > index 956d776..075dc2b 100644
>>> > --- a/recipes-connectivity/bluez5/bluez5_%.bbappend
>>> > +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
>>> > @@ -24,3 +24,28 @@ FILES_${PN}_append_raspberrypi3 = " \
>>> >      "
>>> >
>>> >  SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
>>> > +
>>> > +SRC_URI_append_raspberrypi0-wifi = " \
>>> > +    file://BCM43430A1.hcd \
>>> > +    file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
>>> > +    file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch
>>> \
>>> > +    file://0003-Increase-firmware-load-timeout-to-30s.patch \
>>> > +    file://0004-Move-the-43xx-firmware-into-lib-firmware.patch \
>>> > +    file://brcm43438.service \
>>> > +    "
>>> > +
>>> > +do_install_append_raspberrypi0-wifi() {
>>> > +    install -d ${D}/lib/firmware/brcm/
>>> > +    install -m 0644 ${WORKDIR}/BCM43430A1.hcd
>>> ${D}/lib/firmware/brcm/BCM43430A1.hcd
>>> > +
>>> > +    if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true',
>>> 'false', d)}; then
>>> > +        install -d ${D}${systemd_unitdir}/system
>>> > +        install -m 0644 ${WORKDIR}/brcm43438.service
>>> ${D}${systemd_unitdir}/system
>>> > +    fi
>>> > +}
>>> > +
>>> > +FILES_${PN}_append_raspberrypi0-wifi = " \
>>> > +    /lib/firmware/brcm/BCM43430A1.hcd \
>>> > +    "
>>> > +
>>> > +SYSTEMD_SERVICE_${PN}_append_raspberrypi0-wifi = " brcm43438.service"
>>>
>>> I don't like the amount of duplication here. Could you define some
>>> common variables and use those in the appends? This will make it
>>> easier to change/upgrade in the future and avoid risk of the
>>> duplicates falling out of sync with each other.
>>>
>>> Eg.
>>>
>>>     RPI_WIFI_SOURCES = "...."
>>>
>>>     SRC_URI_append_raspberrypi3 = "${RPI_WIFI_SOURCES}"
>>>     SRC_URI_append_raspberrypi0-wifi = "${RPI_WIFI_SOURCES}"
>>>
>>>
> I know Michal worked on this not long ago. Michal, could you give us some
> hints here? Maybe backport the changes in resinOS?
>
>
> --
> Andrei Gherzan
>
>

[-- Attachment #2: Type: text/html, Size: 5770 bytes --]

[meta-raspberrypi][PATCH v2 1/2] bluez5: add functions/variables to enabling bluetooth on another raspberrypi

[Yusuke Mitsuki]

functions/variables in this bbappend implemented for only raspberrypi3.
But these must be able to used to enabling bluetooth on another raspberrypi that has bluetooth feature such as raspberrypi0-wifi.

The simple solution is a duplicating these but it is not good ideas for maintainance.

Add functions/variables follows to simplify to enabling bluetooth on another raspberrypi that has bluetooth.
- BCM_BT_SOURCES
- enable_bcm_bluetooth()
- BCM_BT_FIRMWARE
- BCM_BT_SERVICE

Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
---
 recipes-connectivity/bluez5/bluez5_%.bbappend | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend b/recipes-connectivity/bluez5/bluez5_%.bbappend
index 956d776..b2fbf22 100644
--- a/recipes-connectivity/bluez5/bluez5_%.bbappend
+++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
@@ -1,6 +1,6 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-SRC_URI_append_raspberrypi3 = " \
+BCM_BT_SOURCES =  " \
     file://BCM43430A1.hcd \
     file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
     file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch \
@@ -9,7 +9,7 @@ SRC_URI_append_raspberrypi3 = " \
     file://brcm43438.service \
     "
 
-do_install_append_raspberrypi3() {
+enable_bcm_bluetooth() {
     install -d ${D}/lib/firmware/brcm/
     install -m 0644 ${WORKDIR}/BCM43430A1.hcd ${D}/lib/firmware/brcm/BCM43430A1.hcd
 
@@ -19,8 +19,18 @@ do_install_append_raspberrypi3() {
     fi
 }
 
-FILES_${PN}_append_raspberrypi3 = " \
+BCM_BT_FIRMWARE =  " \
     /lib/firmware/brcm/BCM43430A1.hcd \
     "
 
-SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
+BCM_BT_SERVICE =  " brcm43438.service"
+
+SRC_URI_append_raspberrypi3 = " ${BCM_BT_SOURCES}"
+
+do_install_append_raspberrypi3() {
+    enable_bcm_bluetooth
+}
+
+FILES_${PN}_append_raspberrypi3 = " ${BCM_BT_FIRMWARE}"
+
+SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " ${BCM_BT_SERVICE}"
-- 
2.7.4

[meta-raspberrypi][PATCH v2 2/2] bluez5: enable bluetooth on raspberrypi0-wifi

[Yusuke Mitsuki]

Add functions/variable to enabling bluetooth on raspberrypi0-wifi.

Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
---
 recipes-connectivity/bluez5/bluez5_%.bbappend | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend b/recipes-connectivity/bluez5/bluez5_%.bbappend
index b2fbf22..03efd5c 100644
--- a/recipes-connectivity/bluez5/bluez5_%.bbappend
+++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
@@ -25,6 +25,7 @@ BCM_BT_FIRMWARE =  " \
 
 BCM_BT_SERVICE =  " brcm43438.service"
 
+# for raspberrypi3
 SRC_URI_append_raspberrypi3 = " ${BCM_BT_SOURCES}"
 
 do_install_append_raspberrypi3() {
@@ -34,3 +35,14 @@ do_install_append_raspberrypi3() {
 FILES_${PN}_append_raspberrypi3 = " ${BCM_BT_FIRMWARE}"
 
 SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " ${BCM_BT_SERVICE}"
+
+# for raspberrypi0-wifi
+SRC_URI_append_raspberrypi0-wifi = " ${BCM_BT_SOURCES}"
+
+do_install_append_raspberrypi0-wifi() {
+    enable_bcm_bluetooth
+}
+
+FILES_${PN}_append_raspberrypi0-wifi = " ${BCM_BT_FIRMWARE}"
+
+SYSTEMD_SERVICE_${PN}_append_raspberrypi0-wifi = " ${BCM_BT_SERVICE}"
-- 
2.7.4

Re: [meta-raspberrypi][PATCH v2 1/2] bluez5: add functions/variables to enabling bluetooth on another raspberrypi

[Paul Barker]

On Tue, Sep 5, 2017 at 11:34 PM, Yusuke Mitsuki
<mickey.happygolucky@gmail.com> wrote:
> functions/variables in this bbappend implemented for only raspberrypi3.
> But these must be able to used to enabling bluetooth on another raspberrypi that has bluetooth feature such as raspberrypi0-wifi.
>
> The simple solution is a duplicating these but it is not good ideas for maintainance.
>
> Add functions/variables follows to simplify to enabling bluetooth on another raspberrypi that has bluetooth.
> - BCM_BT_SOURCES
> - enable_bcm_bluetooth()
> - BCM_BT_FIRMWARE
> - BCM_BT_SERVICE
>
> Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
> ---
>  recipes-connectivity/bluez5/bluez5_%.bbappend | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend b/recipes-connectivity/bluez5/bluez5_%.bbappend
> index 956d776..b2fbf22 100644
> --- a/recipes-connectivity/bluez5/bluez5_%.bbappend
> +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
> @@ -1,6 +1,6 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> -SRC_URI_append_raspberrypi3 = " \
> +BCM_BT_SOURCES =  " \
>      file://BCM43430A1.hcd \
>      file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
>      file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch \
> @@ -9,7 +9,7 @@ SRC_URI_append_raspberrypi3 = " \
>      file://brcm43438.service \
>      "
>
> -do_install_append_raspberrypi3() {
> +enable_bcm_bluetooth() {
>      install -d ${D}/lib/firmware/brcm/
>      install -m 0644 ${WORKDIR}/BCM43430A1.hcd ${D}/lib/firmware/brcm/BCM43430A1.hcd
>
> @@ -19,8 +19,18 @@ do_install_append_raspberrypi3() {
>      fi
>  }
>
> -FILES_${PN}_append_raspberrypi3 = " \
> +BCM_BT_FIRMWARE =  " \
>      /lib/firmware/brcm/BCM43430A1.hcd \
>      "
>
> -SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
> +BCM_BT_SERVICE =  " brcm43438.service"
> +
> +SRC_URI_append_raspberrypi3 = " ${BCM_BT_SOURCES}"
> +
> +do_install_append_raspberrypi3() {
> +    enable_bcm_bluetooth
> +}
> +
> +FILES_${PN}_append_raspberrypi3 = " ${BCM_BT_FIRMWARE}"
> +
> +SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " ${BCM_BT_SERVICE}"
> --
> 2.7.4
>

This and the follow up patch look excellent, should be easy to modify
in the future if we need to.

We have switched to using github pull requests for meta-raspberrypi.
Could you open a pull request on
https://github.com/agherzan/meta-raspberrypi with these changes
please? Let me know if you have any issues doing that.

Thanks,

-- 
Paul Barker
Togán Labs Ltd

Re: [meta-raspberrypi][PATCH v2 1/2] bluez5: add functions/variables to enabling bluetooth on another raspberrypi

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 3038 bytes --]

On Wed, Sep 6, 2017 at 10:18 AM, Paul Barker <pbarker@toganlabs.com> wrote:

> On Tue, Sep 5, 2017 at 11:34 PM, Yusuke Mitsuki
> <mickey.happygolucky@gmail.com> wrote:
> > functions/variables in this bbappend implemented for only raspberrypi3.
> > But these must be able to used to enabling bluetooth on another
> raspberrypi that has bluetooth feature such as raspberrypi0-wifi.
> >
> > The simple solution is a duplicating these but it is not good ideas for
> maintainance.
> >
> > Add functions/variables follows to simplify to enabling bluetooth on
> another raspberrypi that has bluetooth.
> > - BCM_BT_SOURCES
> > - enable_bcm_bluetooth()
> > - BCM_BT_FIRMWARE
> > - BCM_BT_SERVICE
> >
> > Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
> > ---
> >  recipes-connectivity/bluez5/bluez5_%.bbappend | 18 ++++++++++++++----
> >  1 file changed, 14 insertions(+), 4 deletions(-)
> >
> > diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend
> b/recipes-connectivity/bluez5/bluez5_%.bbappend
> > index 956d776..b2fbf22 100644
> > --- a/recipes-connectivity/bluez5/bluez5_%.bbappend
> > +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
> > @@ -1,6 +1,6 @@
> >  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> > -SRC_URI_append_raspberrypi3 = " \
> > +BCM_BT_SOURCES =  " \
> >      file://BCM43430A1.hcd \
> >      file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
> >      file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch
> \
> > @@ -9,7 +9,7 @@ SRC_URI_append_raspberrypi3 = " \
> >      file://brcm43438.service \
> >      "
> >
> > -do_install_append_raspberrypi3() {
> > +enable_bcm_bluetooth() {
> >      install -d ${D}/lib/firmware/brcm/
> >      install -m 0644 ${WORKDIR}/BCM43430A1.hcd ${D}/lib/firmware/brcm/
> BCM43430A1.hcd
> >
> > @@ -19,8 +19,18 @@ do_install_append_raspberrypi3() {
> >      fi
> >  }
> >
> > -FILES_${PN}_append_raspberrypi3 = " \
> > +BCM_BT_FIRMWARE =  " \
> >      /lib/firmware/brcm/BCM43430A1.hcd \
> >      "
> >
> > -SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
> > +BCM_BT_SERVICE =  " brcm43438.service"
> > +
> > +SRC_URI_append_raspberrypi3 = " ${BCM_BT_SOURCES}"
> > +
> > +do_install_append_raspberrypi3() {
> > +    enable_bcm_bluetooth
> > +}
> > +
> > +FILES_${PN}_append_raspberrypi3 = " ${BCM_BT_FIRMWARE}"
> > +
> > +SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " ${BCM_BT_SERVICE}"
> > --
> > 2.7.4
> >
>
> This and the follow up patch look excellent, should be easy to modify
> in the future if we need to.
>
> We have switched to using github pull requests for meta-raspberrypi.
> Could you open a pull request on
> https://github.com/agherzan/meta-raspberrypi with these changes
> please? Let me know if you have any issues doing that.
>

+1 from my side.  Thanks for this change. We still try to keep patches
rolling to the mailing list too but the main development now happens
through PRs in github.

--
Andrei Gherzan

[-- Attachment #2: Type: text/html, Size: 4242 bytes --]

Re: [meta-raspberrypi][PATCH v2 1/2] bluez5: add functions/variables to enabling bluetooth on another raspberrypi

[Yusuke Mitsuki]

Hello Andrei and Paul

Thanks for your replies.
I will create PR in github.


2017-09-07 2:52 GMT+09:00 Andrei Gherzan <andrei@gherzan.ro>:
> On Wed, Sep 6, 2017 at 10:18 AM, Paul Barker <pbarker@toganlabs.com> wrote:
>>
>> On Tue, Sep 5, 2017 at 11:34 PM, Yusuke Mitsuki
>> <mickey.happygolucky@gmail.com> wrote:
>> > functions/variables in this bbappend implemented for only raspberrypi3.
>> > But these must be able to used to enabling bluetooth on another
>> > raspberrypi that has bluetooth feature such as raspberrypi0-wifi.
>> >
>> > The simple solution is a duplicating these but it is not good ideas for
>> > maintainance.
>> >
>> > Add functions/variables follows to simplify to enabling bluetooth on
>> > another raspberrypi that has bluetooth.
>> > - BCM_BT_SOURCES
>> > - enable_bcm_bluetooth()
>> > - BCM_BT_FIRMWARE
>> > - BCM_BT_SERVICE
>> >
>> > Signed-off-by: Yusuke Mitsuki <mickey.happygolucky@gmail.com>
>> > ---
>> >  recipes-connectivity/bluez5/bluez5_%.bbappend | 18 ++++++++++++++----
>> >  1 file changed, 14 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend
>> > b/recipes-connectivity/bluez5/bluez5_%.bbappend
>> > index 956d776..b2fbf22 100644
>> > --- a/recipes-connectivity/bluez5/bluez5_%.bbappend
>> > +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend
>> > @@ -1,6 +1,6 @@
>> >  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> >
>> > -SRC_URI_append_raspberrypi3 = " \
>> > +BCM_BT_SOURCES =  " \
>> >      file://BCM43430A1.hcd \
>> >      file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \
>> >
>> > file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch \
>> > @@ -9,7 +9,7 @@ SRC_URI_append_raspberrypi3 = " \
>> >      file://brcm43438.service \
>> >      "
>> >
>> > -do_install_append_raspberrypi3() {
>> > +enable_bcm_bluetooth() {
>> >      install -d ${D}/lib/firmware/brcm/
>> >      install -m 0644 ${WORKDIR}/BCM43430A1.hcd
>> > ${D}/lib/firmware/brcm/BCM43430A1.hcd
>> >
>> > @@ -19,8 +19,18 @@ do_install_append_raspberrypi3() {
>> >      fi
>> >  }
>> >
>> > -FILES_${PN}_append_raspberrypi3 = " \
>> > +BCM_BT_FIRMWARE =  " \
>> >      /lib/firmware/brcm/BCM43430A1.hcd \
>> >      "
>> >
>> > -SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service"
>> > +BCM_BT_SERVICE =  " brcm43438.service"
>> > +
>> > +SRC_URI_append_raspberrypi3 = " ${BCM_BT_SOURCES}"
>> > +
>> > +do_install_append_raspberrypi3() {
>> > +    enable_bcm_bluetooth
>> > +}
>> > +
>> > +FILES_${PN}_append_raspberrypi3 = " ${BCM_BT_FIRMWARE}"
>> > +
>> > +SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " ${BCM_BT_SERVICE}"
>> > --
>> > 2.7.4
>> >
>>
>> This and the follow up patch look excellent, should be easy to modify
>> in the future if we need to.
>>
>> We have switched to using github pull requests for meta-raspberrypi.
>> Could you open a pull request on
>> https://github.com/agherzan/meta-raspberrypi with these changes
>> please? Let me know if you have any issues doing that.
>
>
> +1 from my side.  Thanks for this change. We still try to keep patches
> rolling to the mailing list too but the main development now happens through
> PRs in github.
>
> --
> Andrei Gherzan