All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Govind Singh <govinds@qti.qualcomm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	Govind Singh <govinds@codeaurora.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target
Date: Thu, 1 Mar 2018 14:27:35 +0100	[thread overview]
Message-ID: <CAK8P3a06sDwL8iech_L3Q-zGxio3_RD8c7_-L3HHmFmb=Pq2UQ@mail.gmail.com> (raw)
In-Reply-To: <588e4d951bd84ea29dfc1a68353505e7@aphydexm01b.ap.qualcomm.com>

On Thu, Mar 1, 2018 at 2:18 PM, Govind Singh <govinds@qti.qualcomm.com> wro=
te:
>>> The asm/dma-iommu.h header file exsists only on arm32, no other archite=
cture.
>>> I'm not sure about the purpose of the patch to start with:
>>> it's normally up to the platform code to allocate IOMMU domains, device=
 drivers should only need to manually interact with the IOMMU layer if they=
 need more than one domain, but this ath10k patch appears to be using the d=
efault domain and should have no effect as long as the platform code works =
correctly.
> Thanks Arnd, I have fixed this and migrated to  64bit API's(iommu_attach_=
device/iommu_detach_device/ iommu_get_domain_for_dev), will share the next =
revision.
> I tried using the default domain by adding the stream ID and mask in dt a=
nd no manual interaction, but it is resulting in TZ error and unhandled con=
text fault.
> Seems I need to provide explicit mapping range(aperture_start/ aperture_e=
nd) as this is only working combination for me..

I don't see why you need to do that at all, can you clarify?

The IOMMU should be set up implicitly for you here based on the iommus
property in DT,
with no driver changes at all. This should work on all architectures/

       Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Govind Singh <govinds@qti.qualcomm.com>
Cc: Govind Singh <govinds@codeaurora.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target
Date: Thu, 1 Mar 2018 14:27:35 +0100	[thread overview]
Message-ID: <CAK8P3a06sDwL8iech_L3Q-zGxio3_RD8c7_-L3HHmFmb=Pq2UQ@mail.gmail.com> (raw)
In-Reply-To: <588e4d951bd84ea29dfc1a68353505e7@aphydexm01b.ap.qualcomm.com>

On Thu, Mar 1, 2018 at 2:18 PM, Govind Singh <govinds@qti.qualcomm.com> wrote:
>>> The asm/dma-iommu.h header file exsists only on arm32, no other architecture.
>>> I'm not sure about the purpose of the patch to start with:
>>> it's normally up to the platform code to allocate IOMMU domains, device drivers should only need to manually interact with the IOMMU layer if they need more than one domain, but this ath10k patch appears to be using the default domain and should have no effect as long as the platform code works correctly.
> Thanks Arnd, I have fixed this and migrated to  64bit API's(iommu_attach_device/iommu_detach_device/ iommu_get_domain_for_dev), will share the next revision.
> I tried using the default domain by adding the stream ID and mask in dt and no manual interaction, but it is resulting in TZ error and unhandled context fault.
> Seems I need to provide explicit mapping range(aperture_start/ aperture_end) as this is only working combination for me..

I don't see why you need to do that at all, can you clarify?

The IOMMU should be set up implicitly for you here based on the iommus
property in DT,
with no driver changes at all. This should work on all architectures/

       Arnd

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-03-01 13:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15  9:04 [PATCH] ath10k: Enable IOMMU support for WCN3990 target Govind Singh
2018-02-15  9:04 ` Govind Singh
2018-03-01 10:01 ` Kalle Valo
2018-03-01 10:01   ` Kalle Valo
2018-03-01 10:10   ` Arnd Bergmann
2018-03-01 10:10     ` Arnd Bergmann
2018-03-01 13:18     ` Govind Singh
2018-03-01 13:18       ` Govind Singh
2018-03-01 13:27       ` Arnd Bergmann [this message]
2018-03-01 13:27         ` Arnd Bergmann
2018-03-08 13:50         ` Kalle Valo
2018-03-08 13:50           ` Kalle Valo
2018-03-08 13:59           ` govinds
2018-03-08 13:59             ` govinds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a06sDwL8iech_L3Q-zGxio3_RD8c7_-L3HHmFmb=Pq2UQ@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=ath10k@lists.infradead.org \
    --cc=govinds@codeaurora.org \
    --cc=govinds@qti.qualcomm.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.