From: Arnd Bergmann <arnd@arndb.de> To: Goldwyn Rodrigues <rgoldwyn@suse.de> Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>, y2038 Mailman List <y2038@lists.linaro.org>, Eric Ren <zren@suse.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Deepa Dinamani <deepa.kernel@gmail.com>, ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: clean up timestamp handling Date: Wed, 20 Jun 2018 09:39:21 +0200 [thread overview] Message-ID: <CAK8P3a2CVxTioR0s9xX3T_q+wR6mxHXTyw1U5vWaPeabNQrR0Q@mail.gmail.com> (raw) In-Reply-To: <20180619215202.zniqq3py3hqjeudv@merlin> On Tue, Jun 19, 2018 at 11:52 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote: > On 06-19 21:11, Arnd Bergmann wrote: >> On Tue, Jun 19, 2018 at 7:14 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote: >> > On 06-19 17:58, Arnd Bergmann wrote: >> Here, setting a timestamp before 1970 or after 2514 will get wrapped >> around in unpatched kernels, but will be clamped to the minimum >> and maximum times after the patch. >> >> It is extremely rare for correct code to need timestamps outside of that >> range, but it is also trivial to trigger that with a manual 'touch' command >> from user space. >> >> If the change is a problem, I can resend the patch without that one >> line change. >> > > I think you should keep the change, but incrment OCFS2_LVB_VERSION. Won't that cause additional incompatibilities? I don't know how this macro gets used, but normally we don't use version numbers in kernel interfaces if that prevents us from using old user space code with newer kernels. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: Goldwyn Rodrigues <rgoldwyn@suse.de> Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>, y2038 Mailman List <y2038@lists.linaro.org>, Eric Ren <zren@suse.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Deepa Dinamani <deepa.kernel@gmail.com>, ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [PATCH] ocfs2: dlmglue: clean up timestamp handling Date: Wed, 20 Jun 2018 09:39:21 +0200 [thread overview] Message-ID: <CAK8P3a2CVxTioR0s9xX3T_q+wR6mxHXTyw1U5vWaPeabNQrR0Q@mail.gmail.com> (raw) In-Reply-To: <20180619215202.zniqq3py3hqjeudv@merlin> On Tue, Jun 19, 2018 at 11:52 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote: > On 06-19 21:11, Arnd Bergmann wrote: >> On Tue, Jun 19, 2018 at 7:14 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote: >> > On 06-19 17:58, Arnd Bergmann wrote: >> Here, setting a timestamp before 1970 or after 2514 will get wrapped >> around in unpatched kernels, but will be clamped to the minimum >> and maximum times after the patch. >> >> It is extremely rare for correct code to need timestamps outside of that >> range, but it is also trivial to trigger that with a manual 'touch' command >> from user space. >> >> If the change is a problem, I can resend the patch without that one >> line change. >> > > I think you should keep the change, but incrment OCFS2_LVB_VERSION. Won't that cause additional incompatibilities? I don't know how this macro gets used, but normally we don't use version numbers in kernel interfaces if that prevents us from using old user space code with newer kernels. Arnd
next prev parent reply other threads:[~2018-06-20 8:40 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-19 15:58 [PATCH] ocfs2: dlmglue: clean up timestamp handling Arnd Bergmann 2018-06-19 15:58 ` [Ocfs2-devel] " Arnd Bergmann 2018-06-19 17:14 ` Goldwyn Rodrigues 2018-06-19 17:14 ` Goldwyn Rodrigues 2018-06-19 19:11 ` Arnd Bergmann 2018-06-19 19:11 ` Arnd Bergmann 2018-06-19 21:52 ` Goldwyn Rodrigues 2018-06-19 21:52 ` Goldwyn Rodrigues 2018-06-20 7:39 ` Arnd Bergmann [this message] 2018-06-20 7:39 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK8P3a2CVxTioR0s9xX3T_q+wR6mxHXTyw1U5vWaPeabNQrR0Q@mail.gmail.com \ --to=arnd@arndb.de \ --cc=deepa.kernel@gmail.com \ --cc=jlbec@evilplan.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark@fasheh.com \ --cc=ocfs2-devel@oss.oracle.com \ --cc=rgoldwyn@suse.de \ --cc=y2038@lists.linaro.org \ --cc=zren@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.