From: Arnd Bergmann <arnd@arndb.de> To: Felipe Balbi <balbi@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Russell King <linux@armlinux.org.uk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, USB list <linux-usb@vger.kernel.org> Subject: Re: [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency Date: Fri, 7 Aug 2020 19:42:30 +0200 [thread overview] Message-ID: <CAK8P3a2UH2NELh8ifZj0s+Xv1vqURjwJWU5Qb2FQiOq7c=dcBg@mail.gmail.com> (raw) In-Reply-To: <87v9hupnf7.fsf@kernel.org> On Fri, Aug 7, 2020 at 3:59 PM Felipe Balbi <balbi@kernel.org> wrote: > Krzysztof Kozlowski <krzk@kernel.org> writes: > > +#include <linux/delay.h> > > + > > #define S3C2443_CLKREG(x) ((x) + S3C24XX_VA_CLKPWR) > > > > #define S3C2443_PLLCON_MDIVSHIFT 16 > > @@ -184,5 +186,52 @@ s3c2443_get_epll(unsigned int pllval, unsigned int baseclk) > > return (unsigned int)fvco; > > } > > > > +static inline void s3c_hsudc_init_phy(void) > > This should, really, be a PHY driver under drivers/phy, since the goal > is to make this platform-independent, might as well take the opportunity > to introduce a proper driver, no? In theory, this is absolutely correct. I fear it will be hard to find anyone to make a larger scale cleanup of the file however. As my old changelog text says, there is only one board (smdk2416) in the kernel that registers the device. My change was the minimum to keep it working during the move to a multiplatform configuration, but if there is someone who has the hardware and volunteers to make a proper phy driver, that would also work. As the board only exists as a reference for other boards, but none of those made it into the kernel, we could alternatively just decide to drop the driver. There is also a .dts file for the board, which is lacking a device node for the udc (and the driver lacks DT support), so that board file could also be dropped then, leaving only the DT version as a reference for the SoC. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: Felipe Balbi <balbi@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, USB list <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Russell King <linux@armlinux.org.uk>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency Date: Fri, 7 Aug 2020 19:42:30 +0200 [thread overview] Message-ID: <CAK8P3a2UH2NELh8ifZj0s+Xv1vqURjwJWU5Qb2FQiOq7c=dcBg@mail.gmail.com> (raw) In-Reply-To: <87v9hupnf7.fsf@kernel.org> On Fri, Aug 7, 2020 at 3:59 PM Felipe Balbi <balbi@kernel.org> wrote: > Krzysztof Kozlowski <krzk@kernel.org> writes: > > +#include <linux/delay.h> > > + > > #define S3C2443_CLKREG(x) ((x) + S3C24XX_VA_CLKPWR) > > > > #define S3C2443_PLLCON_MDIVSHIFT 16 > > @@ -184,5 +186,52 @@ s3c2443_get_epll(unsigned int pllval, unsigned int baseclk) > > return (unsigned int)fvco; > > } > > > > +static inline void s3c_hsudc_init_phy(void) > > This should, really, be a PHY driver under drivers/phy, since the goal > is to make this platform-independent, might as well take the opportunity > to introduce a proper driver, no? In theory, this is absolutely correct. I fear it will be hard to find anyone to make a larger scale cleanup of the file however. As my old changelog text says, there is only one board (smdk2416) in the kernel that registers the device. My change was the minimum to keep it working during the move to a multiplatform configuration, but if there is someone who has the hardware and volunteers to make a proper phy driver, that would also work. As the board only exists as a reference for other boards, but none of those made it into the kernel, we could alternatively just decide to drop the driver. There is also a .dts file for the board, which is lacking a device node for the udc (and the driver lacks DT support), so that board file could also be dropped then, leaving only the DT version as a reference for the SoC. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-07 17:42 UTC|newest] Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-06 18:19 [PATCH v2 00/41] spi / fbdev / cpufreq / usb / mmc / hwmon / ARM: Prepare for multiplatform S3C Krzysztof Kozlowski 2020-08-06 18:19 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 01/41] ARM: s3c: Remove unneeded machine header includes Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-19 12:15 ` Mark Brown 2020-08-19 12:15 ` Mark Brown 2020-08-19 19:02 ` Krzysztof Kozlowski 2020-08-19 19:02 ` Krzysztof Kozlowski 2020-08-19 19:17 ` Mark Brown 2020-08-19 19:17 ` Mark Brown 2020-08-20 15:39 ` Krzysztof Kozlowski 2020-08-20 15:39 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 02/41] mmc: s3cmci: Remove unneeded machine header include Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-12 14:05 ` Ulf Hansson 2020-08-12 14:05 ` Ulf Hansson 2020-08-06 18:20 ` [PATCH v2 03/41] ARM: s3c24xx: fix mmc gpio lookup tables Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-13 8:10 ` Linus Walleij 2020-08-13 8:10 ` Linus Walleij 2020-08-06 18:20 ` [PATCH v2 04/41] ARM: s3c24xx: iotiming: make functions static Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 05/41] ARM: s3c24xx: make S3C24XX_MISCCR access indirect Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-12 7:53 ` Stephen Boyd 2020-08-12 7:53 ` Stephen Boyd 2020-08-06 18:20 ` [PATCH v2 06/41] ARM: s3c24xx: pass pointer to clk driver via platform data Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-12 7:55 ` Stephen Boyd 2020-08-12 7:55 ` Stephen Boyd 2020-08-06 18:20 ` [PATCH v2 07/41] ARM: s3c24xx: simplify mach/io.h Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 08/41] usb: gadget: s3c: use platform resources Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 13:57 ` Felipe Balbi 2020-08-07 13:57 ` Felipe Balbi 2020-08-06 18:20 ` [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 13:59 ` Felipe Balbi 2020-08-07 13:59 ` Felipe Balbi 2020-08-07 17:42 ` Arnd Bergmann [this message] 2020-08-07 17:42 ` Arnd Bergmann 2020-08-09 8:44 ` Krzysztof Kozlowski 2020-08-09 8:44 ` Krzysztof Kozlowski 2020-08-10 12:51 ` Felipe Balbi 2020-08-10 12:51 ` Felipe Balbi 2020-08-06 18:20 ` [PATCH v2 10/41] ARM: samsung: don't build plat/pm-common for Exynos Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 11/41] ARM: samsung: remove s3c_pm_debug_init() Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 12/41] ARM: samsung: make pm-debug platform independent Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 13/41] ARM: samsung: move CONFIG_DEBUG_S3C_UART to Kconfig.debug Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 14/41] ARM: exynos: use private samsung_cpu_id copy Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 15/41] ARM: exynos: stop selecting PLAT_SAMSUNG Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 16/41] ARM: samsung: move pm check code to drivers/soc Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 17/41] ARM: s5pv210: use private pm save/restore Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 18/41] ARM: s5pv210: don't imply CONFIG_PLAT_SAMSUNG Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 11:35 ` Mark Brown 2020-08-07 11:35 ` Mark Brown 2020-08-07 11:35 ` Mark Brown 2020-08-06 18:20 ` [PATCH v2 19/41] ARM: s3c64xx: remove mach/hardware.h Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 20/41] ARM: s3c24xx: move regs-spi.h into spi driver Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 11:34 ` Mark Brown 2020-08-07 11:34 ` Mark Brown 2020-08-06 18:20 ` [PATCH v2 21/41] ARM: s3c24xx: move irqchip driver back into platform Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 8:01 ` Marc Zyngier 2020-08-07 8:01 ` Marc Zyngier 2020-08-06 18:20 ` [PATCH v2 22/41] ARM: s3c: adc: move header to linux/soc/samsung Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 23/41] ARM: s3c24xx: move spi fiq handler into platform Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 11:50 ` Mark Brown 2020-08-07 11:50 ` Mark Brown 2020-08-19 19:51 ` Krzysztof Kozlowski 2020-08-19 19:51 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 24/41] ASoC: samsung: h1940: turn into platform driver Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 25/41] ASoC: samsung: neo1973: " Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 26/41] ASoC: samsung: rx1950: " Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 27/41] ASoC: samsung: s3c2412-i2s: avoid hardcoded S3C2410_PA_IIS Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 28/41] ARM: s3c24xx: move iis pinctrl config into boards Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 11:51 ` Mark Brown 2020-08-07 11:51 ` Mark Brown 2020-08-07 11:51 ` Mark Brown 2020-08-06 18:20 ` [PATCH v2 29/41] ARM: s3c24xx: move s3cmci pinctrl handling into board files Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 30/41] ARM: s3c24xx: include mach/irqs.h where needed Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 31/41] ARM: s3c24xx: spi: avoid hardcoding fiq number in driver Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 11:51 ` Mark Brown 2020-08-07 11:51 ` Mark Brown 2020-08-06 18:20 ` [PATCH v2 32/41] ARM: s3c24xx: bast: avoid irq_desc array usage Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 33/41] fbdev: s3c2410fb: remove mach header dependency Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 34/41] cpufreq: s3c24xx: split out registers Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 4:54 ` Viresh Kumar 2020-08-07 4:54 ` Viresh Kumar 2020-08-06 18:20 ` [PATCH v2 35/41] ARM: s3c: remove cpufreq header dependencies Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 4:56 ` Viresh Kumar 2020-08-07 4:56 ` Viresh Kumar 2020-08-06 18:20 ` [PATCH v2 36/41] cpufreq: s3c2412: use global s3c2412_cpufreq_setrefresh Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 4:57 ` Viresh Kumar 2020-08-07 4:57 ` Viresh Kumar 2020-08-06 18:20 ` [PATCH v2 37/41] cpufreq: s3c24xx: move low-level clk reg access into platform code Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-07 4:58 ` Viresh Kumar 2020-08-07 4:58 ` Viresh Kumar 2020-08-06 18:20 ` [PATCH v2 38/41] ARM: s3c24xx: stop including mach/hardware.h from mach/io.h Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 39/41] ARM: s3c: move into a common directory Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 40/41] ARM: s3c: make headers local if possible Krzysztof Kozlowski 2020-08-06 18:20 ` Krzysztof Kozlowski 2020-08-06 18:20 ` [PATCH v2 41/41] MAINTAINERS: Add more name matches for Samsung SoC entries Krzysztof Kozlowski 2020-08-06 21:57 ` [PATCH v2 00/41] spi / fbdev / cpufreq / usb / mmc / hwmon / ARM: Prepare for multiplatform S3C Arnd Bergmann 2020-08-06 21:57 ` Arnd Bergmann 2020-08-07 11:33 ` Mark Brown 2020-08-07 11:33 ` Mark Brown 2020-08-07 11:33 ` Mark Brown 2020-08-07 11:44 ` Krzysztof Kozlowski 2020-08-07 11:44 ` Krzysztof Kozlowski 2020-08-07 11:44 ` Krzysztof Kozlowski 2020-08-20 15:59 ` Krzysztof Kozlowski 2020-08-20 15:59 ` Krzysztof Kozlowski 2020-08-20 15:59 ` Krzysztof Kozlowski 2020-08-21 13:52 ` Bartlomiej Zolnierkiewicz 2020-08-21 13:52 ` Bartlomiej Zolnierkiewicz 2020-08-21 13:52 ` Bartlomiej Zolnierkiewicz 2020-08-21 13:52 ` Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK8P3a2UH2NELh8ifZj0s+Xv1vqURjwJWU5Qb2FQiOq7c=dcBg@mail.gmail.com' \ --to=arnd@arndb.de \ --cc=balbi@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@armlinux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.