All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bert Vermeulen <bert@biot.com>
Cc: DTML <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Anshuman Khandual" <anshuman.khandual@arm.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"John Crispin" <john@phrozen.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"YiFei Zhu" <yifeifz2@illinois.edu>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Felix Fietkau" <nbd@nbd.name>
Subject: Re: [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC
Date: Fri, 30 Jul 2021 16:48:28 +0200	[thread overview]
Message-ID: <CAK8P3a3OuJ3pMSdEA4Rt3aWvvuX2+_Bg5x7-kZ1++fvvJvgGxA@mail.gmail.com> (raw)
In-Reply-To: <20210730134552.853350-5-bert@biot.com>

On Fri, Jul 30, 2021 at 3:45 PM Bert Vermeulen <bert@biot.com> wrote:
>
> From: John Crispin <john@phrozen.org>
>
> EN7523 is an armv7 based silicon used inside broadband access type devices
> such as xPON and xDSL. It shares various silicon blocks with MediaTek
> silicon such as the MT7622.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bert Vermeulen <bert@biot.com>

It's always nice to see a new SoC family.

> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -580,6 +580,20 @@ config ARCH_VIRT
>         select HAVE_ARM_ARCH_TIMER
>         select ARCH_SUPPORTS_BIG_ENDIAN
>
> +config ARCH_ECONET
> +       bool "Econet SoC Support"
> +       depends on ARCH_MULTI_V7
> +       select ARM_AMBA
> +       select ARM_GIC
> +       select ARM_GIC_V3
> +       select ARM_DMA_USE_IOMMU
> +       select ARM_PSCI
> +       select HAVE_ARM_ARCH_TIMER
> +       select IOMMU_DMA
> +       select COMMON_CLK
> +       help
> +         Support for Econet EN7523 SoCs

Given how closely related this probably is to MT7623/MT7622, should this
perhaps just be part of arch/arm/mach-mediatek? According to
https://wikidevi.wi-cat.ru/MediaTek#xPON, the older (mips based) MT752x
chips are apparently just rebranded to EN752x after the business unit
was spun off, but I guess they are still in the same family.

> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 173da685a52e..1bff0aa29c07 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -152,6 +152,7 @@ textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
>  textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
>  textofs-$(CONFIG_ARCH_MESON) := 0x00208000
>  textofs-$(CONFIG_ARCH_AXXIA) := 0x00308000
> +textofs-$(CONFIG_ARCH_ECONET) := 0x00088000

Why is this needed?

Note also the comment directly above it exlaining
# Text offset. This list is sorted numerically by address in order to
# provide a means to avoid/resolve conflicts in multi-arch kernels.

       Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Bert Vermeulen <bert@biot.com>
Cc: DTML <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Anshuman Khandual" <anshuman.khandual@arm.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"John Crispin" <john@phrozen.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"YiFei Zhu" <yifeifz2@illinois.edu>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Felix Fietkau" <nbd@nbd.name>
Subject: Re: [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC
Date: Fri, 30 Jul 2021 16:48:28 +0200	[thread overview]
Message-ID: <CAK8P3a3OuJ3pMSdEA4Rt3aWvvuX2+_Bg5x7-kZ1++fvvJvgGxA@mail.gmail.com> (raw)
In-Reply-To: <20210730134552.853350-5-bert@biot.com>

On Fri, Jul 30, 2021 at 3:45 PM Bert Vermeulen <bert@biot.com> wrote:
>
> From: John Crispin <john@phrozen.org>
>
> EN7523 is an armv7 based silicon used inside broadband access type devices
> such as xPON and xDSL. It shares various silicon blocks with MediaTek
> silicon such as the MT7622.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bert Vermeulen <bert@biot.com>

It's always nice to see a new SoC family.

> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -580,6 +580,20 @@ config ARCH_VIRT
>         select HAVE_ARM_ARCH_TIMER
>         select ARCH_SUPPORTS_BIG_ENDIAN
>
> +config ARCH_ECONET
> +       bool "Econet SoC Support"
> +       depends on ARCH_MULTI_V7
> +       select ARM_AMBA
> +       select ARM_GIC
> +       select ARM_GIC_V3
> +       select ARM_DMA_USE_IOMMU
> +       select ARM_PSCI
> +       select HAVE_ARM_ARCH_TIMER
> +       select IOMMU_DMA
> +       select COMMON_CLK
> +       help
> +         Support for Econet EN7523 SoCs

Given how closely related this probably is to MT7623/MT7622, should this
perhaps just be part of arch/arm/mach-mediatek? According to
https://wikidevi.wi-cat.ru/MediaTek#xPON, the older (mips based) MT752x
chips are apparently just rebranded to EN752x after the business unit
was spun off, but I guess they are still in the same family.

> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 173da685a52e..1bff0aa29c07 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -152,6 +152,7 @@ textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
>  textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
>  textofs-$(CONFIG_ARCH_MESON) := 0x00208000
>  textofs-$(CONFIG_ARCH_AXXIA) := 0x00308000
> +textofs-$(CONFIG_ARCH_ECONET) := 0x00088000

Why is this needed?

Note also the comment directly above it exlaining
# Text offset. This list is sorted numerically by address in order to
# provide a means to avoid/resolve conflicts in multi-arch kernels.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-30 14:48 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 13:45 [PATCH 0/4] Add support for EcoNet EN7523 SoC Bert Vermeulen
2021-07-30 13:45 ` Bert Vermeulen
2021-07-30 13:45 ` [PATCH 1/5] dt-bindings: Add vendor prefix for EcoNet Bert Vermeulen
2021-07-30 13:45   ` Bert Vermeulen
2021-08-06 21:02   ` Rob Herring
2021-08-06 21:02     ` Rob Herring
2021-07-30 13:45 ` [PATCH 2/5] dt-bindings: arm: econet: Add binding for EN7523 SoC and EVB Bert Vermeulen
2021-07-30 13:45   ` Bert Vermeulen
2021-08-06 21:04   ` Rob Herring
2021-08-06 21:04     ` Rob Herring
2021-07-30 13:45 ` [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Bert Vermeulen
2021-07-30 13:45   ` Bert Vermeulen
2021-07-30 14:31   ` Linus Walleij
2021-07-30 14:31     ` Linus Walleij
2021-07-30 14:31     ` Linus Walleij
2021-07-30 14:53     ` Marc Zyngier
2021-07-30 14:53       ` Marc Zyngier
2021-08-01  9:07       ` Bert Vermeulen
2021-08-01  9:07         ` Bert Vermeulen
2021-08-01  9:07         ` Bert Vermeulen
2021-08-01  9:40         ` Arnd Bergmann
2021-08-01  9:40           ` Arnd Bergmann
2021-08-01  9:40           ` Arnd Bergmann
2021-08-01  9:50         ` Marc Zyngier
2021-08-01  9:50           ` Marc Zyngier
2021-07-30 14:45   ` Daniel Palmer
2021-07-30 14:45     ` Daniel Palmer
2021-07-30 14:45     ` Daniel Palmer
2021-07-30 14:46   ` Mark Rutland
2021-07-30 14:46     ` Mark Rutland
2021-08-04 16:41     ` Bert Vermeulen
2021-08-04 16:41       ` Bert Vermeulen
2021-08-06 20:59       ` Rob Herring
2021-08-06 20:59         ` Rob Herring
2021-07-30 14:59   ` Mark Rutland
2021-07-30 14:59     ` Mark Rutland
2021-08-06 20:52     ` Rob Herring
2021-08-06 20:52       ` Rob Herring
2021-07-30 16:47   ` Andre Przywara
2021-07-30 16:47     ` Andre Przywara
2021-07-30 17:23     ` Marc Zyngier
2021-07-30 17:23       ` Marc Zyngier
2021-07-30 13:45 ` [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC Bert Vermeulen
2021-07-30 13:45   ` Bert Vermeulen
2021-07-30 14:48   ` Arnd Bergmann [this message]
2021-07-30 14:48     ` Arnd Bergmann
2021-07-30 15:15     ` John Crispin
2021-07-30 15:15       ` John Crispin
2021-07-30 16:55       ` Arnd Bergmann
2021-07-30 16:55         ` Arnd Bergmann
2021-08-01 16:44     ` Ard Biesheuvel
2021-08-01 16:44       ` Ard Biesheuvel
2021-09-03 16:20       ` Felix Fietkau
2021-09-03 16:20         ` Felix Fietkau
2021-09-03 17:47         ` Ard Biesheuvel
2021-09-03 17:47           ` Ard Biesheuvel
2021-08-04 16:43     ` Bert Vermeulen
2021-08-04 16:43       ` Bert Vermeulen
2021-08-09 12:46       ` Geert Uytterhoeven
2021-08-09 12:46         ` Geert Uytterhoeven
2021-08-09 12:49         ` Ard Biesheuvel
2021-08-09 12:49           ` Ard Biesheuvel
2021-08-09 13:00         ` Bert Vermeulen
2021-08-09 13:00           ` Bert Vermeulen
2021-07-30 13:45 ` [PATCH 5/5] ARM: multi_v7_defconfig: Add " Bert Vermeulen
2021-07-30 13:45   ` Bert Vermeulen
2021-07-30 14:26 ` [PATCH 0/4] " Linus Walleij
2021-07-30 14:26   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3OuJ3pMSdEA4Rt3aWvvuX2+_Bg5x7-kZ1++fvvJvgGxA@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=ardb@kernel.org \
    --cc=bert@biot.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=john@phrozen.org \
    --cc=keescook@chromium.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nbd@nbd.name \
    --cc=ndesaulniers@google.com \
    --cc=rppt@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=viresh.kumar@linaro.org \
    --cc=yifeifz2@illinois.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.