Re: [PATCH] arm64: dts: synaptics: remove unused DTSI for AS370

From: Arnd Bergmann <arnd@arndb.de>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	DTML <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: synaptics: remove unused DTSI for AS370
Date: Thu, 19 Aug 2021 10:10:26 +0200	[thread overview]
Message-ID: <CAK8P3a3jk-iGC3UjB95A50hFxfJGaFxq8cjGm22aKZU7HVK-dg@mail.gmail.com> (raw)
In-Reply-To: <20210819143735.5171af23@xhacker.debian>

On Thu, Aug 19, 2021 at 8:38 AM Jisheng Zhang
<Jisheng.Zhang@synaptics.com> wrote:
> On Fri, 13 Aug 2021 22:43:26 +0200 Arnd Bergmann wrote:
> > On Fri, Aug 13, 2021 at 9:09 PM Rob Herring <robh@kernel.org> wrote:
> > > On Fri, 06 Aug 2021 10:26:35 +0200, Krzysztof Kozlowski wrote:
> > > > The as370.dtsi for Synaptics AS370 SoC does not have a user (DTS board
> > > > file), is uncompilable and untestable.  It was added back in 2018.  No
> > > > user appeared since that time, so assume it won't be added.
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > > > ---
> > > >  .../devicetree/bindings/arm/syna.txt          |   4 -
> > > >  arch/arm64/boot/dts/synaptics/as370.dtsi      | 173 ------------------
> > > >  2 files changed, 177 deletions(-)
> > > >  delete mode 100644 arch/arm64/boot/dts/synaptics/as370.dtsi
> > > >
> > >
> > > I assume Arnd/Olof will take this.
> > >
> > > Acked-by: Rob Herring <robh@kernel.org>
> >
> > Sure, I can take that, but it would be nice to hear anything from Jisheng Zhang
> > about this.
> >
> > I can see that the only two 64-bit Synaptics SoCs are as370 and bg4ct,
> > but both of them have apparently been replaced with newer versions that
> > never made it into the kernel: as371, as390, bg5ct, according to press
> > releases.
> >
> > Jisheng, can you clarify whether you plan to complete the as370 support
> > or add the later SoCs?
>
> Hi Arnd, Rob, Krzysztof
>
> Sorry for being late. I was on vocation in the past several days.
> As for this as370 removing, I think we'd better keep it. I planned
> to submit the as370-rdk board dts two years ago, but latter I focused
> on Synaptics SoCs related drivers support such as gpio, pcie, sdhci and
> so on. I will send a basic as370 rdk board dts. I'm also considering
> to mainline basic support for a new SoC.

Ok, sounds good. Let's keep it for now then. If you have the dts file at
hand, please send the patch to soc@kernel.org directly so I can still
apply it for 5.15 to enable it for build testing, even if it's still missing
functionality.

        Arnd