From: Jason Andryuk <jandryuk@gmail.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"marmarek@invisiblethingslab.com"
<marmarek@invisiblethingslab.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 2/6] xen: Move xenstore initialization to common location
Date: Wed, 13 Mar 2019 14:11:36 -0400 [thread overview]
Message-ID: <CAKf6xpubx6HATUuYXPsY4mxQf09Bx33+TV9cxstkJgnJhoamUQ@mail.gmail.com> (raw)
In-Reply-To: <1e50388c07d246f68f5ac591f449091c@AMSPEX02CL02.citrite.net>
On Wed, Mar 13, 2019 at 11:01 AM Paul Durrant <Paul.Durrant@citrix.com> wrote:
>
> > -----Original Message-----
> > From: Jason Andryuk [mailto:jandryuk@gmail.com]
> > Sent: 11 March 2019 18:02
> > To: qemu-devel@nongnu.org
> > Cc: xen-devel@lists.xenproject.org; marmarek@invisiblethingslab.com; Jason Andryuk
> > <jandryuk@gmail.com>; Stefano Stabellini <sstabellini@kernel.org>; Anthony Perard
> > <anthony.perard@citrix.com>; Paul Durrant <Paul.Durrant@citrix.com>; Paolo Bonzini
> > <pbonzini@redhat.com>; Richard Henderson <rth@twiddle.net>; Eduardo Habkost <ehabkost@redhat.com>;
> > Michael S. Tsirkin <mst@redhat.com>; Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > Subject: [PATCH 2/6] xen: Move xenstore initialization to common location
> >
> > For the xen stubdom case, we'll want xenstore initialized, but we'll
> > want to skip the rest of xen_be_init. Move the initialization to
> > xen_hvm_init so we can conditionalize calling xen_be_init.
> >
> > xs_domain_open() is deprecated for xs_open(0), so make the replacement
> > as well.
>
> Can you elaborate as to why you need to do this when the code at the top of xen_hvm_init() already opens xenstore for its own purposes, and AFAICT xenstore_update() is only needed if QEMU is implementing a PV backend?
>
>
Hi, Paul. Thanks for reviewing.
I think you are right, that this basically shouldn't be needed if PV
backends are disabled. This patch came out of OpenXT, where it is
needed for some out-of-tree patches. But that doesn't make it
suitable for upstreaming.
However, while reviewing, it looks like the xen accelerator in
hw/xen/xen-common.c:xen_init() registers xen_change_state_handler().
xen_change_state_handler() uses the global xenstore handle and will
exit(1) if NULL. I'm not sure how to get the XenIOState xenstore
handle over to the accelerator's xen_init. Outside of that, I think
you are correct that xenstore_update doesn't need to be run when PV
backends are disabled.
Thanks,
Jason
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-13 18:11 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 18:02 [Qemu-devel] [PATCH 0/6] Xen stubdom support Jason Andryuk
2019-03-11 18:02 ` Jason Andryuk
2019-03-11 18:02 ` [Qemu-devel] [PATCH 1/6] xen: Introduce -xen-stubdom option Jason Andryuk
2019-03-11 18:02 ` Jason Andryuk
2019-03-11 18:06 ` [Qemu-devel] " Paolo Bonzini
2019-03-11 18:06 ` Paolo Bonzini
2019-03-11 19:46 ` [Qemu-devel] " Jason Andryuk
2019-03-11 19:46 ` Jason Andryuk
2019-03-11 18:02 ` [Qemu-devel] [PATCH 2/6] xen: Move xenstore initialization to common location Jason Andryuk
2019-03-11 18:02 ` Jason Andryuk
2019-03-13 15:01 ` Paul Durrant
2019-03-13 18:11 ` Jason Andryuk [this message]
2019-03-14 14:00 ` Paul Durrant
2019-03-11 18:02 ` [Qemu-devel] [PATCH 3/6] xen: Skip backend initialization for stubdom Jason Andryuk
2019-03-11 18:02 ` Jason Andryuk
2019-03-13 15:04 ` Paul Durrant
2019-03-11 18:02 ` [Qemu-devel] [PATCH 4/6] xen: Set HVM_PARAM_DM_DOMAIN for stubdom on older Xen Jason Andryuk
2019-03-11 18:02 ` Jason Andryuk
2019-03-11 18:02 ` [Qemu-devel] [PATCH 5/6] xen-pt: Hide MSI-X from xen stubdoms Jason Andryuk
2019-03-11 18:02 ` Jason Andryuk
2019-03-12 12:04 ` Roger Pau Monné
2019-03-12 12:38 ` Marek Marczykowski-Górecki
2019-03-12 13:58 ` Jason Andryuk
2019-03-12 14:13 ` Roger Pau Monné
2019-03-12 15:15 ` Jason Andryuk
2019-03-13 2:15 ` Jason Andryuk
2019-03-12 14:29 ` Marek Marczykowski-Górecki
2019-03-11 18:02 ` [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE Jason Andryuk
2019-03-11 18:02 ` Jason Andryuk
2019-03-13 15:09 ` Paul Durrant
2019-03-14 18:15 ` Jason Andryuk
2019-03-14 19:22 ` Simon Gaiser
2019-03-14 19:37 ` Andrew Cooper
2019-03-15 9:12 ` Paul Durrant
2019-03-14 20:45 ` Simon Gaiser
2019-03-15 9:17 ` Paul Durrant
2019-03-15 16:28 ` Andrew Cooper
2019-03-20 17:28 ` Jason Andryuk
2019-03-22 3:09 ` Roger Pau Monné
2019-03-22 19:43 ` Jason Andryuk
2020-01-13 19:01 ` [Xen-devel] " Jason Andryuk
2020-01-13 19:01 ` Jason Andryuk
2020-01-14 10:04 ` Roger Pau Monné
2020-01-14 10:04 ` Roger Pau Monné
2020-01-14 14:41 ` Jason Andryuk
2020-01-14 14:41 ` Jason Andryuk
2020-01-14 18:04 ` Roger Pau Monné
2020-01-14 18:04 ` Roger Pau Monné
2020-01-15 8:33 ` Durrant, Paul
2020-01-15 8:33 ` Durrant, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKf6xpubx6HATUuYXPsY4mxQf09Bx33+TV9cxstkJgnJhoamUQ@mail.gmail.com \
--to=jandryuk@gmail.com \
--cc=Paul.Durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=marmarek@invisiblethingslab.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.