From: Jason Andryuk <jandryuk@gmail.com> To: qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, marmarek@invisiblethingslab.com, Jason Andryuk <jandryuk@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul.durrant@citrix.com> Subject: [Qemu-devel] [PATCH 4/6] xen: Set HVM_PARAM_DM_DOMAIN for stubdom on older Xen Date: Mon, 11 Mar 2019 14:02:14 -0400 [thread overview] Message-ID: <20190311180216.18811-5-jandryuk@gmail.com> (raw) In-Reply-To: <20190311180216.18811-1-jandryuk@gmail.com> When running in a stubdom, we have to inform the hypervisor that the stubdom and not dom0 is handling the device model. Explicitly created ioreq servers are fine, but a call to HVM_PARAM_DM_DOMAIN is needed for the default ioreq server. Xen 4.12 removes the default ioreq server. With that, Xen started returning an error when setting HVM_PARAM_DM_DOMAIN. Put the HVM_PARAM_DM_DOMAIN call in the version compatibility header. When we fallback to the default ioreq server, issue the call and don't bother to check the return value. Original patch by Anthony PERARD <anthony.perard@citrix.com> Signed-off-by: Jason Andryuk <jandryuk@gmail.com> --- include/hw/xen/xen_common.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 9a8155e172..f59f841a43 100644 --- a/include/hw/xen/xen_common.h +++ b/include/hw/xen/xen_common.h @@ -616,6 +616,11 @@ static inline void xen_create_ioreq_server(domid_t dom, *ioservid = 0; use_default_ioreq_server = true; + + if (xen_stubdom_enabled()) { + xc_hvm_param_set(xen_xc, xen_domid, HVM_PARAM_DM_DOMAIN, DOMID_SELF); + } + trace_xen_default_ioreq_server(); } -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Andryuk <jandryuk@gmail.com> To: qemu-devel@nongnu.org Cc: Stefano Stabellini <sstabellini@kernel.org>, Jason Andryuk <jandryuk@gmail.com>, marmarek@invisiblethingslab.com, Paul Durrant <paul.durrant@citrix.com>, Anthony Perard <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org Subject: [PATCH 4/6] xen: Set HVM_PARAM_DM_DOMAIN for stubdom on older Xen Date: Mon, 11 Mar 2019 14:02:14 -0400 [thread overview] Message-ID: <20190311180216.18811-5-jandryuk@gmail.com> (raw) In-Reply-To: <20190311180216.18811-1-jandryuk@gmail.com> When running in a stubdom, we have to inform the hypervisor that the stubdom and not dom0 is handling the device model. Explicitly created ioreq servers are fine, but a call to HVM_PARAM_DM_DOMAIN is needed for the default ioreq server. Xen 4.12 removes the default ioreq server. With that, Xen started returning an error when setting HVM_PARAM_DM_DOMAIN. Put the HVM_PARAM_DM_DOMAIN call in the version compatibility header. When we fallback to the default ioreq server, issue the call and don't bother to check the return value. Original patch by Anthony PERARD <anthony.perard@citrix.com> Signed-off-by: Jason Andryuk <jandryuk@gmail.com> --- include/hw/xen/xen_common.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 9a8155e172..f59f841a43 100644 --- a/include/hw/xen/xen_common.h +++ b/include/hw/xen/xen_common.h @@ -616,6 +616,11 @@ static inline void xen_create_ioreq_server(domid_t dom, *ioservid = 0; use_default_ioreq_server = true; + + if (xen_stubdom_enabled()) { + xc_hvm_param_set(xen_xc, xen_domid, HVM_PARAM_DM_DOMAIN, DOMID_SELF); + } + trace_xen_default_ioreq_server(); } -- 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-11 18:03 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-11 18:02 [Qemu-devel] [PATCH 0/6] Xen stubdom support Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-11 18:02 ` [Qemu-devel] [PATCH 1/6] xen: Introduce -xen-stubdom option Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-11 18:06 ` [Qemu-devel] " Paolo Bonzini 2019-03-11 18:06 ` Paolo Bonzini 2019-03-11 19:46 ` [Qemu-devel] " Jason Andryuk 2019-03-11 19:46 ` Jason Andryuk 2019-03-11 18:02 ` [Qemu-devel] [PATCH 2/6] xen: Move xenstore initialization to common location Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-13 15:01 ` Paul Durrant 2019-03-13 18:11 ` Jason Andryuk 2019-03-14 14:00 ` Paul Durrant 2019-03-11 18:02 ` [Qemu-devel] [PATCH 3/6] xen: Skip backend initialization for stubdom Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-13 15:04 ` Paul Durrant 2019-03-11 18:02 ` Jason Andryuk [this message] 2019-03-11 18:02 ` [PATCH 4/6] xen: Set HVM_PARAM_DM_DOMAIN for stubdom on older Xen Jason Andryuk 2019-03-11 18:02 ` [Qemu-devel] [PATCH 5/6] xen-pt: Hide MSI-X from xen stubdoms Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-12 12:04 ` Roger Pau Monné 2019-03-12 12:38 ` Marek Marczykowski-Górecki 2019-03-12 13:58 ` Jason Andryuk 2019-03-12 14:13 ` Roger Pau Monné 2019-03-12 15:15 ` Jason Andryuk 2019-03-13 2:15 ` Jason Andryuk 2019-03-12 14:29 ` Marek Marczykowski-Górecki 2019-03-11 18:02 ` [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-13 15:09 ` Paul Durrant 2019-03-14 18:15 ` Jason Andryuk 2019-03-14 19:22 ` Simon Gaiser 2019-03-14 19:37 ` Andrew Cooper 2019-03-15 9:12 ` Paul Durrant 2019-03-14 20:45 ` Simon Gaiser 2019-03-15 9:17 ` Paul Durrant 2019-03-15 16:28 ` Andrew Cooper 2019-03-20 17:28 ` Jason Andryuk 2019-03-22 3:09 ` Roger Pau Monné 2019-03-22 19:43 ` Jason Andryuk 2020-01-13 19:01 ` [Xen-devel] " Jason Andryuk 2020-01-13 19:01 ` Jason Andryuk 2020-01-14 10:04 ` Roger Pau Monné 2020-01-14 10:04 ` Roger Pau Monné 2020-01-14 14:41 ` Jason Andryuk 2020-01-14 14:41 ` Jason Andryuk 2020-01-14 18:04 ` Roger Pau Monné 2020-01-14 18:04 ` Roger Pau Monné 2020-01-15 8:33 ` Durrant, Paul 2020-01-15 8:33 ` Durrant, Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190311180216.18811-5-jandryuk@gmail.com \ --to=jandryuk@gmail.com \ --cc=anthony.perard@citrix.com \ --cc=marmarek@invisiblethingslab.com \ --cc=paul.durrant@citrix.com \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.