* [PATCH] hw/loader: Remove unused rom_add_file_as() definition
@ 2021-09-17 19:01 Philippe Mathieu-Daudé
2021-09-21 22:08 ` Alistair Francis
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-17 19:01 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Alistair Francis, Philippe Mathieu-Daudé
rom_add_file_as() is not used anywhere, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/loader.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/hw/loader.h b/include/hw/loader.h
index cbfc1848737..c52a1df8b68 100644
--- a/include/hw/loader.h
+++ b/include/hw/loader.h
@@ -329,8 +329,6 @@ void hmp_info_roms(Monitor *mon, const QDict *qdict);
rom_add_blob(_f, _b, _l, _l, _a, NULL, NULL, NULL, NULL, true)
#define rom_add_file_mr(_f, _mr, _i) \
rom_add_file(_f, NULL, 0, _i, false, _mr, NULL)
-#define rom_add_file_as(_f, _as, _i) \
- rom_add_file(_f, NULL, 0, _i, false, NULL, _as)
#define rom_add_file_fixed_as(_f, _a, _i, _as) \
rom_add_file(_f, NULL, _a, _i, false, NULL, _as)
#define rom_add_blob_fixed_as(_f, _b, _l, _a, _as) \
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/loader: Remove unused rom_add_file_as() definition
2021-09-17 19:01 [PATCH] hw/loader: Remove unused rom_add_file_as() definition Philippe Mathieu-Daudé
@ 2021-09-21 22:08 ` Alistair Francis
0 siblings, 0 replies; 2+ messages in thread
From: Alistair Francis @ 2021-09-21 22:08 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Trivial, Alistair Francis, qemu-devel@nongnu.org Developers
On Sat, Sep 18, 2021 at 5:02 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> rom_add_file_as() is not used anywhere, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Looks fine, although I'm not convinced removing this gets us anything.
It might be used in the future and doesn't add too much cruft.
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> include/hw/loader.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/loader.h b/include/hw/loader.h
> index cbfc1848737..c52a1df8b68 100644
> --- a/include/hw/loader.h
> +++ b/include/hw/loader.h
> @@ -329,8 +329,6 @@ void hmp_info_roms(Monitor *mon, const QDict *qdict);
> rom_add_blob(_f, _b, _l, _l, _a, NULL, NULL, NULL, NULL, true)
> #define rom_add_file_mr(_f, _mr, _i) \
> rom_add_file(_f, NULL, 0, _i, false, _mr, NULL)
> -#define rom_add_file_as(_f, _as, _i) \
> - rom_add_file(_f, NULL, 0, _i, false, NULL, _as)
> #define rom_add_file_fixed_as(_f, _a, _i, _as) \
> rom_add_file(_f, NULL, _a, _i, false, NULL, _as)
> #define rom_add_blob_fixed_as(_f, _b, _l, _a, _as) \
> --
> 2.31.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-21 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 19:01 [PATCH] hw/loader: Remove unused rom_add_file_as() definition Philippe Mathieu-Daudé
2021-09-21 22:08 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.