* [PATCH] lib/raid6: Fix arm64 test build
@ 2018-11-06 0:14 Jeremy Linton
2018-11-06 8:16 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Linton @ 2018-11-06 0:14 UTC (permalink / raw)
To: linux-kernel; +Cc: matthew.brown.dev, mpe, ard.biesheuvel, arnd, Jeremy Linton
The lib/raid6/test fails to build the neon objects
on arm64 because the correct machine type is 'aarch64'.
Once this is correctly enabled, the neon recovery objects
need to be added to the build.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
lib/raid6/test/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
index 5d73f5cb4d8a..79777645cac9 100644
--- a/lib/raid6/test/Makefile
+++ b/lib/raid6/test/Makefile
@@ -27,7 +27,7 @@ ifeq ($(ARCH),arm)
CFLAGS += -I../../../arch/arm/include -mfpu=neon
HAS_NEON = yes
endif
-ifeq ($(ARCH),arm64)
+ifeq ($(ARCH),aarch64)
CFLAGS += -I../../../arch/arm64/include
HAS_NEON = yes
endif
@@ -41,7 +41,7 @@ ifeq ($(IS_X86),yes)
gcc -c -x assembler - >&/dev/null && \
rm ./-.o && echo -DCONFIG_AS_AVX512=1)
else ifeq ($(HAS_NEON),yes)
- OBJS += neon.o neon1.o neon2.o neon4.o neon8.o
+ OBJS += neon.o neon1.o neon2.o neon4.o neon8.o recov_neon.o recov_neon_inner.o
CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1
else
HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/raid6: Fix arm64 test build
2018-11-06 0:14 [PATCH] lib/raid6: Fix arm64 test build Jeremy Linton
@ 2018-11-06 8:16 ` Ard Biesheuvel
2018-11-06 14:01 ` Catalin Marinas
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 8:16 UTC (permalink / raw)
To: Jeremy Linton, Catalin Marinas, Will Deacon
Cc: Linux Kernel Mailing List, matthew.brown.dev, Michael Ellerman,
Arnd Bergmann
(+ Catalin, Will)
On 6 November 2018 at 01:14, Jeremy Linton <jeremy.linton@arm.com> wrote:
> The lib/raid6/test fails to build the neon objects
> on arm64 because the correct machine type is 'aarch64'.
>
> Once this is correctly enabled, the neon recovery objects
> need to be added to the build.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> lib/raid6/test/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
> index 5d73f5cb4d8a..79777645cac9 100644
> --- a/lib/raid6/test/Makefile
> +++ b/lib/raid6/test/Makefile
> @@ -27,7 +27,7 @@ ifeq ($(ARCH),arm)
> CFLAGS += -I../../../arch/arm/include -mfpu=neon
> HAS_NEON = yes
> endif
> -ifeq ($(ARCH),arm64)
> +ifeq ($(ARCH),aarch64)
> CFLAGS += -I../../../arch/arm64/include
> HAS_NEON = yes
> endif
> @@ -41,7 +41,7 @@ ifeq ($(IS_X86),yes)
> gcc -c -x assembler - >&/dev/null && \
> rm ./-.o && echo -DCONFIG_AS_AVX512=1)
> else ifeq ($(HAS_NEON),yes)
> - OBJS += neon.o neon1.o neon2.o neon4.o neon8.o
> + OBJS += neon.o neon1.o neon2.o neon4.o neon8.o recov_neon.o recov_neon_inner.o
> CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1
> else
> HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
> --
> 2.17.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/raid6: Fix arm64 test build
2018-11-06 8:16 ` Ard Biesheuvel
@ 2018-11-06 14:01 ` Catalin Marinas
0 siblings, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2018-11-06 14:01 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Jeremy Linton, Will Deacon, Linux Kernel Mailing List,
matthew.brown.dev, Michael Ellerman, Arnd Bergmann
On Tue, Nov 06, 2018 at 09:16:04AM +0100, Ard Biesheuvel wrote:
> (+ Catalin, Will)
>
> On 6 November 2018 at 01:14, Jeremy Linton <jeremy.linton@arm.com> wrote:
> > The lib/raid6/test fails to build the neon objects
> > on arm64 because the correct machine type is 'aarch64'.
> >
> > Once this is correctly enabled, the neon recovery objects
> > need to be added to the build.
> >
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
I can pick this up for 4.20-rc2 (I can't find a maintainers entry for
this Makefile).
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-06 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 0:14 [PATCH] lib/raid6: Fix arm64 test build Jeremy Linton
2018-11-06 8:16 ` Ard Biesheuvel
2018-11-06 14:01 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.