From: Rob Herring <robh@kernel.org> To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Alan Stern <stern@rowland.harvard.edu>, Kishon Vijay Abraham I <kishon@ti.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux USB List <linux-usb@vger.kernel.org>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@free-electrons.com>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Subject: Re: [PATCH 0/5] Marvell PXA1928 USB support Date: Fri, 15 May 2015 07:48:24 -0500 [thread overview] Message-ID: <CAL_Jsq+1JXJGVAA42iw7haSMkWEpV0KOo0h3AVhO5-DQ-GfRcg@mail.gmail.com> (raw) In-Reply-To: <5555C2A5.8010509@gmail.com> On Fri, May 15, 2015 at 4:55 AM, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote: > On 14.05.2015 00:48, Rob Herring wrote: >> >> This series adds USB PHYs and EHCI host drivers for the Marvell PXA1928 >> SOC. >> >> The OTG block is based on ChipIdea and works with "chipidea,usb2" >> compatible driver as is just by adding the PHY driver. Yay! >> >> Rob >> >> Rob Herring (5): >> dt-bindings: Add Marvell PXA1928 USB and HSIC PHY bindings >> dt-bindings: Add Marvell PXA1928 USB EHCI controller binding >> phy: Add Marvell USB 2.0 OTG 28nm PHY >> phy: add Marvell HSIC 28nm PHY >> usb: add pxa1928 ehci support >> >> .../devicetree/bindings/phy/pxa1928-usb-phy.txt | 18 ++ >> .../devicetree/bindings/usb/ehci-pxa1928.txt | 19 ++ >> drivers/phy/Kconfig | 20 ++ >> drivers/phy/Makefile | 2 + >> drivers/phy/phy-mv-hsic.c | 208 +++++++++++++ >> drivers/phy/phy-mv-usb2.c | 329 >> +++++++++++++++++++++ > > > [Adding some MVEBU guys] > > Rob, > > I had a look at the USB PHYs of some of the other Marvell SoCs a while > ago for the barebox bootloader [1]. Marvell seems to distinguish the > USB PHY type by technology node, e.g. 28nm like the one above. For the > most used Marvell SoCs, i.e. Kirkwood, Dove, and Armada 370/XP, they all > use a different technology node and we could either use the SoC name > or the technology node as compatible. It also seems to be by business unit. The registers in the 40nm version I have look nothing like what are in Armada. It could be the same IP, but PHY IP tends to just be signals and they leave the register interface up the to licensee's imagination. Any idea if there are 28nm Armada parts which have the same phy? It's a good idea to always include the SOC name in the compatible. Every new chip is an opportunity for changes or bugs. > Anyway, if you are introducing new PHY drivers with _that_ generic > names, it will either clash with every other Marvell USB PHYs - > or we'll have to add the PHY code into the drivers above. How about phy-pxa-28nm-{usb2,hsic}? Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>, Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux USB List <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>, Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Subject: Re: [PATCH 0/5] Marvell PXA1928 USB support Date: Fri, 15 May 2015 07:48:24 -0500 [thread overview] Message-ID: <CAL_Jsq+1JXJGVAA42iw7haSMkWEpV0KOo0h3AVhO5-DQ-GfRcg@mail.gmail.com> (raw) In-Reply-To: <5555C2A5.8010509-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On Fri, May 15, 2015 at 4:55 AM, Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On 14.05.2015 00:48, Rob Herring wrote: >> >> This series adds USB PHYs and EHCI host drivers for the Marvell PXA1928 >> SOC. >> >> The OTG block is based on ChipIdea and works with "chipidea,usb2" >> compatible driver as is just by adding the PHY driver. Yay! >> >> Rob >> >> Rob Herring (5): >> dt-bindings: Add Marvell PXA1928 USB and HSIC PHY bindings >> dt-bindings: Add Marvell PXA1928 USB EHCI controller binding >> phy: Add Marvell USB 2.0 OTG 28nm PHY >> phy: add Marvell HSIC 28nm PHY >> usb: add pxa1928 ehci support >> >> .../devicetree/bindings/phy/pxa1928-usb-phy.txt | 18 ++ >> .../devicetree/bindings/usb/ehci-pxa1928.txt | 19 ++ >> drivers/phy/Kconfig | 20 ++ >> drivers/phy/Makefile | 2 + >> drivers/phy/phy-mv-hsic.c | 208 +++++++++++++ >> drivers/phy/phy-mv-usb2.c | 329 >> +++++++++++++++++++++ > > > [Adding some MVEBU guys] > > Rob, > > I had a look at the USB PHYs of some of the other Marvell SoCs a while > ago for the barebox bootloader [1]. Marvell seems to distinguish the > USB PHY type by technology node, e.g. 28nm like the one above. For the > most used Marvell SoCs, i.e. Kirkwood, Dove, and Armada 370/XP, they all > use a different technology node and we could either use the SoC name > or the technology node as compatible. It also seems to be by business unit. The registers in the 40nm version I have look nothing like what are in Armada. It could be the same IP, but PHY IP tends to just be signals and they leave the register interface up the to licensee's imagination. Any idea if there are 28nm Armada parts which have the same phy? It's a good idea to always include the SOC name in the compatible. Every new chip is an opportunity for changes or bugs. > Anyway, if you are introducing new PHY drivers with _that_ generic > names, it will either clash with every other Marvell USB PHYs - > or we'll have to add the PHY code into the drivers above. How about phy-pxa-28nm-{usb2,hsic}? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-15 12:48 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-13 22:48 [PATCH 0/5] Marvell PXA1928 USB support Rob Herring 2015-05-13 22:48 ` Rob Herring 2015-05-13 22:48 ` [PATCH 1/5] dt-bindings: Add Marvell PXA1928 USB and HSIC PHY bindings Rob Herring 2015-05-13 22:48 ` Rob Herring 2015-05-13 22:48 ` [PATCH 2/5] dt-bindings: Add Marvell PXA1928 USB EHCI controller binding Rob Herring 2015-05-13 22:48 ` [PATCH 3/5] phy: Add Marvell USB 2.0 OTG 28nm PHY Rob Herring 2015-05-13 22:48 ` Rob Herring 2015-05-21 12:33 ` Kishon Vijay Abraham I 2015-05-21 12:33 ` Kishon Vijay Abraham I 2015-05-13 22:48 ` [PATCH 4/5] phy: add Marvell HSIC " Rob Herring 2015-05-21 12:45 ` Kishon Vijay Abraham I 2015-05-21 12:45 ` Kishon Vijay Abraham I 2015-05-21 12:51 ` Kishon Vijay Abraham I 2015-05-21 12:51 ` Kishon Vijay Abraham I 2015-05-22 19:54 ` Rob Herring 2015-05-22 19:54 ` Rob Herring 2015-05-26 6:06 ` Kishon Vijay Abraham I 2015-05-13 22:49 ` [PATCH 5/5] usb: add pxa1928 ehci support Rob Herring 2015-05-14 8:24 ` Paul Bolle 2015-05-14 10:42 ` Arnd Bergmann 2015-05-14 13:25 ` Rob Herring 2015-05-14 13:25 ` Rob Herring 2015-05-14 10:43 ` Arnd Bergmann 2015-05-14 14:56 ` Alan Stern 2015-05-14 14:56 ` Alan Stern 2015-05-14 16:36 ` Rob Herring 2015-05-14 16:36 ` Rob Herring 2015-05-14 17:06 ` Alan Stern 2015-05-14 17:06 ` Alan Stern 2015-05-14 15:55 ` Alan Stern 2015-05-14 15:55 ` Alan Stern 2015-05-15 9:32 ` Arnd Bergmann 2015-05-15 9:55 ` [PATCH 0/5] Marvell PXA1928 USB support Sebastian Hesselbarth 2015-05-15 9:55 ` Sebastian Hesselbarth 2015-05-15 12:48 ` Rob Herring [this message] 2015-05-15 12:48 ` Rob Herring 2015-05-15 14:11 ` Arnd Bergmann 2015-05-15 16:04 ` Rob Herring 2015-05-15 16:04 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAL_Jsq+1JXJGVAA42iw7haSMkWEpV0KOo0h3AVhO5-DQ-GfRcg@mail.gmail.com \ --to=robh@kernel.org \ --cc=andrew@lunn.ch \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=gregory.clement@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=stern@rowland.harvard.edu \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.