From: Rob Herring <robh@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Stephen Boyd <sboyd@kernel.org>, Will Deacon <will@kernel.org>,
Kevin Brodsky <Kevin.Brodsky@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 04/17] power/reset: vexpress: Support building as a module
Date: Mon, 20 Apr 2020 12:23:13 -0500 [thread overview]
Message-ID: <CAL_Jsq+Hk_WuK=c+eHi1Kz3EPzm=zOw2ctETXEySPH1WgAGjug@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a2BZLti5pLrru8s-45Yz54SA0JZbyjvYEstSDJZfnzEmA@mail.gmail.com>
On Mon, Apr 20, 2020 at 10:24 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote:
> >
> > Enable building the VExpress power-off/reset driver as a module.
>
> Your change allows loading and unloading the driver, but actually
> unloading is a bug with the current implementation, as there is no
> 'release' handler to undo the _vexpress_register_restart_handler()
> function.
And also to save and restore pm_power_off...
> It should not be hard to add a release handler, or you could just
> mark the function as non-unloadable by only having a module_init()
> but no module_exit() function.
>
> I suppose if you do the latter, there should also be a suppress_bind_attrs
> flag in the device_driver. This is a preexisting bug.
I may just drop this patch. I wrote it and then realized I don't need
it as PSCI can be used instead.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Will Deacon <will@kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Sebastian Reichel <sre@kernel.org>,
Kevin Brodsky <Kevin.Brodsky@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/17] power/reset: vexpress: Support building as a module
Date: Mon, 20 Apr 2020 12:23:13 -0500 [thread overview]
Message-ID: <CAL_Jsq+Hk_WuK=c+eHi1Kz3EPzm=zOw2ctETXEySPH1WgAGjug@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a2BZLti5pLrru8s-45Yz54SA0JZbyjvYEstSDJZfnzEmA@mail.gmail.com>
On Mon, Apr 20, 2020 at 10:24 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote:
> >
> > Enable building the VExpress power-off/reset driver as a module.
>
> Your change allows loading and unloading the driver, but actually
> unloading is a bug with the current implementation, as there is no
> 'release' handler to undo the _vexpress_register_restart_handler()
> function.
And also to save and restore pm_power_off...
> It should not be hard to add a release handler, or you could just
> mark the function as non-unloadable by only having a module_init()
> but no module_exit() function.
>
> I suppose if you do the latter, there should also be a suppress_bind_attrs
> flag in the device_driver. This is a preexisting bug.
I may just drop this patch. I wrote it and then realized I don't need
it as PSCI can be used instead.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-20 17:23 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 17:07 [PATCH 00/17] Modularizing Versatile Express Rob Herring
2020-04-19 17:07 ` Rob Herring
2020-04-19 17:07 ` [PATCH 01/17] ARM: vexpress: Move vexpress_flags_set() into arch code Rob Herring
2020-04-19 17:07 ` Rob Herring
2020-04-20 15:17 ` Arnd Bergmann
2020-04-20 15:17 ` Arnd Bergmann
2020-04-22 10:15 ` Liviu Dudau
2020-04-22 10:15 ` Liviu Dudau
2020-04-22 19:04 ` Sudeep Holla
2020-04-22 19:04 ` Sudeep Holla
2020-04-19 17:07 ` [PATCH 02/17] arm64: vexpress: Don't select CONFIG_POWER_RESET_VEXPRESS Rob Herring
2020-04-19 17:07 ` Rob Herring
2020-04-20 15:18 ` Arnd Bergmann
2020-04-20 15:18 ` Arnd Bergmann
2020-04-22 10:16 ` Liviu Dudau
2020-04-22 10:16 ` Liviu Dudau
2020-04-22 19:08 ` Sudeep Holla
2020-04-22 19:08 ` Sudeep Holla
2020-04-19 17:07 ` [PATCH 03/17] arm64: vexpress: Don't select CONFIG_VEXPRESS_CONFIG Rob Herring
2020-04-19 17:07 ` Rob Herring
2020-04-20 15:18 ` Arnd Bergmann
2020-04-20 15:18 ` Arnd Bergmann
2020-04-22 19:09 ` Sudeep Holla
2020-04-22 19:09 ` Sudeep Holla
2020-04-19 17:07 ` [PATCH 04/17] power/reset: vexpress: Support building as a module Rob Herring
2020-04-19 17:07 ` Rob Herring
2020-04-20 15:23 ` Arnd Bergmann
2020-04-20 15:23 ` Arnd Bergmann
2020-04-20 17:23 ` Rob Herring [this message]
2020-04-20 17:23 ` Rob Herring
2020-04-28 19:31 ` Sebastian Reichel
2020-04-28 19:31 ` Sebastian Reichel
2020-04-22 19:11 ` Sudeep Holla
2020-04-22 19:11 ` Sudeep Holla
2020-04-19 17:07 ` [PATCH 05/17] clk: versatile: Kill CONFIG_COMMON_CLK_VERSATILE Rob Herring
2020-04-19 17:07 ` Rob Herring
2020-04-20 6:44 ` Linus Walleij
2020-04-20 6:44 ` Linus Walleij
2020-04-22 9:47 ` Stephen Boyd
2020-04-22 9:47 ` Stephen Boyd
2020-04-22 22:34 ` Rob Herring
2020-04-22 22:34 ` Rob Herring
2020-04-22 19:17 ` Sudeep Holla
2020-04-22 19:17 ` Sudeep Holla
2020-04-19 17:07 ` [PATCH 06/17] clk: versatile: Only enable SP810 on 32-bit by default Rob Herring
2020-04-19 17:07 ` Rob Herring
2020-04-20 15:26 ` Arnd Bergmann
2020-04-20 15:26 ` Arnd Bergmann
2020-04-20 17:48 ` Rob Herring
2020-04-20 17:48 ` Rob Herring
2020-04-20 20:07 ` Arnd Bergmann
2020-04-20 20:07 ` Arnd Bergmann
2020-04-22 9:48 ` Stephen Boyd
2020-04-22 9:48 ` Stephen Boyd
2020-04-22 10:20 ` Liviu Dudau
2020-04-22 10:20 ` Liviu Dudau
2020-04-22 20:52 ` Sudeep Holla
2020-04-22 20:52 ` Sudeep Holla
2020-04-23 15:38 ` Rob Herring
2020-04-23 15:38 ` Rob Herring
2020-04-19 17:08 ` [PATCH 07/17] clk: vexpress-osc: Use the devres clock API variants Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-20 15:26 ` Arnd Bergmann
2020-04-20 15:26 ` Arnd Bergmann
2020-04-22 9:51 ` Stephen Boyd
2020-04-22 9:51 ` Stephen Boyd
2020-04-22 10:21 ` Liviu Dudau
2020-04-22 10:21 ` Liviu Dudau
2020-04-22 20:56 ` Sudeep Holla
2020-04-22 20:56 ` Sudeep Holla
2020-04-19 17:08 ` [PATCH 08/17] clk: vexpress-osc: Support building as a module Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-20 15:27 ` Arnd Bergmann
2020-04-20 15:27 ` Arnd Bergmann
2020-04-20 17:18 ` Rob Herring
2020-04-20 17:18 ` Rob Herring
2020-04-22 11:01 ` Liviu Dudau
2020-04-22 11:01 ` Liviu Dudau
2020-04-22 21:08 ` Sudeep Holla
2020-04-22 21:08 ` Sudeep Holla
2020-04-23 13:45 ` Sudeep Holla
2020-04-23 13:45 ` Sudeep Holla
2020-04-23 15:53 ` Rob Herring
2020-04-23 15:53 ` Rob Herring
2020-04-23 16:58 ` Sudeep Holla
2020-04-23 16:58 ` Sudeep Holla
2020-04-19 17:08 ` [PATCH 09/17] mfd: vexpress-sysreg: Drop selecting CONFIG_CLKSRC_MMIO Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-20 15:29 ` Arnd Bergmann
2020-04-20 15:29 ` Arnd Bergmann
2020-04-22 11:02 ` Liviu Dudau
2020-04-22 11:02 ` Liviu Dudau
2020-04-19 17:08 ` [PATCH 10/17] mfd: vexpress-sysreg: Drop unused syscon child devices Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-20 15:30 ` Arnd Bergmann
2020-04-20 15:30 ` Arnd Bergmann
2020-04-22 11:18 ` Liviu Dudau
2020-04-22 11:18 ` Liviu Dudau
2020-04-19 17:08 ` [PATCH 11/17] mfd: vexpress-sysreg: Use devres API variants Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-20 15:31 ` Arnd Bergmann
2020-04-20 15:31 ` Arnd Bergmann
2020-04-22 11:18 ` Liviu Dudau
2020-04-22 11:18 ` Liviu Dudau
2020-04-19 17:08 ` [PATCH 12/17] mfd: vexpress-sysreg: Support building as a module Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-20 15:32 ` Arnd Bergmann
2020-04-20 15:32 ` Arnd Bergmann
2020-04-20 17:05 ` Rob Herring
2020-04-20 17:05 ` Rob Herring
2020-04-19 17:08 ` [PATCH 13/17] bus: vexpress-config: Merge vexpress-syscfg into vexpress-config Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-20 11:45 ` Greg Kroah-Hartman
2020-04-20 11:45 ` Greg Kroah-Hartman
2020-04-22 11:22 ` Liviu Dudau
2020-04-22 11:22 ` Liviu Dudau
2020-04-19 17:08 ` [PATCH 14/17] bus: vexpress-config: simplify config bus probing Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-22 11:58 ` Liviu Dudau
2020-04-22 11:58 ` Liviu Dudau
2020-04-19 17:08 ` [PATCH 15/17] vexpress: Move site master init to vexpress-config bus Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-22 9:51 ` Stephen Boyd
2020-04-22 9:51 ` Stephen Boyd
2020-04-22 12:03 ` Liviu Dudau
2020-04-22 12:03 ` Liviu Dudau
2020-04-23 0:54 ` Rob Herring
2020-04-23 0:54 ` Rob Herring
2020-04-19 17:08 ` [PATCH 16/17] bus: vexpress-config: Support building as module Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-22 12:04 ` Liviu Dudau
2020-04-22 12:04 ` Liviu Dudau
2020-04-19 17:08 ` [PATCH 17/17] ARM: vexpress: Don't select VEXPRESS_CONFIG Rob Herring
2020-04-19 17:08 ` Rob Herring
2020-04-22 12:05 ` Liviu Dudau
2020-04-22 12:05 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+Hk_WuK=c+eHi1Kz3EPzm=zOw2ctETXEySPH1WgAGjug@mail.gmail.com' \
--to=robh@kernel.org \
--cc=Kevin.Brodsky@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.