All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.william.auld@gmail.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Matthew Auld <matthew.auld@intel.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/9] drm/i915: Break out dma_resv ww locking utilities to separate files
Date: Tue, 8 Jun 2021 18:10:48 +0100	[thread overview]
Message-ID: <CAM0jSHOc6A8oJ384=owQiqPXfeX-NgpRsKtujpn9fQ=JfUYj2A@mail.gmail.com> (raw)
In-Reply-To: <20210608092846.64198-3-thomas.hellstrom@linux.intel.com>

On Tue, 8 Jun 2021 at 10:29, Thomas Hellström
<thomas.hellstrom@linux.intel.com> wrote:
>
> As we're about to add more ww-related functionality,
> break out the dma_resv ww locking utilities to their own files
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/Makefile               |  1 +
>  drivers/gpu/drm/i915/gem/i915_gem_object.h  |  1 +
>  drivers/gpu/drm/i915/gt/intel_renderstate.h |  1 +
>  drivers/gpu/drm/i915/i915_gem.c             | 56 ------------------
>  drivers/gpu/drm/i915/i915_gem.h             | 12 ----
>  drivers/gpu/drm/i915/i915_gem_ww.c          | 63 +++++++++++++++++++++
>  drivers/gpu/drm/i915/i915_gem_ww.h          | 21 +++++++
>  7 files changed, 87 insertions(+), 68 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/i915_gem_ww.c
>  create mode 100644 drivers/gpu/drm/i915/i915_gem_ww.h
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 4f22cac1c49b..ea8ee4b3e018 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -45,6 +45,7 @@ i915-y += i915_drv.o \
>           i915_switcheroo.o \
>           i915_sysfs.o \
>           i915_utils.o \
> +         i915_gem_ww.o \

Nit: Should be kept sorted.

>           intel_device_info.o \
>           intel_dram.o \
>           intel_memory_region.o \
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> index 1fafcc89ecee..789529b424c1 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> @@ -15,6 +15,7 @@
>  #include "i915_gem_object_types.h"
>  #include "i915_gem_gtt.h"
>  #include "i915_vma_types.h"
> +#include "i915_gem_ww.h"

Same here.

Reviewed-by: Matthew Auld <matthew.auld@intel.com>

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.william.auld@gmail.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Matthew Auld <matthew.auld@intel.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/9] drm/i915: Break out dma_resv ww locking utilities to separate files
Date: Tue, 8 Jun 2021 18:10:48 +0100	[thread overview]
Message-ID: <CAM0jSHOc6A8oJ384=owQiqPXfeX-NgpRsKtujpn9fQ=JfUYj2A@mail.gmail.com> (raw)
In-Reply-To: <20210608092846.64198-3-thomas.hellstrom@linux.intel.com>

On Tue, 8 Jun 2021 at 10:29, Thomas Hellström
<thomas.hellstrom@linux.intel.com> wrote:
>
> As we're about to add more ww-related functionality,
> break out the dma_resv ww locking utilities to their own files
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/Makefile               |  1 +
>  drivers/gpu/drm/i915/gem/i915_gem_object.h  |  1 +
>  drivers/gpu/drm/i915/gt/intel_renderstate.h |  1 +
>  drivers/gpu/drm/i915/i915_gem.c             | 56 ------------------
>  drivers/gpu/drm/i915/i915_gem.h             | 12 ----
>  drivers/gpu/drm/i915/i915_gem_ww.c          | 63 +++++++++++++++++++++
>  drivers/gpu/drm/i915/i915_gem_ww.h          | 21 +++++++
>  7 files changed, 87 insertions(+), 68 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/i915_gem_ww.c
>  create mode 100644 drivers/gpu/drm/i915/i915_gem_ww.h
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 4f22cac1c49b..ea8ee4b3e018 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -45,6 +45,7 @@ i915-y += i915_drv.o \
>           i915_switcheroo.o \
>           i915_sysfs.o \
>           i915_utils.o \
> +         i915_gem_ww.o \

Nit: Should be kept sorted.

>           intel_device_info.o \
>           intel_dram.o \
>           intel_memory_region.o \
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> index 1fafcc89ecee..789529b424c1 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> @@ -15,6 +15,7 @@
>  #include "i915_gem_object_types.h"
>  #include "i915_gem_gtt.h"
>  #include "i915_vma_types.h"
> +#include "i915_gem_ww.h"

Same here.

Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-06-08 17:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  9:28 [PATCH 0/9] Prereqs for TTM accelerated migration Thomas Hellström
2021-06-08  9:28 ` [Intel-gfx] " Thomas Hellström
2021-06-08  9:28 ` [PATCH 1/9] drm/i915: Reference objects on the ww object list Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08 17:05   ` Matthew Auld
2021-06-08 17:05     ` [Intel-gfx] " Matthew Auld
2021-06-08  9:28 ` [PATCH 2/9] drm/i915: Break out dma_resv ww locking utilities to separate files Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08 17:10   ` Matthew Auld [this message]
2021-06-08 17:10     ` Matthew Auld
2021-06-08  9:28 ` [PATCH 3/9] drm/i915: Introduce a ww transaction helper Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08 17:17   ` Matthew Auld
2021-06-08 17:17     ` Matthew Auld
2021-06-08 19:00     ` Thomas Hellström
2021-06-08 19:00       ` Thomas Hellström
2021-06-08  9:28 ` [PATCH 4/9] drm/i915/gt: Add an insert_entry for gen8_ppgtt Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08  9:28 ` [PATCH 5/9] drm/i915/gt: Add a routine to iterate over the pagetables of a GTT Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08  9:28 ` [PATCH 6/9] drm/i915/gt: Export the pinned context constructor Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08  9:28 ` [PATCH 7/9] drm/i915/gt: Pipelined page migration Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08 16:18   ` Matthew Auld
2021-06-08 16:18     ` Matthew Auld
2021-06-08 19:05     ` Thomas Hellström
2021-06-08 19:05       ` Thomas Hellström
2021-06-08 19:09   ` Thomas Hellström
2021-06-08 19:09     ` [Intel-gfx] " Thomas Hellström
2021-06-08  9:28 ` [PATCH 8/9] drm/i915/gt: Pipelined clear Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08  9:28 ` [PATCH 9/9] drm/i915/gt: Setup a default migration context on the GT Thomas Hellström
2021-06-08  9:28   ` [Intel-gfx] " Thomas Hellström
2021-06-08 12:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prereqs for TTM accelerated migration Patchwork
2021-06-08 12:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-06-08 12:32 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM0jSHOc6A8oJ384=owQiqPXfeX-NgpRsKtujpn9fQ=JfUYj2A@mail.gmail.com' \
    --to=matthew.william.auld@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.