From: Johan Almbladh <johan.almbladh@anyfinetworks.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
bpf <bpf@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/9] powerpc/bpf: Various fixes
Date: Sat, 2 Oct 2021 19:41:01 +0200 [thread overview]
Message-ID: <CAM1=_QSrOZBk+_h224cdxrZw7djqUqO9jytYNV--9V-KTJmt9Q@mail.gmail.com> (raw)
In-Reply-To: <cover.1633104510.git.naveen.n.rao@linux.vnet.ibm.com>
On Fri, Oct 1, 2021 at 11:15 PM Naveen N. Rao
<naveen.n.rao@linux.vnet.ibm.com> wrote:
>
> Various fixes to the eBPF JIT for powerpc, thanks to some new tests
> added by Johan. This series fixes all failures in test_bpf on powerpc64.
> There are still some failures on powerpc32 to be looked into.
Great work! I have tested it on powerpc64 in QEMU, which is the same
setup that previously triggered an illegal instruction, and all tests
pass now. On powerpc32 there are still some issues left as you say.
Thanks!
Johan
>
> - Naveen
>
>
> Naveen N. Rao (8):
> powerpc/lib: Add helper to check if offset is within conditional
> branch range
> powerpc/bpf: Validate branch ranges
> powerpc/bpf: Handle large branch ranges with BPF_EXIT
> powerpc/bpf: Fix BPF_MOD when imm == 1
> powerpc/bpf: Fix BPF_SUB when imm == 0x80000000
> powerpc/bpf: Limit 'ldbrx' to processors compliant with ISA v2.06
> powerpc/security: Add a helper to query stf_barrier type
> powerpc/bpf: Emit stf barrier instruction sequences for BPF_NOSPEC
>
> Ravi Bangoria (1):
> powerpc/bpf: Remove unused SEEN_STACK
>
> arch/powerpc/include/asm/code-patching.h | 1 +
> arch/powerpc/include/asm/ppc-opcode.h | 1 +
> arch/powerpc/include/asm/security_features.h | 5 +
> arch/powerpc/kernel/security.c | 5 +
> arch/powerpc/lib/code-patching.c | 7 +-
> arch/powerpc/net/bpf_jit.h | 39 ++++---
> arch/powerpc/net/bpf_jit64.h | 8 +-
> arch/powerpc/net/bpf_jit_comp.c | 28 ++++-
> arch/powerpc/net/bpf_jit_comp32.c | 10 +-
> arch/powerpc/net/bpf_jit_comp64.c | 113 ++++++++++++++-----
> 10 files changed, 167 insertions(+), 50 deletions(-)
>
>
> base-commit: 044c2d99d9f43c6d6fde8bed00672517dd9a5a57
> --
> 2.33.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Johan Almbladh <johan.almbladh@anyfinetworks.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Nicholas Piggin <npiggin@gmail.com>, bpf <bpf@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH 0/9] powerpc/bpf: Various fixes
Date: Sat, 2 Oct 2021 19:41:01 +0200 [thread overview]
Message-ID: <CAM1=_QSrOZBk+_h224cdxrZw7djqUqO9jytYNV--9V-KTJmt9Q@mail.gmail.com> (raw)
In-Reply-To: <cover.1633104510.git.naveen.n.rao@linux.vnet.ibm.com>
On Fri, Oct 1, 2021 at 11:15 PM Naveen N. Rao
<naveen.n.rao@linux.vnet.ibm.com> wrote:
>
> Various fixes to the eBPF JIT for powerpc, thanks to some new tests
> added by Johan. This series fixes all failures in test_bpf on powerpc64.
> There are still some failures on powerpc32 to be looked into.
Great work! I have tested it on powerpc64 in QEMU, which is the same
setup that previously triggered an illegal instruction, and all tests
pass now. On powerpc32 there are still some issues left as you say.
Thanks!
Johan
>
> - Naveen
>
>
> Naveen N. Rao (8):
> powerpc/lib: Add helper to check if offset is within conditional
> branch range
> powerpc/bpf: Validate branch ranges
> powerpc/bpf: Handle large branch ranges with BPF_EXIT
> powerpc/bpf: Fix BPF_MOD when imm == 1
> powerpc/bpf: Fix BPF_SUB when imm == 0x80000000
> powerpc/bpf: Limit 'ldbrx' to processors compliant with ISA v2.06
> powerpc/security: Add a helper to query stf_barrier type
> powerpc/bpf: Emit stf barrier instruction sequences for BPF_NOSPEC
>
> Ravi Bangoria (1):
> powerpc/bpf: Remove unused SEEN_STACK
>
> arch/powerpc/include/asm/code-patching.h | 1 +
> arch/powerpc/include/asm/ppc-opcode.h | 1 +
> arch/powerpc/include/asm/security_features.h | 5 +
> arch/powerpc/kernel/security.c | 5 +
> arch/powerpc/lib/code-patching.c | 7 +-
> arch/powerpc/net/bpf_jit.h | 39 ++++---
> arch/powerpc/net/bpf_jit64.h | 8 +-
> arch/powerpc/net/bpf_jit_comp.c | 28 ++++-
> arch/powerpc/net/bpf_jit_comp32.c | 10 +-
> arch/powerpc/net/bpf_jit_comp64.c | 113 ++++++++++++++-----
> 10 files changed, 167 insertions(+), 50 deletions(-)
>
>
> base-commit: 044c2d99d9f43c6d6fde8bed00672517dd9a5a57
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-10-02 17:41 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 21:14 [PATCH 0/9] powerpc/bpf: Various fixes Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 21:14 ` [PATCH 1/9] powerpc/lib: Add helper to check if offset is within conditional branch range Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 21:37 ` Song Liu
2021-10-01 21:37 ` Song Liu
2021-10-04 18:02 ` Naveen N. Rao
2021-10-04 18:02 ` Naveen N. Rao
2021-10-03 7:50 ` Christophe Leroy
2021-10-04 18:03 ` Naveen N. Rao
2021-10-01 21:14 ` [PATCH 2/9] powerpc/bpf: Validate branch ranges Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 21:45 ` Song Liu
2021-10-01 21:45 ` Song Liu
2021-10-02 17:29 ` Johan Almbladh
2021-10-02 17:29 ` Johan Almbladh
2021-10-03 7:54 ` Christophe Leroy
2021-10-04 18:11 ` Naveen N. Rao
2021-10-01 21:14 ` [PATCH 3/9] powerpc/bpf: Remove unused SEEN_STACK Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 21:47 ` Song Liu
2021-10-01 21:47 ` Song Liu
2021-10-02 17:30 ` Johan Almbladh
2021-10-02 17:30 ` Johan Almbladh
2021-10-03 7:55 ` Christophe Leroy
2021-10-04 18:11 ` Naveen N. Rao
2021-10-05 5:50 ` Christophe Leroy
2021-10-05 20:22 ` Naveen N. Rao
2021-10-01 21:14 ` [PATCH 4/9] powerpc/bpf: Handle large branch ranges with BPF_EXIT Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 21:53 ` Song Liu
2021-10-01 21:53 ` Song Liu
2021-10-02 17:31 ` Johan Almbladh
2021-10-02 17:31 ` Johan Almbladh
2021-10-03 7:59 ` Christophe Leroy
2021-10-04 18:24 ` Naveen N. Rao
2021-10-05 5:46 ` Christophe Leroy
2022-01-07 11:46 ` Naveen N. Rao
2021-10-01 21:14 ` [PATCH 5/9] powerpc/bpf: Fix BPF_MOD when imm == 1 Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 21:55 ` Song Liu
2021-10-01 21:55 ` Song Liu
2021-10-02 17:32 ` Johan Almbladh
2021-10-02 17:32 ` Johan Almbladh
2021-10-01 21:14 ` [PATCH 6/9] powerpc/bpf: Fix BPF_SUB when imm == 0x80000000 Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 22:01 ` Song Liu
2021-10-01 22:01 ` Song Liu
2021-10-02 17:33 ` Johan Almbladh
2021-10-02 17:33 ` Johan Almbladh
2021-10-03 8:07 ` Christophe Leroy
2021-10-04 18:18 ` Naveen N. Rao
2021-10-05 5:40 ` Christophe Leroy
2021-10-01 21:14 ` [PATCH 7/9] powerpc/bpf: Limit 'ldbrx' to processors compliant with ISA v2.06 Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-02 17:35 ` Johan Almbladh
2021-10-02 17:35 ` Johan Almbladh
2021-10-01 21:14 ` [PATCH 8/9] powerpc/security: Add a helper to query stf_barrier type Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-01 21:14 ` [PATCH 9/9] powerpc/bpf: Emit stf barrier instruction sequences for BPF_NOSPEC Naveen N. Rao
2021-10-01 21:14 ` Naveen N. Rao
2021-10-02 17:41 ` Johan Almbladh [this message]
2021-10-02 17:41 ` [PATCH 0/9] powerpc/bpf: Various fixes Johan Almbladh
2021-10-04 18:19 ` Naveen N. Rao
2021-10-04 18:19 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM1=_QSrOZBk+_h224cdxrZw7djqUqO9jytYNV--9V-KTJmt9Q@mail.gmail.com' \
--to=johan.almbladh@anyfinetworks.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@iogearbox.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.