* [PATCH] cmake: Reduce verbosity for make invocation
@ 2019-03-11 5:51 Douglas Royds
2019-03-11 17:18 ` Khem Raj
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Douglas Royds @ 2019-03-11 5:51 UTC (permalink / raw)
To: openembedded-core
Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 in cmake.bbclass.
Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
to ensure that make (and ninja) output were verbose in log.do_compile.
Turning off CMAKE_VERBOSE_MAKEFILE=1 means that make (or ninja)
invocations from the command-line are non-verbose,
giving CMake's default human-readable output on the terminal instead.
The user can still invoke VERBOSE=1 make if they do want verbose output.
This has no effect on the verbose output that goes into the logs.
Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
meta/classes/cmake.bbclass | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
index fa7f68c99b..e16630434e 100644
--- a/meta/classes/cmake.bbclass
+++ b/meta/classes/cmake.bbclass
@@ -164,7 +164,6 @@ cmake_do_configure() {
-DCMAKE_INSTALL_DATAROOTDIR:PATH=${@os.path.relpath(d.getVar('datadir'), d.getVar('prefix'))} \
-DCMAKE_INSTALL_SO_NO_EXE=0 \
-DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
- -DCMAKE_VERBOSE_MAKEFILE=1 \
-DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
${EXTRA_OECMAKE} \
-Wno-dev
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] cmake: Reduce verbosity for make invocation
2019-03-11 5:51 [PATCH] cmake: Reduce verbosity for make invocation Douglas Royds
@ 2019-03-11 17:18 ` Khem Raj
2019-03-12 0:47 ` Douglas Royds
2019-03-12 5:32 ` [PATCH v2] " Douglas Royds
2019-03-12 5:38 ` [PATCH v3] " Douglas Royds
2 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2019-03-11 17:18 UTC (permalink / raw)
To: Douglas Royds; +Cc: Patches and discussions about the oe-core layer
On Sun, Mar 10, 2019 at 10:53 PM Douglas Royds
<douglas.royds@taitradio.com> wrote:
>
> Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 in cmake.bbclass.
> Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
> to ensure that make (and ninja) output were verbose in log.do_compile.
>
> Turning off CMAKE_VERBOSE_MAKEFILE=1 means that make (or ninja)
> invocations from the command-line are non-verbose,
> giving CMake's default human-readable output on the terminal instead.
> The user can still invoke VERBOSE=1 make if they do want verbose output.
> This has no effect on the verbose output that goes into the logs.
>
I think it would be better to have knob to turn is on and off both on
console and log files.
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
> meta/classes/cmake.bbclass | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index fa7f68c99b..e16630434e 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -164,7 +164,6 @@ cmake_do_configure() {
> -DCMAKE_INSTALL_DATAROOTDIR:PATH=${@os.path.relpath(d.getVar('datadir'), d.getVar('prefix'))} \
> -DCMAKE_INSTALL_SO_NO_EXE=0 \
> -DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
> - -DCMAKE_VERBOSE_MAKEFILE=1 \
> -DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
> ${EXTRA_OECMAKE} \
> -Wno-dev
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cmake: Reduce verbosity for make invocation
2019-03-11 17:18 ` Khem Raj
@ 2019-03-12 0:47 ` Douglas Royds
2019-03-12 4:09 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Douglas Royds @ 2019-03-12 0:47 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]
On 12/03/19 6:18 AM, Khem Raj wrote:
> On Sun, Mar 10, 2019 at 10:53 PM Douglas Royds
> <douglas.royds@taitradio.com> wrote:
>> Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 in cmake.bbclass.
>> Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
>> to ensure that make (and ninja) output were verbose in log.do_compile.
>>
>> Turning off CMAKE_VERBOSE_MAKEFILE=1 means that make (or ninja)
>> invocations from the command-line are non-verbose,
>> giving CMake's default human-readable output on the terminal instead.
>> The user can still invoke VERBOSE=1 make if they do want verbose output.
>> This has no effect on the verbose output that goes into the logs.
>>
> I think it would be better to have knob to turn is on and off both on
> console and log files.
If you want it on for some reason, you can turn it on in your local.conf:
EXTRA_OECMAKE_append=" -DCMAKE_VERBOSE_MAKEFILE=1"
Alternatively, you can turn verbosity on for a single invocation (this
is what I do when I need it):
make VERBOSE=1
You can also set an environment variable to make it always verbose, if
you want that for some reason:
VERBOSE=1 make
Do we really need a new variable for this?
[-- Attachment #2: Type: text/html, Size: 2010 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cmake: Reduce verbosity for make invocation
2019-03-12 0:47 ` Douglas Royds
@ 2019-03-12 4:09 ` Khem Raj
2019-03-12 4:34 ` Douglas Royds
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2019-03-12 4:09 UTC (permalink / raw)
To: Douglas Royds; +Cc: Patches and discussions about the oe-core layer
On Mon, Mar 11, 2019 at 5:47 PM Douglas Royds
<douglas.royds@taitradio.com> wrote:
>
> On 12/03/19 6:18 AM, Khem Raj wrote:
>
> On Sun, Mar 10, 2019 at 10:53 PM Douglas Royds
> <douglas.royds@taitradio.com> wrote:
>
> Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 in cmake.bbclass.
> Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
> to ensure that make (and ninja) output were verbose in log.do_compile.
>
> Turning off CMAKE_VERBOSE_MAKEFILE=1 means that make (or ninja)
> invocations from the command-line are non-verbose,
> giving CMake's default human-readable output on the terminal instead.
> The user can still invoke VERBOSE=1 make if they do want verbose output.
> This has no effect on the verbose output that goes into the logs.
>
> I think it would be better to have knob to turn is on and off both on
> console and log files.
>
>
> If you want it on for some reason, you can turn it on in your local.conf:
>
> EXTRA_OECMAKE_append=" -DCMAKE_VERBOSE_MAKEFILE=1"
>
> Alternatively, you can turn verbosity on for a single invocation (this is what I do when I need it):
>
> make VERBOSE=1
>
> You can also set an environment variable to make it always verbose, if you want that for some reason:
>
> VERBOSE=1 make
>
> Do we really need a new variable for this?
its fine if we can ensure consistent behaviour, I dont like the fact that
cmdline output would be different than whats stored in log files.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cmake: Reduce verbosity for make invocation
2019-03-12 4:09 ` Khem Raj
@ 2019-03-12 4:34 ` Douglas Royds
0 siblings, 0 replies; 7+ messages in thread
From: Douglas Royds @ 2019-03-12 4:34 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On 12/03/19 5:09 PM, Khem Raj wrote:
> On Mon, Mar 11, 2019 at 5:47 PM Douglas Royds
> <douglas.royds@taitradio.com> wrote:
>> On 12/03/19 6:18 AM, Khem Raj wrote:
>>
>> On Sun, Mar 10, 2019 at 10:53 PM Douglas Royds
>> <douglas.royds@taitradio.com> wrote:
>>
>> Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 in cmake.bbclass.
>> Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
>> to ensure that make (and ninja) output were verbose in log.do_compile.
>>
>> Turning off CMAKE_VERBOSE_MAKEFILE=1 means that make (or ninja)
>> invocations from the command-line are non-verbose,
>> giving CMake's default human-readable output on the terminal instead.
>> The user can still invoke VERBOSE=1 make if they do want verbose output.
>> This has no effect on the verbose output that goes into the logs.
>>
>> I think it would be better to have knob to turn is on and off both on
>> console and log files.
>>
>>
>> If you want it on for some reason, you can turn it on in your local.conf:
>>
>> EXTRA_OECMAKE_append=" -DCMAKE_VERBOSE_MAKEFILE=1"
>>
>> Alternatively, you can turn verbosity on for a single invocation (this is what I do when I need it):
>>
>> make VERBOSE=1
>>
>> You can also set an environment variable to make it always verbose, if you want that for some reason:
>>
>> VERBOSE=1 make
>>
>> Do we really need a new variable for this?
> its fine if we can ensure consistent behaviour, I dont like the fact that
> cmdline output would be different than whats stored in log files.
OK, that's a fair point. I'll update it with a variable.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] cmake: Reduce verbosity for make invocation
2019-03-11 5:51 [PATCH] cmake: Reduce verbosity for make invocation Douglas Royds
2019-03-11 17:18 ` Khem Raj
@ 2019-03-12 5:32 ` Douglas Royds
2019-03-12 5:38 ` [PATCH v3] " Douglas Royds
2 siblings, 0 replies; 7+ messages in thread
From: Douglas Royds @ 2019-03-12 5:32 UTC (permalink / raw)
To: openembedded-core
New variable OECMAKE_VERBOSE_MAKEFILE defaults to True.
Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 (True) in cmake.bbclass.
Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
to ensure that make (and ninja) output were verbose in log.do_compile.
Setting OECMAKE_VERBOSE_MAKEFILE to False means that make (or ninja)
invocations from the command-line are non-verbose,
giving CMake's default human-readable output on the terminal instead.
The user can still invoke VERBOSE=1 make if they do want verbose output.
This has no effect on the verbose output that goes into the logs.
---
meta/classes/cmake.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
index fa7f68c99b..0d44a74046 100644
--- a/meta/classes/cmake.bbclass
+++ b/meta/classes/cmake.bbclass
@@ -62,6 +62,7 @@ EXTRA_OECMAKE_BUILD_prepend_task-install = "${PARALLEL_MAKEINST} "
OECMAKE_TARGET_COMPILE ?= "all"
OECMAKE_TARGET_INSTALL ?= "install"
+OECMAKE_VERBOSE_MAKEFILE ?= "True"
# CMake expects target architectures in the format of uname(2),
# which do not always match TARGET_ARCH, so all the necessary
@@ -164,7 +165,7 @@ cmake_do_configure() {
-DCMAKE_INSTALL_DATAROOTDIR:PATH=${@os.path.relpath(d.getVar('datadir'), d.getVar('prefix'))} \
-DCMAKE_INSTALL_SO_NO_EXE=0 \
-DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
- -DCMAKE_VERBOSE_MAKEFILE=1 \
+ -DCMAKE_VERBOSE_MAKEFILE=${OECMAKE_VERBOSE_MAKEFILE} \
-DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
${EXTRA_OECMAKE} \
-Wno-dev
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3] cmake: Reduce verbosity for make invocation
2019-03-11 5:51 [PATCH] cmake: Reduce verbosity for make invocation Douglas Royds
2019-03-11 17:18 ` Khem Raj
2019-03-12 5:32 ` [PATCH v2] " Douglas Royds
@ 2019-03-12 5:38 ` Douglas Royds
2 siblings, 0 replies; 7+ messages in thread
From: Douglas Royds @ 2019-03-12 5:38 UTC (permalink / raw)
To: openembedded-core
New variable OECMAKE_VERBOSE_MAKEFILE defaults to True.
Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 (True) in cmake.bbclass.
Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
to ensure that make (and ninja) output were verbose in log.do_compile.
Setting OECMAKE_VERBOSE_MAKEFILE to False means that make (or ninja)
invocations from the command-line are non-verbose,
giving CMake's default human-readable output on the terminal instead.
The user can still invoke VERBOSE=1 make if they do want verbose output.
This has no effect on the verbose output that goes into the logs.
Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
meta/classes/cmake.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
index fa7f68c99b..0d44a74046 100644
--- a/meta/classes/cmake.bbclass
+++ b/meta/classes/cmake.bbclass
@@ -62,6 +62,7 @@ EXTRA_OECMAKE_BUILD_prepend_task-install = "${PARALLEL_MAKEINST} "
OECMAKE_TARGET_COMPILE ?= "all"
OECMAKE_TARGET_INSTALL ?= "install"
+OECMAKE_VERBOSE_MAKEFILE ?= "True"
# CMake expects target architectures in the format of uname(2),
# which do not always match TARGET_ARCH, so all the necessary
@@ -164,7 +165,7 @@ cmake_do_configure() {
-DCMAKE_INSTALL_DATAROOTDIR:PATH=${@os.path.relpath(d.getVar('datadir'), d.getVar('prefix'))} \
-DCMAKE_INSTALL_SO_NO_EXE=0 \
-DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
- -DCMAKE_VERBOSE_MAKEFILE=1 \
+ -DCMAKE_VERBOSE_MAKEFILE=${OECMAKE_VERBOSE_MAKEFILE} \
-DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
${EXTRA_OECMAKE} \
-Wno-dev
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-12 5:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 5:51 [PATCH] cmake: Reduce verbosity for make invocation Douglas Royds
2019-03-11 17:18 ` Khem Raj
2019-03-12 0:47 ` Douglas Royds
2019-03-12 4:09 ` Khem Raj
2019-03-12 4:34 ` Douglas Royds
2019-03-12 5:32 ` [PATCH v2] " Douglas Royds
2019-03-12 5:38 ` [PATCH v3] " Douglas Royds
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.