[PATCH] insane: Promote warnings into errors

[PATCH] insane: Promote warnings into errors

[Richard Purdie]

There are several warnings the build can emit which show real problems
in the way recipes are being built. Some distros like poky and the Yocto
Project autobuilder have been fixing the issues these show for some time.

OE-Core has therefore been clean of these errors and warnings for some time.
Promote warnings into errors to match the defaults in poky to encourage
people to fix these real issue and reduce confusion when people switch
distros or customise.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/insane.bbclass | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 7fc8f33a982..8b19f445f9b 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -22,11 +22,9 @@ QA_SANE = "True"
 
 # Elect whether a given type of error is a warning or error, they may
 # have been set by other files.
-WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \
-            textrel already-stripped incompatible-license files-invalid \
-            installed-vs-shipped compile-host-path install-host-path \
-            pn-overrides infodir build-deps src-uri-bad \
-            unknown-configure-option symlink-to-sysroot multilib \
+WARN_QA ?= " libdir xorg-driver-abi \
+            textrel incompatible-license files-invalid \
+            infodir build-deps src-uri-bad symlink-to-sysroot multilib \
             invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \
             mime mime-xdg \
             "
@@ -36,6 +34,9 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
             version-going-backwards expanded-d invalid-chars \
             license-checksum dev-elf file-rdeps configure-unsafe \
             configure-gettext perllocalpod shebang-size \
+            already-stripped installed-vs-shipped ldflags compile-host-path \
+            install-host-path pn-overrides unknown-configure-option \
+            useless-rpaths rpaths staticdev \
             "
 # Add usrmerge QA check based on distro feature
 ERROR_QA_append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}"
-- 
2.25.1

Re: [OE-core] [PATCH] insane: Promote warnings into errors

[Khem Raj]

On 5/6/20 6:40 AM, Richard Purdie wrote:
> There are several warnings the build can emit which show real problems
> in the way recipes are being built. Some distros like poky and the Yocto
> Project autobuilder have been fixing the issues these show for some time.
> 
> OE-Core has therefore been clean of these errors and warnings for some time.
> Promote warnings into errors to match the defaults in poky to encourage
> people to fix these real issue and reduce confusion when people switch
> distros or customise.

This is a good change, and I think all settings used in poky in this
regard are worth for OE-core.

> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/insane.bbclass | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 7fc8f33a982..8b19f445f9b 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -22,11 +22,9 @@ QA_SANE = "True"
>  
>  # Elect whether a given type of error is a warning or error, they may
>  # have been set by other files.
> -WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \
> -            textrel already-stripped incompatible-license files-invalid \
> -            installed-vs-shipped compile-host-path install-host-path \
> -            pn-overrides infodir build-deps src-uri-bad \
> -            unknown-configure-option symlink-to-sysroot multilib \
> +WARN_QA ?= " libdir xorg-driver-abi \
> +            textrel incompatible-license files-invalid \
> +            infodir build-deps src-uri-bad symlink-to-sysroot multilib \
>              invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \
>              mime mime-xdg \
>              "
> @@ -36,6 +34,9 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
>              version-going-backwards expanded-d invalid-chars \
>              license-checksum dev-elf file-rdeps configure-unsafe \
>              configure-gettext perllocalpod shebang-size \
> +            already-stripped installed-vs-shipped ldflags compile-host-path \
> +            install-host-path pn-overrides unknown-configure-option \
> +            useless-rpaths rpaths staticdev \
>              "
>  # Add usrmerge QA check based on distro feature
>  ERROR_QA_append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}"
> 
> 
> 
> 

Re: [OE-core] [PATCH] insane: Promote warnings into errors

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3040 bytes --]

Agreed, I would go even further and move all WARN_QA to ERROR_QA. I do that
in all my builds already for few years, so oe-core+meta-oe status shouldn't
be so bad and those few cases where it still fails can be skipped with
INSANE_SKIP in the recipe - to make sure that no new warnings are
introduced later.

On Thu, May 7, 2020 at 10:07 PM Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On 5/6/20 6:40 AM, Richard Purdie wrote:
> > There are several warnings the build can emit which show real problems
> > in the way recipes are being built. Some distros like poky and the Yocto
> > Project autobuilder have been fixing the issues these show for some time.
> >
> > OE-Core has therefore been clean of these errors and warnings for some
> time.
> > Promote warnings into errors to match the defaults in poky to encourage
> > people to fix these real issue and reduce confusion when people switch
> > distros or customise.
>
> This is a good change, and I think all settings used in poky in this
> regard are worth for OE-core.
>
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/classes/insane.bbclass | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> > index 7fc8f33a982..8b19f445f9b 100644
> > --- a/meta/classes/insane.bbclass
> > +++ b/meta/classes/insane.bbclass
> > @@ -22,11 +22,9 @@ QA_SANE = "True"
> >
> >  # Elect whether a given type of error is a warning or error, they may
> >  # have been set by other files.
> > -WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir
> xorg-driver-abi \
> > -            textrel already-stripped incompatible-license files-invalid
> \
> > -            installed-vs-shipped compile-host-path install-host-path \
> > -            pn-overrides infodir build-deps src-uri-bad \
> > -            unknown-configure-option symlink-to-sysroot multilib \
> > +WARN_QA ?= " libdir xorg-driver-abi \
> > +            textrel incompatible-license files-invalid \
> > +            infodir build-deps src-uri-bad symlink-to-sysroot multilib \
> >              invalid-packageconfig host-user-contaminated uppercase-pn
> patch-fuzz \
> >              mime mime-xdg \
> >              "
> > @@ -36,6 +34,9 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files
> arch pkgconfig la \
> >              version-going-backwards expanded-d invalid-chars \
> >              license-checksum dev-elf file-rdeps configure-unsafe \
> >              configure-gettext perllocalpod shebang-size \
> > +            already-stripped installed-vs-shipped ldflags
> compile-host-path \
> > +            install-host-path pn-overrides unknown-configure-option \
> > +            useless-rpaths rpaths staticdev \
> >              "
> >  # Add usrmerge QA check based on distro feature
> >  ERROR_QA_append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge',
> ' usrmerge', '', d)}"
> >
> >
> >
> >
> 
>

[-- Attachment #2: Type: text/html, Size: 3819 bytes --]

Re: [OE-core] [PATCH] insane: Promote warnings into errors

[Richard Purdie]

On Sat, 2020-05-09 at 19:57 +0200, Martin Jansa wrote:
> Agreed, I would go even further and move all WARN_QA to ERROR_QA. I
> do that in all my builds already for few years, so oe-core+meta-oe
> status shouldn't be so bad and those few cases where it still fails
> can be skipped with INSANE_SKIP in the recipe - to make sure that no
> new warnings are introduced later.

I wasn't really sure how far to take this, I also wondered about this.
FWIW we've already cleaned up all the warnings from the YP autobuilder
so OE-Core should be warning clean and the meta-oe builds made there
are also warning clean.

That does mean we should be able to do that at least from the
perspective of those layers.

The best way forward may be to give this a week or so to settle and
then add an additional patch moving the rest over?

Cheers,

Richard

Re: [OE-core] [PATCH] insane: Promote warnings into errors

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Sat, May 9, 2020 at 12:36 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Sat, 2020-05-09 at 19:57 +0200, Martin Jansa wrote:
> > Agreed, I would go even further and move all WARN_QA to ERROR_QA. I
> > do that in all my builds already for few years, so oe-core+meta-oe
> > status shouldn't be so bad and those few cases where it still fails
> > can be skipped with INSANE_SKIP in the recipe - to make sure that no
> > new warnings are introduced later.
>
> I wasn't really sure how far to take this, I also wondered about this.
> FWIW we've already cleaned up all the warnings from the YP autobuilder
> so OE-Core should be warning clean and the meta-oe builds made there
> are also warning clean.
>

Meta Oe layers are already being CI with same strict setting as poky so I
don’t see huge fallouts perhaps raise the bar

>
> That does mean we should be able to do that at least from the
> perspective of those layers.
>
> The best way forward may be to give this a week or so to settle and
> then add an additional patch moving the rest over?
>

Seems ok


> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 1833 bytes --]