All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Yicong Yang <yangyicong@huawei.com>,
	linux-efi@vger.kernel.org, yangyicong@hisilicon.com,
	linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
	probinson@gmail.com, andersson@kernel.org,
	catalin.marinas@arm.com, will@kernel.org,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] efi/libstub: arm64: avoid SetVirtualAddressMap() when possible
Date: Thu, 20 Oct 2022 15:04:11 +0200	[thread overview]
Message-ID: <CAMj1kXG=aE4yn-OvQdzRLE17BS=tGBySZ9DV0pHj9LN8onaerA@mail.gmail.com> (raw)
In-Reply-To: <9c06c75d-5079-dd27-6533-c053c986083e@leemhuis.info>

> On 19.10.22 05:24, Yicong Yang wrote:
> >
> > After entering 6.1-rc1 the efi runtime services is not working on my platform:
> >
> > [    0.054039] Remapping and enabling EFI services.
> > [    0.054043] UEFI virtual mapping missing or invalid -- runtime services will not be available
> >
> > Not sure this patch is the root cause since I see some refactor of efi codes in 6.1-rc1,
> > but simply reverting this make EFI runtime services works again. Tested on HiSilicon's
> > Kunpeng 920 arm64 server using 48 bit VA address:
> >
> > CONFIG_ARM64_VA_BITS_48=y
> > CONFIG_ARM64_VA_BITS=48
> >
> > Thanks.

Hi,

Can you try the change below please?

+++ b/drivers/firmware/efi/arm-runtime.c
@@ -63,7 +63,7 @@ static bool __init efi_virtmap_init(void)

                if (!(md->attribute & EFI_MEMORY_RUNTIME))
                        continue;
-               if (md->virt_addr == 0)
+               if (md->virt_addr == 0 && md->phys_addr != 0)
                        return false;

                ret = efi_create_mapping(&efi_mm, md);

WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
Cc: Yicong Yang <yangyicong@huawei.com>,
	linux-efi@vger.kernel.org,  yangyicong@hisilicon.com,
	linux-arm-kernel@lists.infradead.org,  mark.rutland@arm.com,
	probinson@gmail.com, andersson@kernel.org,
	 catalin.marinas@arm.com, will@kernel.org,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] efi/libstub: arm64: avoid SetVirtualAddressMap() when possible
Date: Thu, 20 Oct 2022 15:04:11 +0200	[thread overview]
Message-ID: <CAMj1kXG=aE4yn-OvQdzRLE17BS=tGBySZ9DV0pHj9LN8onaerA@mail.gmail.com> (raw)
In-Reply-To: <9c06c75d-5079-dd27-6533-c053c986083e@leemhuis.info>

> On 19.10.22 05:24, Yicong Yang wrote:
> >
> > After entering 6.1-rc1 the efi runtime services is not working on my platform:
> >
> > [    0.054039] Remapping and enabling EFI services.
> > [    0.054043] UEFI virtual mapping missing or invalid -- runtime services will not be available
> >
> > Not sure this patch is the root cause since I see some refactor of efi codes in 6.1-rc1,
> > but simply reverting this make EFI runtime services works again. Tested on HiSilicon's
> > Kunpeng 920 arm64 server using 48 bit VA address:
> >
> > CONFIG_ARM64_VA_BITS_48=y
> > CONFIG_ARM64_VA_BITS=48
> >
> > Thanks.

Hi,

Can you try the change below please?

+++ b/drivers/firmware/efi/arm-runtime.c
@@ -63,7 +63,7 @@ static bool __init efi_virtmap_init(void)

                if (!(md->attribute & EFI_MEMORY_RUNTIME))
                        continue;
-               if (md->virt_addr == 0)
+               if (md->virt_addr == 0 && md->phys_addr != 0)
                        return false;

                ret = efi_create_mapping(&efi_mm, md);

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-20 13:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 10:18 [PATCH] efi/libstub: arm64: avoid SetVirtualAddressMap() when possible Ard Biesheuvel
2022-09-16 10:18 ` Ard Biesheuvel
2022-09-16 10:20 ` Ard Biesheuvel
2022-09-16 10:20   ` Ard Biesheuvel
2022-10-19  3:24 ` Yicong Yang
2022-10-19  3:24   ` Yicong Yang
2022-10-20 12:39   ` Thorsten Leemhuis
2022-10-20 12:39     ` Thorsten Leemhuis
2022-10-20 13:04     ` Ard Biesheuvel [this message]
2022-10-20 13:04       ` Ard Biesheuvel
2022-10-21  1:59       ` Yicong Yang
2022-10-21  1:59         ` Yicong Yang
2022-10-23 14:58     ` [PATCH] efi/libstub: arm64: avoid SetVirtualAddressMap() when possible #forregzbot Thorsten Leemhuis
2022-10-23 14:58       ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXG=aE4yn-OvQdzRLE17BS=tGBySZ9DV0pHj9LN8onaerA@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=andersson@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=probinson@gmail.com \
    --cc=will@kernel.org \
    --cc=yangyicong@hisilicon.com \
    --cc=yangyicong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.