From: Zhangfei Gao <zhangfei.gao@gmail.com> To: Florian Fainelli <f.fainelli@gmail.com> Cc: Zhangfei Gao <zhangfei.gao@linaro.org>, netdev <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Date: Thu, 20 Mar 2014 18:53:50 +0800 [thread overview] Message-ID: <CAMj5Bkjm3G=K=fqas6VG5NXroofWijN_sc7XGLzT5jVehwTd0Q@mail.gmail.com> (raw) In-Reply-To: <CAGVrzcY4SBKFfTvjB0TTvgpAOwCt30C6LjYf9e9E4ciMDVmp-w@mail.gmail.com> Dear Florian On Wed, Mar 19, 2014 at 1:28 AM, Florian Fainelli <f.fainelli@gmail.com> wrote: > 2014-03-18 1:40 GMT-07:00 Zhangfei Gao <zhangfei.gao@linaro.org>: >> +static int hip04_mdio_reset(struct mii_bus *bus) >> +{ >> + int temp, err, i; >> + >> + for (i = 0; i < 2; i++) { >> + hip04_mdio_write(bus, i, 22, 0); >> + temp = hip04_mdio_read(bus, i, MII_BMCR); >> + temp |= BMCR_RESET; >> + err = hip04_mdio_write(bus, i, MII_BMCR, temp); >> + if (err < 0) >> + return err; >> + } >> + >> + mdelay(500); > > This does not look correct, you should iterate over all possible PHYs: > PHY_MAX_ADDR instead of hardcoding the loop to 2. OK, got it. Use 2 is since only have 2 phy in the board, will use PHY_MAX_ADDR instead. > > I think we might want to remove the mdio bus reset callback in general > as the PHY library should already take care of software resetting the > PHY to put it in a sane state, as well as waiting for the appropriate > delay before using, unlike here, where you do not poll for BMCR_RESET > to be cleared by the PHY. > Do you mean will move BMCR_RESET to common code, that's would be great. The mdio_reset is added here to get phy_id, otherwise the phy_id can not be read as well as detection. Thanks
WARNING: multiple messages have this Message-ID (diff)
From: zhangfei.gao@gmail.com (Zhangfei Gao) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Date: Thu, 20 Mar 2014 18:53:50 +0800 [thread overview] Message-ID: <CAMj5Bkjm3G=K=fqas6VG5NXroofWijN_sc7XGLzT5jVehwTd0Q@mail.gmail.com> (raw) In-Reply-To: <CAGVrzcY4SBKFfTvjB0TTvgpAOwCt30C6LjYf9e9E4ciMDVmp-w@mail.gmail.com> Dear Florian On Wed, Mar 19, 2014 at 1:28 AM, Florian Fainelli <f.fainelli@gmail.com> wrote: > 2014-03-18 1:40 GMT-07:00 Zhangfei Gao <zhangfei.gao@linaro.org>: >> +static int hip04_mdio_reset(struct mii_bus *bus) >> +{ >> + int temp, err, i; >> + >> + for (i = 0; i < 2; i++) { >> + hip04_mdio_write(bus, i, 22, 0); >> + temp = hip04_mdio_read(bus, i, MII_BMCR); >> + temp |= BMCR_RESET; >> + err = hip04_mdio_write(bus, i, MII_BMCR, temp); >> + if (err < 0) >> + return err; >> + } >> + >> + mdelay(500); > > This does not look correct, you should iterate over all possible PHYs: > PHY_MAX_ADDR instead of hardcoding the loop to 2. OK, got it. Use 2 is since only have 2 phy in the board, will use PHY_MAX_ADDR instead. > > I think we might want to remove the mdio bus reset callback in general > as the PHY library should already take care of software resetting the > PHY to put it in a sane state, as well as waiting for the appropriate > delay before using, unlike here, where you do not poll for BMCR_RESET > to be cleared by the PHY. > Do you mean will move BMCR_RESET to common code, that's would be great. The mdio_reset is added here to get phy_id, otherwise the phy_id can not be read as well as detection. Thanks
next prev parent reply other threads:[~2014-03-20 10:53 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-03-18 8:40 [PATCH 0/3] add hisilicon hip04 ethernet driver Zhangfei Gao 2014-03-18 8:40 ` Zhangfei Gao 2014-03-18 8:40 ` [PATCH 1/3] Documentation: add Device tree bindings for Hisilicon hip04 ethernet Zhangfei Gao 2014-03-18 8:40 ` Zhangfei Gao 2014-03-18 12:34 ` Mark Rutland 2014-03-18 12:34 ` Mark Rutland [not found] ` <20140318123451.GA2941-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> 2014-03-21 12:59 ` Zhangfei Gao 2014-03-21 12:59 ` Zhangfei Gao 2014-03-18 12:51 ` Sergei Shtylyov 2014-03-18 12:51 ` Sergei Shtylyov 2014-03-21 13:04 ` Zhangfei Gao 2014-03-21 13:04 ` Zhangfei Gao 2014-03-18 17:39 ` Florian Fainelli 2014-03-18 17:39 ` Florian Fainelli 2014-03-20 11:29 ` Zhangfei Gao 2014-03-20 11:29 ` Zhangfei Gao 2014-03-18 8:40 ` [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao 2014-03-18 8:40 ` Zhangfei Gao [not found] ` <1395132017-15928-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2014-03-18 17:28 ` Florian Fainelli 2014-03-18 17:28 ` Florian Fainelli 2014-03-20 10:53 ` Zhangfei Gao [this message] 2014-03-20 10:53 ` Zhangfei Gao 2014-03-20 17:59 ` Florian Fainelli 2014-03-20 17:59 ` Florian Fainelli 2014-03-21 5:27 ` Zhangfei Gao 2014-03-21 5:27 ` Zhangfei Gao [not found] ` <1395132017-15928-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2014-03-18 8:40 ` [PATCH 3/3] net: hisilicon: new hip04 ethernet driver Zhangfei Gao 2014-03-18 8:40 ` Zhangfei Gao [not found] ` <1395132017-15928-4-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2014-03-18 10:46 ` Russell King - ARM Linux 2014-03-18 10:46 ` Russell King - ARM Linux 2014-03-20 9:51 ` Zhangfei Gao 2014-03-20 9:51 ` Zhangfei Gao 2014-03-24 14:17 ` Rob Herring 2014-03-24 14:17 ` Rob Herring 2014-03-26 14:22 ` Zhangfei Gao 2014-03-26 14:22 ` Zhangfei Gao 2014-03-18 11:25 ` Arnd Bergmann 2014-03-18 11:25 ` Arnd Bergmann 2014-03-20 14:00 ` Zhangfei Gao 2014-03-20 14:00 ` Zhangfei Gao 2014-03-20 14:31 ` Arnd Bergmann 2014-03-20 14:31 ` Arnd Bergmann [not found] ` <201403201531.20416.arnd-r2nGTMty4D4@public.gmane.org> 2014-03-21 5:19 ` Zhangfei Gao 2014-03-21 5:19 ` Zhangfei Gao 2014-03-21 7:37 ` Arnd Bergmann 2014-03-21 7:37 ` Arnd Bergmann 2014-03-21 7:56 ` Zhangfei Gao 2014-03-21 7:56 ` Zhangfei Gao 2014-03-24 8:17 ` Zhangfei Gao 2014-03-24 8:17 ` Zhangfei Gao 2014-03-24 10:02 ` Arnd Bergmann 2014-03-24 10:02 ` Arnd Bergmann 2014-03-24 13:23 ` Zhangfei Gao 2014-03-24 13:23 ` Zhangfei Gao 2014-03-18 10:27 ` [PATCH 0/3] add hisilicon " Ding Tianhong 2014-03-18 10:27 ` Ding Tianhong 2014-03-21 15:09 [PATCH v2 " Zhangfei Gao 2014-03-21 15:09 ` [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao 2014-03-21 15:09 ` Zhangfei Gao 2014-03-24 14:14 [PATCH v3 0/3] add hisilicon hip04 ethernet driver Zhangfei Gao [not found] ` <1395670496-17381-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2014-03-24 14:14 ` [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao 2014-03-24 14:14 ` Zhangfei Gao 2014-03-28 15:35 [PATCH v4 0/3] add hisilicon hip04 ethernet driver Zhangfei Gao 2014-03-28 15:35 ` [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao 2014-03-28 15:35 ` Zhangfei Gao [not found] ` <1396020960-6170-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2014-03-30 21:23 ` David Miller 2014-03-30 21:23 ` David Miller 2014-03-31 2:45 ` zhangfei 2014-03-31 2:45 ` zhangfei 2014-04-01 13:27 [PATCH v5 0/3] add hisilicon hip04 ethernet driver Zhangfei Gao [not found] ` <1396358832-15828-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2014-04-01 13:27 ` [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao 2014-04-01 13:27 ` Zhangfei Gao 2014-04-04 15:42 ` Zhangfei Gao 2014-04-04 15:42 ` Zhangfei Gao 2014-04-04 17:48 ` David Miller 2014-04-04 17:48 ` David Miller 2014-04-04 15:16 [PATCH v6 0/3] add hisilicon hip04 ethernet driver Zhangfei Gao 2014-04-04 15:16 ` [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao 2014-04-04 15:16 ` Zhangfei Gao 2014-04-04 15:30 ` David Miller 2014-04-04 15:30 ` David Miller 2014-04-04 15:40 ` zhangfei 2014-04-04 15:40 ` zhangfei 2014-04-04 15:43 ` David Miller 2014-04-04 15:43 ` David Miller 2014-04-04 15:45 ` Zhangfei Gao 2014-04-04 15:45 ` Zhangfei Gao 2014-04-05 4:35 [PATCH v7 0/3] add hisilicon hip04 ethernet driver Zhangfei Gao 2014-04-05 4:35 ` [PATCH 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao 2014-04-05 4:35 ` Zhangfei Gao 2014-04-07 18:47 ` David Miller 2014-04-07 18:47 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMj5Bkjm3G=K=fqas6VG5NXroofWijN_sc7XGLzT5jVehwTd0Q@mail.gmail.com' \ --to=zhangfei.gao@gmail.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=netdev@vger.kernel.org \ --cc=zhangfei.gao@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.