* [patch] blackfin: Fixup bogus ioresource init
@ 2011-07-23 15:51 Thomas Gleixner
2011-07-27 6:58 ` Mike Frysinger
2011-08-12 1:48 ` Mike Frysinger
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Gleixner @ 2011-07-23 15:51 UTC (permalink / raw)
To: LKML; +Cc: Mike Frysinger, Javier Herrero
[-- Attachment #1: blackfin-fixup-bogus-ioresource-init.patch --]
[-- Type: text/plain, Size: 1218 bytes --]
IRQF_SHARED is not part of the IORESOURCE_IRQ bits. It's expressed by
IORESOURCE_IRQ_SHAREABLE.
IORESOURCE_IRQ_HIGHEDGE and IRQF_TRIGGER_HIGH are contradicting
values, an interrupt can hardly be configured for both level and edge
at the same time. This was introduced in commit 45138439(Blackfin
arch: flash memory map and dm9000 resources updating) of course
without any hint in the changelog what the heck this is supposed to
do.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Javier Herrero <jherrero@hvsistemas.es>
---
arch/blackfin/mach-bf533/boards/H8606.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/arch/blackfin/mach-bf533/boards/H8606.c
===================================================================
--- linux-2.6.orig/arch/blackfin/mach-bf533/boards/H8606.c
+++ linux-2.6/arch/blackfin/mach-bf533/boards/H8606.c
@@ -54,7 +54,8 @@ static struct resource dm9000_resources[
[2] = {
.start = IRQ_PF10,
.end = IRQ_PF10,
- .flags = (IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHEDGE | IRQF_SHARED | IRQF_TRIGGER_HIGH),
+ .flags = (IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHEDGE |
+ | IORESOURCE_IRQ_SHAREABLE),
},
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] blackfin: Fixup bogus ioresource init
2011-07-23 15:51 [patch] blackfin: Fixup bogus ioresource init Thomas Gleixner
@ 2011-07-27 6:58 ` Mike Frysinger
2011-08-12 1:48 ` Mike Frysinger
1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2011-07-27 6:58 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: LKML, Javier Herrero
On Sat, Jul 23, 2011 at 08:51, Thomas Gleixner wrote:
> IRQF_SHARED is not part of the IORESOURCE_IRQ bits. It's expressed by
> IORESOURCE_IRQ_SHAREABLE.
>
> IORESOURCE_IRQ_HIGHEDGE and IRQF_TRIGGER_HIGH are contradicting
> values, an interrupt can hardly be configured for both level and edge
> at the same time. This was introduced in commit 45138439(Blackfin
> arch: flash memory map and dm9000 resources updating) of course
> without any hint in the changelog what the heck this is supposed to
> do.
makes sense to me. if Javier doesnt have a problem with it, i'll pick
it up in a while (traveling atm).
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] blackfin: Fixup bogus ioresource init
2011-07-23 15:51 [patch] blackfin: Fixup bogus ioresource init Thomas Gleixner
2011-07-27 6:58 ` Mike Frysinger
@ 2011-08-12 1:48 ` Mike Frysinger
1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2011-08-12 1:48 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: LKML, Javier Herrero
On Sat, Jul 23, 2011 at 11:51, Thomas Gleixner wrote:
> + .flags = (IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHEDGE |
> + | IORESOURCE_IRQ_SHAREABLE),
this introduced a syntax error (two "|" back to back). ive pushed out
a fix to my next branch with it.
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-12 1:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-23 15:51 [patch] blackfin: Fixup bogus ioresource init Thomas Gleixner
2011-07-27 6:58 ` Mike Frysinger
2011-08-12 1:48 ` Mike Frysinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.