From: Geert Uytterhoeven <geert@linux-m68k.org> To: jmondi <jacopo@jmondi.org> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>, Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 3/4] arm: dts: gr-peach: Add ETHER pin group Date: Thu, 24 Aug 2017 13:56:16 +0200 [thread overview] Message-ID: <CAMuHMdU5Vep+m7XtjcbSvyXUzD_Pn2crcQ68VRmS4bgY44ut0w@mail.gmail.com> (raw) In-Reply-To: <20170824114656.GA3905@w540> Hi Jacopo, On Thu, Aug 24, 2017 at 1:46 PM, jmondi <jacopo@jmondi.org> wrote: > On Thu, Aug 24, 2017 at 11:48:14AM +0200, Geert Uytterhoeven wrote: >> On Thu, Aug 24, 2017 at 10:48 AM, Jacopo Mondi >> <jacopo+renesas@jmondi.org> wrote: >> > Add pin configuration subnode for ETHER pin group. >> > The interface can be configured and probed, but no traffic can be >> > transmitted or received. >> > >> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >> > >> > --- >> > When in u-boot console I can ping a connected host, after the >> > system has booted I can configure an ip address on the interface but >> > cannot exchange any traffic. >> > I have compared the pin configuration procedure with the u-boot >> > implemented one and some sketches from mbed operating system libraries, >> > the configured pins are correct and registers values seems to match. >> > Not sure if this patch should be sent for inclusion but sending it out >> > anyway for you to judge this. >> All OK, but do you need P4_2, which is used for ET_nRST? > > I tried requesting the GPIO in the "ether" subnode and define it as > "active low", so that it is kept high during regular operations. > I have verified through register writes dump it is cycled just after > the gpio is requested, and this should reset the interface before the > actual sh_eth driver kicks in. > > I haven't find any mention in device tree bindings documentation of a > "reset-gpio" property for sh_eth, in the code examples I've seen in > u-boot and mbed, the interface is reset before any actual > configuration is performed. I feel like that should be the place where > that gpio is requested and cycled... Documentation/devicetree/bindings/net/mdio.txt says These are generic properties that can apply to any MDIO bus. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/4] arm: dts: gr-peach: Add ETHER pin group Date: Thu, 24 Aug 2017 13:56:16 +0200 [thread overview] Message-ID: <CAMuHMdU5Vep+m7XtjcbSvyXUzD_Pn2crcQ68VRmS4bgY44ut0w@mail.gmail.com> (raw) In-Reply-To: <20170824114656.GA3905@w540> Hi Jacopo, On Thu, Aug 24, 2017 at 1:46 PM, jmondi <jacopo@jmondi.org> wrote: > On Thu, Aug 24, 2017 at 11:48:14AM +0200, Geert Uytterhoeven wrote: >> On Thu, Aug 24, 2017 at 10:48 AM, Jacopo Mondi >> <jacopo+renesas@jmondi.org> wrote: >> > Add pin configuration subnode for ETHER pin group. >> > The interface can be configured and probed, but no traffic can be >> > transmitted or received. >> > >> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >> > >> > --- >> > When in u-boot console I can ping a connected host, after the >> > system has booted I can configure an ip address on the interface but >> > cannot exchange any traffic. >> > I have compared the pin configuration procedure with the u-boot >> > implemented one and some sketches from mbed operating system libraries, >> > the configured pins are correct and registers values seems to match. >> > Not sure if this patch should be sent for inclusion but sending it out >> > anyway for you to judge this. >> All OK, but do you need P4_2, which is used for ET_nRST? > > I tried requesting the GPIO in the "ether" subnode and define it as > "active low", so that it is kept high during regular operations. > I have verified through register writes dump it is cycled just after > the gpio is requested, and this should reset the interface before the > actual sh_eth driver kicks in. > > I haven't find any mention in device tree bindings documentation of a > "reset-gpio" property for sh_eth, in the code examples I've seen in > u-boot and mbed, the interface is reset before any actual > configuration is performed. I feel like that should be the place where > that gpio is requested and cycled... Documentation/devicetree/bindings/net/mdio.txt says These are generic properties that can apply to any MDIO bus. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2017-08-24 11:56 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-24 8:48 [PATCH 0/4] GR-Peach DTS update Jacopo Mondi 2017-08-24 8:48 ` Jacopo Mondi 2017-08-24 8:48 ` [PATCH 1/4] arm: dts: gr-peach: Remove empty line Jacopo Mondi 2017-08-24 9:22 ` Geert Uytterhoeven 2017-08-24 9:22 ` Geert Uytterhoeven 2017-08-24 8:48 ` [PATCH 2/4] arm: dts: gr-peach: Add SCIF2 pin group Jacopo Mondi 2017-08-24 9:27 ` Geert Uytterhoeven 2017-08-24 9:27 ` Geert Uytterhoeven [not found] ` <1503564523-31899-1-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> 2017-08-24 8:48 ` [PATCH 3/4] arm: dts: gr-peach: Add ETHER " Jacopo Mondi 2017-08-24 8:48 ` Jacopo Mondi [not found] ` <1503564523-31899-4-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> 2017-08-24 9:48 ` Geert Uytterhoeven 2017-08-24 9:48 ` Geert Uytterhoeven 2017-08-24 9:48 ` Geert Uytterhoeven 2017-08-24 11:46 ` jmondi 2017-08-24 11:46 ` jmondi 2017-08-24 11:56 ` Geert Uytterhoeven [this message] 2017-08-24 11:56 ` Geert Uytterhoeven 2017-08-24 12:53 ` jmondi 2017-08-24 12:53 ` jmondi 2017-08-30 7:25 ` Simon Horman 2017-08-30 7:25 ` Simon Horman 2017-08-30 7:25 ` Simon Horman 2017-08-30 7:35 ` jmondi 2017-08-30 7:35 ` jmondi 2017-08-30 9:28 ` Simon Horman 2017-08-30 9:28 ` Simon Horman 2017-08-30 9:28 ` Simon Horman 2017-09-14 15:59 ` jacopo mondi 2017-09-14 16:09 ` Chris Brandt 2017-08-24 8:48 ` [PATCH 4/4] arm: dts: gr-peach: Add user led device nodes Jacopo Mondi 2017-08-24 8:48 ` Jacopo Mondi [not found] ` <1503564523-31899-5-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> 2017-08-24 9:31 ` Geert Uytterhoeven 2017-08-24 9:31 ` Geert Uytterhoeven 2017-08-24 9:31 ` Geert Uytterhoeven 2017-08-24 10:53 ` [PATCH 0/4] GR-Peach DTS update Simon Horman 2017-08-24 10:53 ` Simon Horman [not found] ` <20170824105350.GD27788-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2017-08-24 10:57 ` Simon Horman 2017-08-24 10:57 ` Simon Horman 2017-08-24 10:57 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdU5Vep+m7XtjcbSvyXUzD_Pn2crcQ68VRmS4bgY44ut0w@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=jacopo@jmondi.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.