From: Geert Uytterhoeven <geert@linux-m68k.org> To: Kieran Bingham <kieran@ksquared.org.uk> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, linux-renesas-soc@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage Date: Sat, 28 May 2016 21:03:55 +0200 [thread overview] Message-ID: <CAMuHMdUvRN2ysYJ9g0daOD8sD7O5XcrZkKbWr0X_L7mG25Ocww@mail.gmail.com> (raw) In-Reply-To: <1464369565-12259-5-git-send-email-kieran@bingham.xyz> Hi Kieran, On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kieran@ksquared.org.uk> wrote: > The example misses the power-domains usage, and documentation that the > property is used by the node. > > Signed-off-by: Kieran Bingham <kieran@bingham.xyz> Thanks for your patch! > --- > Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt > index 1c0718b501ef..464bb7ae4b92 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt > @@ -21,6 +21,8 @@ are paired with. These DT bindings currently support the FCPV and FCPF. > > - reg: the register base and size for the device registers > - clocks: Reference to the functional clock > + - power-domains : power-domain property defined with a phandle > + to respective power domain. I'd write "power domain specifier" instead of "phandle". While SYSC on R-Car Gen3 uses #power-domain-cells = 0, the FCP module may show up on another SoC that uses a different value, needing more than just a phandle. In fact I'm inclined to leave out the power-domains property completely: it's not a feature of the FCP, but of the SoC the FCP is part of. power-domains properties may appear in any device node where needed. > Device node example > @@ -30,4 +32,5 @@ Device node example > compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; > clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A7795_PD_A3VP>; Adding it to the example doesn't hurt, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> To: Kieran Bingham <kieran-7hKh/agyDeatmTQ+vhA3Yw@public.gmane.org> Cc: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Media Mailing List <linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage Date: Sat, 28 May 2016 21:03:55 +0200 [thread overview] Message-ID: <CAMuHMdUvRN2ysYJ9g0daOD8sD7O5XcrZkKbWr0X_L7mG25Ocww@mail.gmail.com> (raw) In-Reply-To: <1464369565-12259-5-git-send-email-kieran-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org> Hi Kieran, On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kieran-7hKh/agyDeatmTQ+vhA3Yw@public.gmane.org> wrote: > The example misses the power-domains usage, and documentation that the > property is used by the node. > > Signed-off-by: Kieran Bingham <kieran-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org> Thanks for your patch! > --- > Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt > index 1c0718b501ef..464bb7ae4b92 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt > @@ -21,6 +21,8 @@ are paired with. These DT bindings currently support the FCPV and FCPF. > > - reg: the register base and size for the device registers > - clocks: Reference to the functional clock > + - power-domains : power-domain property defined with a phandle > + to respective power domain. I'd write "power domain specifier" instead of "phandle". While SYSC on R-Car Gen3 uses #power-domain-cells = 0, the FCP module may show up on another SoC that uses a different value, needing more than just a phandle. In fact I'm inclined to leave out the power-domains property completely: it's not a feature of the FCP, but of the SoC the FCP is part of. power-domains properties may appear in any device node where needed. > Device node example > @@ -30,4 +32,5 @@ Device node example > compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; > clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A7795_PD_A3VP>; Adding it to the example doesn't hurt, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-28 19:03 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-27 17:19 [PATCH 0/4] RCar r8a7795 FCPF support Kieran Bingham 2016-05-27 17:19 ` Kieran Bingham 2016-05-27 17:19 ` [PATCH 1/4] fcp: Extend FCP compatible list to support the FDP Kieran Bingham 2016-05-27 17:19 ` Kieran Bingham 2016-05-27 17:21 ` Kieran Bingham 2016-05-27 17:21 ` Kieran Bingham 2016-05-27 17:19 ` [PATCH 1/4] v4l: " Kieran Bingham 2016-05-27 17:19 ` Kieran Bingham 2016-05-27 17:19 ` Kieran Bingham 2016-05-27 17:19 ` [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham 2016-05-27 17:19 ` Kieran Bingham 2016-05-28 19:06 ` Geert Uytterhoeven 2016-05-28 19:06 ` Geert Uytterhoeven 2016-05-30 10:04 ` Kieran Bingham 2016-05-30 10:04 ` Kieran Bingham 2016-05-27 17:19 ` [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham 2016-05-27 17:19 ` Kieran Bingham 2016-05-28 19:03 ` Geert Uytterhoeven [this message] 2016-05-28 19:03 ` Geert Uytterhoeven 2016-05-30 10:09 ` Kieran Bingham 2016-05-30 10:09 ` Kieran Bingham 2016-05-27 17:19 ` [PATCH 4/4] arm64: dts: r8a7795: add FCPF device nodes Kieran Bingham 2016-05-27 17:19 ` Kieran Bingham 2016-05-31 9:10 ` [PATCH 0/4] RCar r8a7795 FCPF support Geert Uytterhoeven 2016-05-31 9:10 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdUvRN2ysYJ9g0daOD8sD7O5XcrZkKbWr0X_L7mG25Ocww@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=kieran@ksquared.org.uk \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.