From: Geert Uytterhoeven <geert@linux-m68k.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: "Tomer Maimon" <tmaimon77@gmail.com>, "Avi Fishman" <avifishman70@gmail.com>, "Tali Perry" <tali.perry1@gmail.com>, "Joel Stanley" <joel@jms.id.au>, "Patrick Venture" <venture@google.com>, "Nancy Yuen" <yuenn@google.com>, "Benjamin Fair" <benjaminfair@google.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Michael Turquette" <mturquette@baylibre.com>, "Stephen Boyd" <sboyd@kernel.org>, "Philipp Zabel" <p.zabel@pengutronix.de>, "Greg KH" <gregkh@linuxfoundation.org>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Guenter Roeck" <linux@roeck-us.net>, "Catalin Marinas" <catalin.marinas@arm.com>, "Will Deacon" <will@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>, "Olof Johansson" <olof@lixom.net>, "Jiri Slaby" <jirislaby@kernel.org>, "Shawn Guo" <shawnguo@kernel.org>, "Björn Andersson" <bjorn.andersson@linaro.org>, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Marcel Ziswiler" <marcel.ziswiler@toradex.com>, Vinod <vkoul@kernel.org>, "Biju Das" <biju.das.jz@bp.renesas.com>, "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>, "Robert Hancock" <robert.hancock@calian.com>, "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, "Lubomir Rintel" <lkundrak@v3.sk>, arm-soc <soc@kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, "Linux Watchdog Mailing List" <linux-watchdog@vger.kernel.org>, "Linux ARM" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v1 17/19] arm64: dts: nuvoton: Add initial NPCM8XX device tree Date: Mon, 23 May 2022 15:58:31 +0200 [thread overview] Message-ID: <CAMuHMdWSccO3J5OYrFUn+azKyzYBP1wmuHZoRU2t3PUbkZx1wA@mail.gmail.com> (raw) In-Reply-To: <c1b86493-d82d-a639-07af-4c979d733786@linaro.org> Hi Krzysztof, On Mon, May 23, 2022 at 11:08 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 22/05/2022 17:50, Tomer Maimon wrote: > > This adds initial device tree support for the > > Nuvoton NPCM845 Board Management controller (BMC) SoC family. > > Thank you for your patch. There is something to discuss/improve. > > > The NPCM845 based quad-core Cortex-A35 ARMv8 architecture and > > have various peripheral IPs. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > + l2: l2-cache { > > + compatible = "cache"; > > Is this a real compatible? What bindings are you using here? The compatible value and related properties are defined in the Devicetree Specification, v0.4-rc1, Section 3.9 ("Multi-level and Shared Cache Nodes (/cpus/cpu*/l?-cache)"). The properties are handled by dtschema/schemas/cache-controller.yaml, but the latter seems to lack any checking on the compatible value? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: "Tomer Maimon" <tmaimon77@gmail.com>, "Avi Fishman" <avifishman70@gmail.com>, "Tali Perry" <tali.perry1@gmail.com>, "Joel Stanley" <joel@jms.id.au>, "Patrick Venture" <venture@google.com>, "Nancy Yuen" <yuenn@google.com>, "Benjamin Fair" <benjaminfair@google.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Michael Turquette" <mturquette@baylibre.com>, "Stephen Boyd" <sboyd@kernel.org>, "Philipp Zabel" <p.zabel@pengutronix.de>, "Greg KH" <gregkh@linuxfoundation.org>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Guenter Roeck" <linux@roeck-us.net>, "Catalin Marinas" <catalin.marinas@arm.com>, "Will Deacon" <will@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>, "Olof Johansson" <olof@lixom.net>, "Jiri Slaby" <jirislaby@kernel.org>, "Shawn Guo" <shawnguo@kernel.org>, "Björn Andersson" <bjorn.andersson@linaro.org>, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Marcel Ziswiler" <marcel.ziswiler@toradex.com>, Vinod <vkoul@kernel.org>, "Biju Das" <biju.das.jz@bp.renesas.com>, "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>, "Robert Hancock" <robert.hancock@calian.com>, "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, "Lubomir Rintel" <lkundrak@v3.sk>, arm-soc <soc@kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, "Linux Watchdog Mailing List" <linux-watchdog@vger.kernel.org>, "Linux ARM" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v1 17/19] arm64: dts: nuvoton: Add initial NPCM8XX device tree Date: Mon, 23 May 2022 15:58:31 +0200 [thread overview] Message-ID: <CAMuHMdWSccO3J5OYrFUn+azKyzYBP1wmuHZoRU2t3PUbkZx1wA@mail.gmail.com> (raw) In-Reply-To: <c1b86493-d82d-a639-07af-4c979d733786@linaro.org> Hi Krzysztof, On Mon, May 23, 2022 at 11:08 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 22/05/2022 17:50, Tomer Maimon wrote: > > This adds initial device tree support for the > > Nuvoton NPCM845 Board Management controller (BMC) SoC family. > > Thank you for your patch. There is something to discuss/improve. > > > The NPCM845 based quad-core Cortex-A35 ARMv8 architecture and > > have various peripheral IPs. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > + l2: l2-cache { > > + compatible = "cache"; > > Is this a real compatible? What bindings are you using here? The compatible value and related properties are defined in the Devicetree Specification, v0.4-rc1, Section 3.9 ("Multi-level and Shared Cache Nodes (/cpus/cpu*/l?-cache)"). The properties are handled by dtschema/schemas/cache-controller.yaml, but the latter seems to lack any checking on the compatible value? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-23 13:59 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-22 15:50 [PATCH v1 00/19] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 01/19] dt-bindings: timer: npcm: Add npcm845 compatible string Tomer Maimon 2022-05-23 7:31 ` Krzysztof Kozlowski 2022-05-23 7:31 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 02/19] clocksource: timer-npcm7xx: Add NPCM845 timer support Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 03/19] dt-bindings: serial: 8250: Add npcm845 compatible string Tomer Maimon 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support Tomer Maimon 2022-05-23 9:56 ` Arnd Bergmann 2022-05-23 9:56 ` Arnd Bergmann 2022-05-23 12:58 ` Tomer Maimon 2022-05-23 13:06 ` Krzysztof Kozlowski 2022-05-23 13:06 ` Krzysztof Kozlowski 2022-05-23 13:14 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 05/19] dt-bindings: watchdog: npcm: Add npcm845 compatible string Tomer Maimon 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 06/19] watchdog: npcm_wdt: Add NPCM845 watchdog support Tomer Maimon 2022-05-22 16:45 ` Guenter Roeck 2022-05-22 16:45 ` Guenter Roeck 2022-05-22 15:50 ` [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Tomer Maimon 2022-05-23 7:35 ` Krzysztof Kozlowski 2022-05-23 7:35 ` Krzysztof Kozlowski 2022-05-23 13:35 ` Tomer Maimon 2022-05-26 19:24 ` Stephen Boyd 2022-05-26 19:24 ` Stephen Boyd 2022-05-30 14:39 ` Tomer Maimon 2022-05-30 14:39 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 08/19] clk: npcm8xx: add clock controller Tomer Maimon 2022-05-23 7:07 ` Ilpo Järvinen 2022-05-23 7:07 ` Ilpo Järvinen 2022-05-23 12:48 ` Tomer Maimon 2022-05-26 19:36 ` Stephen Boyd 2022-05-26 19:36 ` Stephen Boyd 2022-05-30 14:36 ` Tomer Maimon 2022-05-30 14:36 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 09/19] dt-bindings: reset: add syscon property Tomer Maimon 2022-05-23 7:39 ` Krzysztof Kozlowski 2022-05-23 7:39 ` Krzysztof Kozlowski 2022-05-23 13:44 ` Tomer Maimon 2022-05-23 13:45 ` Krzysztof Kozlowski 2022-05-23 13:45 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 10/19] reset: npcm: using syscon instead of device data Tomer Maimon 2022-05-23 8:54 ` Krzysztof Kozlowski 2022-05-23 8:54 ` Krzysztof Kozlowski 2022-05-23 13:53 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 11/19] dt-bindings: reset: npcm: Add support for NPCM8XX Tomer Maimon 2022-05-23 9:01 ` Krzysztof Kozlowski 2022-05-23 9:01 ` Krzysztof Kozlowski 2022-05-23 14:03 ` Tomer Maimon 2022-05-23 14:22 ` Geert Uytterhoeven 2022-05-23 14:22 ` Geert Uytterhoeven 2022-05-23 14:26 ` Krzysztof Kozlowski 2022-05-23 14:26 ` Krzysztof Kozlowski 2022-05-23 15:11 ` Geert Uytterhoeven 2022-05-23 15:11 ` Geert Uytterhoeven 2022-05-23 15:22 ` Krzysztof Kozlowski 2022-05-23 15:22 ` Krzysztof Kozlowski 2022-05-23 15:24 ` Krzysztof Kozlowski 2022-05-23 15:24 ` Krzysztof Kozlowski 2022-05-24 7:26 ` Tomer Maimon 2022-05-24 7:26 ` Tomer Maimon 2022-05-23 14:23 ` Krzysztof Kozlowski 2022-05-23 14:23 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 12/19] reset: npcm: Add NPCM8XX support Tomer Maimon 2022-05-23 10:44 ` Arnd Bergmann 2022-05-23 10:44 ` Arnd Bergmann 2022-05-22 15:50 ` [PATCH v1 13/19] dt-bindings: arm: npcm: Add maintainer Tomer Maimon 2022-06-02 12:58 ` Rob Herring 2022-06-02 12:58 ` Rob Herring 2022-05-22 15:50 ` [PATCH v1 14/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 compatible string Tomer Maimon 2022-05-23 9:02 ` Krzysztof Kozlowski 2022-05-23 9:02 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 GCR " Tomer Maimon 2022-05-23 9:02 ` Krzysztof Kozlowski 2022-05-23 9:02 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton, npcm845 " Krzysztof Kozlowski 2022-05-23 9:02 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 " Krzysztof Kozlowski 2022-05-23 9:02 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton, npcm845 " Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 16/19] arm64: npcm: Add support for Nuvoton NPCM8XX BMC SoC Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 17/19] arm64: dts: nuvoton: Add initial NPCM8XX device tree Tomer Maimon 2022-05-23 9:08 ` Krzysztof Kozlowski 2022-05-23 9:08 ` Krzysztof Kozlowski 2022-05-23 13:58 ` Geert Uytterhoeven [this message] 2022-05-23 13:58 ` Geert Uytterhoeven 2022-05-23 14:16 ` Krzysztof Kozlowski 2022-05-23 14:16 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 18/19] arm64: dts: nuvoton: Add initial NPCM845 EVB " Tomer Maimon 2022-05-23 9:26 ` Krzysztof Kozlowski 2022-05-23 9:26 ` Krzysztof Kozlowski 2022-05-23 9:39 ` Arnd Bergmann 2022-05-23 9:39 ` Arnd Bergmann 2022-05-23 14:17 ` Tomer Maimon 2022-05-23 15:37 ` Krzysztof Kozlowski 2022-05-23 15:37 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 19/19] arm64: defconfig: Add Nuvoton NPCM family support Tomer Maimon 2022-05-23 9:52 ` [PATCH v1 00/19] Introduce Nuvoton Arbel NPCM8XX BMC SoC Arnd Bergmann 2022-05-23 9:52 ` Arnd Bergmann 2022-05-23 12:20 ` Tomer Maimon 2022-05-30 12:24 ` Andy Shevchenko 2022-05-30 12:24 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdWSccO3J5OYrFUn+azKyzYBP1wmuHZoRU2t3PUbkZx1wA@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=gregkh@linuxfoundation.org \ --cc=j.neuschaefer@gmx.net \ --cc=jirislaby@kernel.org \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lkundrak@v3.sk \ --cc=marcel.ziswiler@toradex.com \ --cc=mturquette@baylibre.com \ --cc=nobuhiro1.iwamatsu@toshiba.co.jp \ --cc=olof@lixom.net \ --cc=p.zabel@pengutronix.de \ --cc=robert.hancock@calian.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=soc@kernel.org \ --cc=tali.perry1@gmail.com \ --cc=tglx@linutronix.de \ --cc=tmaimon77@gmail.com \ --cc=venture@google.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ --cc=wim@linux-watchdog.org \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.