From: Geert Uytterhoeven <geert@linux-m68k.org> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Rob Herring <robh+dt@kernel.org>, Laurent <laurent.pinchart@ideasonboard.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Magnus <magnus.damm@gmail.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux-DT <devicetree@vger.kernel.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, shimoda <yoshihiro.shimoda.uh@renesas.com>, DRI Development <dri-devel@lists.freedesktop.org> Subject: Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes Date: Thu, 10 Sep 2020 11:33:37 +0200 [thread overview] Message-ID: <CAMuHMdWaH7eTFTxPUR6qmxV1m=GK_LW7o=ct7x+yE2UQJDy2ig@mail.gmail.com> (raw) In-Reply-To: <87h7s9rtvl.wl-kuninori.morimoto.gx@renesas.com> Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:34 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2004,6 +2004,58 @@ pciec1: pcie@ee800000 { > status = "disabled"; > }; > > + fcpf0: fcp@fe950000 { > + compatible = "renesas,fcpf"; > + reg = <0 0xfe950000 0 0x200>; > + clocks = <&cpg CPG_MOD 615>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 615>; Missing "iommus = <&ipmmu_vc0 16>;" > + }; > + > + fcpvb0: fcp@fe96f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfe96f000 0 0x200>; > + clocks = <&cpg CPG_MOD 607>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 607>; Missing "iommus = <&ipmmu_vi0 5>;" > + }; The rest looks good to me, so with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Linux-DT <devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>, shimoda <yoshihiro.shimoda.uh@renesas.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Magnus <magnus.damm@gmail.com>, DRI Development <dri-devel@lists.freedesktop.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Laurent <laurent.pinchart@ideasonboard.com> Subject: Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes Date: Thu, 10 Sep 2020 11:33:37 +0200 [thread overview] Message-ID: <CAMuHMdWaH7eTFTxPUR6qmxV1m=GK_LW7o=ct7x+yE2UQJDy2ig@mail.gmail.com> (raw) In-Reply-To: <87h7s9rtvl.wl-kuninori.morimoto.gx@renesas.com> Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:34 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2004,6 +2004,58 @@ pciec1: pcie@ee800000 { > status = "disabled"; > }; > > + fcpf0: fcp@fe950000 { > + compatible = "renesas,fcpf"; > + reg = <0 0xfe950000 0 0x200>; > + clocks = <&cpg CPG_MOD 615>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 615>; Missing "iommus = <&ipmmu_vc0 16>;" > + }; > + > + fcpvb0: fcp@fe96f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfe96f000 0 0x200>; > + clocks = <&cpg CPG_MOD 607>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 607>; Missing "iommus = <&ipmmu_vi0 5>;" > + }; The rest looks good to me, so with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-10 9:34 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-08 0:33 [PATCH v2 00/10] arm64: renesas: enable HDMI Display/Sound on R-Car M3-W+ Salvator-XS Kuninori Morimoto 2020-09-08 0:33 ` Kuninori Morimoto 2020-09-08 0:34 ` [PATCH v2 01/10] dt-bindings: display: renesas: du: Document the r8a77961 bindings Kuninori Morimoto 2020-09-08 0:34 ` Kuninori Morimoto 2020-09-08 5:53 ` Laurent Pinchart 2020-09-08 5:53 ` Laurent Pinchart 2020-09-08 12:52 ` Kieran Bingham 2020-09-08 12:52 ` Kieran Bingham 2020-09-15 16:34 ` Rob Herring 2020-09-15 16:34 ` Rob Herring 2020-09-08 0:34 ` [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible Kuninori Morimoto 2020-09-08 0:34 ` Kuninori Morimoto 2020-09-08 5:54 ` Laurent Pinchart 2020-09-08 5:54 ` Laurent Pinchart 2020-09-08 14:18 ` Kieran Bingham 2020-09-08 14:18 ` Kieran Bingham 2020-09-08 14:43 ` Laurent Pinchart 2020-09-08 14:43 ` Laurent Pinchart 2020-09-08 14:46 ` Laurent Pinchart 2020-09-08 14:46 ` Laurent Pinchart 2020-09-08 14:48 ` Kieran Bingham 2020-09-08 14:48 ` Kieran Bingham 2020-09-09 23:20 ` Kuninori Morimoto 2020-09-09 23:20 ` Kuninori Morimoto 2020-09-08 0:34 ` [PATCH v2 03/10] dt-bindings: display: renesas: dw-hdmi: Add R8A77961 support Kuninori Morimoto 2020-09-08 0:34 ` Kuninori Morimoto 2020-09-08 5:55 ` Laurent Pinchart 2020-09-08 5:55 ` Laurent Pinchart 2020-09-08 14:35 ` Kieran Bingham 2020-09-08 14:35 ` Kieran Bingham 2020-09-15 16:35 ` Rob Herring 2020-09-15 16:35 ` Rob Herring 2020-09-08 0:34 ` [PATCH v2 04/10] drm: rcar-du: Add r8a77961 support Kuninori Morimoto 2020-09-08 0:34 ` Kuninori Morimoto 2020-09-08 5:56 ` Laurent Pinchart 2020-09-08 5:56 ` Laurent Pinchart 2020-09-08 14:49 ` Kieran Bingham 2020-09-08 14:49 ` Kieran Bingham 2020-09-08 0:34 ` [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes Kuninori Morimoto 2020-09-08 0:34 ` Kuninori Morimoto 2020-09-08 5:58 ` Laurent Pinchart 2020-09-08 5:58 ` Laurent Pinchart 2020-09-08 14:50 ` Kieran Bingham 2020-09-08 14:50 ` Kieran Bingham 2020-09-10 9:33 ` Geert Uytterhoeven [this message] 2020-09-10 9:33 ` Geert Uytterhoeven 2020-09-10 23:24 ` Kuninori Morimoto 2020-09-10 23:24 ` Kuninori Morimoto 2020-09-08 0:34 ` [PATCH v2 06/10] arm64: dts: renesas: r8a77961: Add VSP " Kuninori Morimoto 2020-09-08 0:34 ` Kuninori Morimoto 2020-09-08 6:01 ` Laurent Pinchart 2020-09-08 6:01 ` Laurent Pinchart 2020-09-08 14:56 ` Kieran Bingham 2020-09-08 14:56 ` Kieran Bingham 2020-09-08 0:35 ` [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU " Kuninori Morimoto 2020-09-08 0:35 ` Kuninori Morimoto 2020-09-08 6:02 ` Laurent Pinchart 2020-09-08 6:02 ` Laurent Pinchart 2020-09-08 15:11 ` Kieran Bingham 2020-09-08 15:11 ` Kieran Bingham 2020-09-10 9:49 ` Geert Uytterhoeven 2020-09-10 9:49 ` Geert Uytterhoeven 2020-09-10 9:50 ` Geert Uytterhoeven 2020-09-10 9:50 ` Geert Uytterhoeven 2020-09-10 23:20 ` Kuninori Morimoto 2020-09-10 23:20 ` Kuninori Morimoto 2020-09-10 23:22 ` Laurent Pinchart 2020-09-10 23:22 ` Laurent Pinchart 2020-09-08 0:35 ` [PATCH v2 08/10] arm64: dts: renesas: r8a77961: Add HDMI " Kuninori Morimoto 2020-09-08 0:35 ` Kuninori Morimoto 2020-09-08 6:03 ` Laurent Pinchart 2020-09-08 6:03 ` Laurent Pinchart 2020-09-10 9:52 ` Geert Uytterhoeven 2020-09-10 9:52 ` Geert Uytterhoeven 2020-09-08 0:35 ` [PATCH v2 09/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Display support Kuninori Morimoto 2020-09-08 0:35 ` Kuninori Morimoto 2020-09-08 6:04 ` Laurent Pinchart 2020-09-08 6:04 ` Laurent Pinchart 2020-09-10 9:56 ` Geert Uytterhoeven 2020-09-10 9:56 ` Geert Uytterhoeven 2020-09-08 0:35 ` [PATCH v2 10/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Sound support Kuninori Morimoto 2020-09-08 0:35 ` Kuninori Morimoto 2020-09-08 6:06 ` Laurent Pinchart 2020-09-08 6:06 ` Laurent Pinchart 2020-09-08 6:33 ` Kuninori Morimoto 2020-09-08 6:33 ` Kuninori Morimoto 2020-09-08 6:37 ` Laurent Pinchart 2020-09-08 6:37 ` Laurent Pinchart 2020-09-08 6:43 ` Kuninori Morimoto 2020-09-08 6:43 ` Kuninori Morimoto 2020-09-11 7:54 ` Geert Uytterhoeven 2020-09-11 7:54 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdWaH7eTFTxPUR6qmxV1m=GK_LW7o=ct7x+yE2UQJDy2ig@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=robh+dt@kernel.org \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.