All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Anup Patel <anup@brainfault.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Anup Patel <anup.patel@wdc.com>,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>, DTML <devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts
Date: Wed, 26 Jan 2022 21:06:44 +0100	[thread overview]
Message-ID: <CAMuHMdXuM4wJKC7TgNd7VbZJ1xM0xBgB4os6S0WXpJUdsmxK4A@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq++-Sp45vna5-WhPsnrxp1_J1krrBUPgd2y3xkp5=sTSw@mail.gmail.com>

Hi Rob,

On Wed, Jan 26, 2022 at 8:37 PM Rob Herring <robh+dt@kernel.org> wrote:
> On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote:
> > On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > The number of interrupts lacks an upper bound, thus assuming one,
> > > causing properly grouped "interrupts-extended" properties to be flagged
> > > as an error by "make dtbs_check".
> > >
> > > Fix this by adding the missing "maxItems".  As the architectural maximum
> > > is 4095 interrupts, using that as the limit would be unpractical.  Hence
> > > limit it to 10 interrupts (two interrupts for a system management core,
> > > and two interrupts per core for other cores).  This should be sufficient
> > > for now, and the limit can always be increased when the need arises.
> >
> > Same comment as the PLIC DT binding patch.
> >
> > The "maxItems" should represent CLINT spec constraints so
> > please don't add any synthetic value here.
>
> I agree.
>
> Geert, are you going to respin these?

Sure, will do, now we have an agreement.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Anup Patel <anup@brainfault.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	Anup Patel <anup.patel@wdc.com>,
	 "linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>, DTML <devicetree@vger.kernel.org>,
	 linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts
Date: Wed, 26 Jan 2022 21:06:44 +0100	[thread overview]
Message-ID: <CAMuHMdXuM4wJKC7TgNd7VbZJ1xM0xBgB4os6S0WXpJUdsmxK4A@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq++-Sp45vna5-WhPsnrxp1_J1krrBUPgd2y3xkp5=sTSw@mail.gmail.com>

Hi Rob,

On Wed, Jan 26, 2022 at 8:37 PM Rob Herring <robh+dt@kernel.org> wrote:
> On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote:
> > On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > The number of interrupts lacks an upper bound, thus assuming one,
> > > causing properly grouped "interrupts-extended" properties to be flagged
> > > as an error by "make dtbs_check".
> > >
> > > Fix this by adding the missing "maxItems".  As the architectural maximum
> > > is 4095 interrupts, using that as the limit would be unpractical.  Hence
> > > limit it to 10 interrupts (two interrupts for a system management core,
> > > and two interrupts per core for other cores).  This should be sufficient
> > > for now, and the limit can always be increased when the need arises.
> >
> > Same comment as the PLIC DT binding patch.
> >
> > The "maxItems" should represent CLINT spec constraints so
> > please don't add any synthetic value here.
>
> I agree.
>
> Geert, are you going to respin these?

Sure, will do, now we have an agreement.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-01-26 20:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 12:38 [PATCH v3 0/2] dt-bindings: timer: sifive,clint: Miscellaneous improvements Geert Uytterhoeven
2021-12-17 12:38 ` [PATCH v3 0/2] dt-bindings: timer: sifive, clint: " Geert Uytterhoeven
2021-12-17 12:38 ` [PATCH v3 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts Geert Uytterhoeven
2021-12-17 12:38   ` [PATCH v3 1/2] dt-bindings: timer: sifive, clint: " Geert Uytterhoeven
2021-12-17 12:48   ` [PATCH v3 1/2] dt-bindings: timer: sifive,clint: " Anup Patel
2021-12-17 12:48     ` [PATCH v3 1/2] dt-bindings: timer: sifive, clint: " Anup Patel
2022-01-26 19:36     ` [PATCH v3 1/2] dt-bindings: timer: sifive,clint: " Rob Herring
2022-01-26 19:36       ` [PATCH v3 1/2] dt-bindings: timer: sifive, clint: " Rob Herring
2022-01-26 20:06       ` Geert Uytterhoeven [this message]
2022-01-26 20:06         ` Geert Uytterhoeven
2021-12-17 12:38 ` [PATCH v3 2/2] dt-bindings: timer: sifive,clint: Group interrupt tuples Geert Uytterhoeven
2021-12-17 12:38   ` [PATCH v3 2/2] dt-bindings: timer: sifive, clint: " Geert Uytterhoeven
2021-12-21 14:56   ` [PATCH v3 2/2] dt-bindings: timer: sifive,clint: " Rob Herring
2021-12-21 14:56     ` [PATCH v3 2/2] dt-bindings: timer: sifive, clint: " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdXuM4wJKC7TgNd7VbZJ1xM0xBgB4os6S0WXpJUdsmxK4A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=anup.patel@wdc.com \
    --cc=anup@brainfault.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.