From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>, Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Arnd Bergmann <arnd@kernel.org>, Anshuman Khandual <anshuman.khandual@arm.com>, Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>, Mark Rutland <mark.rutland@arm.com>, David Brazdil <dbrazdil@google.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Date: Mon, 1 Nov 2021 09:32:29 -0600 [thread overview] Message-ID: <CANLsYkyQssRivPCPJQf11UeUwp089byhpB1MvoGy50r3Yz+ULQ@mail.gmail.com> (raw) In-Reply-To: <YX/LymZ5ZwNbtjUp@kroah.com> On Mon, 1 Nov 2021 at 05:13, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Nov 01, 2021 at 09:52:22AM +0000, Suzuki K Poulose wrote: > > On 01/11/2021 09:40, Will Deacon wrote: > > > On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > > > > On 01/11/2021 09:01, Will Deacon wrote: > > > > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > > > > From: Arnd Bergmann <arnd@arndb.de> > > > > > > > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > > > > > > > Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > > > > > > Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > > > > > > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > > > > it could go via the arm64 tree. > > > > > > > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > > > > merging window, though he could take it as a fix afterwards. > > > > > > > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > > > > go through the coresight tree. > > > > > > > > > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > > > > > --- > > > > > > > > Not sure if we actually want this to be exported, this is my local > > > > > > > > workaround for the randconfig build bot. > > > > > > > > --- > > > > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > > > > return false; > > > > > > > > } > > > > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > > > > specialised than cpus_have_const_cap(). > > > > > > > > > > > > With that: > > > > > > > > > > > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> > > > > > > > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > > > > So with the _GPL export: > > > > > > > > > > Acked-by: Will Deacon <will@kernel.org> > > > > > > > > > > If that doesn't work for some reason, I can take it next week after the > > > > > initial arm64 queue has been merged. Please just let me know. > > > > > > > > As I understand correctly, this will now need to go via arm64 tree. The > > > > CoreSight tree changes are pulled into Greg's tree and the next it will > > > > happen is for the next release. Usually the fixes don't end up there > > > > during the -rc cycles. So, I believe it is better if this goes via > > > > arm64. > > > > > > Hmm, are you saying that Coresight drivers don't receive fixes outside of > > > the merge window? That sounds sub-optimal... > > > > Unfortunately thats how it works today. We should fix this. > > > > Mathieu, Greg, > > > > Do you have any thoughts on how to address this ? > > What? That's crazy, if there are bugfixes needed of course I would take > them during the -rc cycle, that is explicitly what it is there for! I have sent patches to the char-misc tree several times during -rc cycles. As Greg points out, proceeding otherwise would not make sense. > > It's up to the maintainer of the subsystem to send me the fixes to get > into the -final kernel release, I don't pick them up on my own unless > asked to by them. > I will send a pull request for this when I receive another patch with Catalin's annotation and collected RB tags. > thanks, > > greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>, Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Arnd Bergmann <arnd@kernel.org>, Anshuman Khandual <anshuman.khandual@arm.com>, Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>, Mark Rutland <mark.rutland@arm.com>, David Brazdil <dbrazdil@google.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Date: Mon, 1 Nov 2021 09:32:29 -0600 [thread overview] Message-ID: <CANLsYkyQssRivPCPJQf11UeUwp089byhpB1MvoGy50r3Yz+ULQ@mail.gmail.com> (raw) In-Reply-To: <YX/LymZ5ZwNbtjUp@kroah.com> On Mon, 1 Nov 2021 at 05:13, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Nov 01, 2021 at 09:52:22AM +0000, Suzuki K Poulose wrote: > > On 01/11/2021 09:40, Will Deacon wrote: > > > On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > > > > On 01/11/2021 09:01, Will Deacon wrote: > > > > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > > > > From: Arnd Bergmann <arnd@arndb.de> > > > > > > > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > > > > > > > Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > > > > > > Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > > > > > > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > > > > it could go via the arm64 tree. > > > > > > > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > > > > merging window, though he could take it as a fix afterwards. > > > > > > > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > > > > go through the coresight tree. > > > > > > > > > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > > > > > --- > > > > > > > > Not sure if we actually want this to be exported, this is my local > > > > > > > > workaround for the randconfig build bot. > > > > > > > > --- > > > > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > > > > return false; > > > > > > > > } > > > > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > > > > specialised than cpus_have_const_cap(). > > > > > > > > > > > > With that: > > > > > > > > > > > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> > > > > > > > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > > > > So with the _GPL export: > > > > > > > > > > Acked-by: Will Deacon <will@kernel.org> > > > > > > > > > > If that doesn't work for some reason, I can take it next week after the > > > > > initial arm64 queue has been merged. Please just let me know. > > > > > > > > As I understand correctly, this will now need to go via arm64 tree. The > > > > CoreSight tree changes are pulled into Greg's tree and the next it will > > > > happen is for the next release. Usually the fixes don't end up there > > > > during the -rc cycles. So, I believe it is better if this goes via > > > > arm64. > > > > > > Hmm, are you saying that Coresight drivers don't receive fixes outside of > > > the merge window? That sounds sub-optimal... > > > > Unfortunately thats how it works today. We should fix this. > > > > Mathieu, Greg, > > > > Do you have any thoughts on how to address this ? > > What? That's crazy, if there are bugfixes needed of course I would take > them during the -rc cycle, that is explicitly what it is there for! I have sent patches to the char-misc tree several times during -rc cycles. As Greg points out, proceeding otherwise would not make sense. > > It's up to the maintainer of the subsystem to send me the fixes to get > into the -final kernel release, I don't pick them up on my own unless > asked to by them. > I will send a pull request for this when I receive another patch with Catalin's annotation and collected RB tags. > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-01 15:32 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-29 11:30 [PATCH] [RFC] arm64: export this_cpu_has_cap Arnd Bergmann 2021-10-29 11:30 ` Arnd Bergmann 2021-10-29 13:31 ` Suzuki K Poulose 2021-10-29 13:31 ` Suzuki K Poulose 2021-10-29 15:12 ` Mathieu Poirier 2021-10-29 15:12 ` Mathieu Poirier 2021-10-29 18:06 ` Catalin Marinas 2021-10-29 18:06 ` Catalin Marinas 2021-11-01 9:01 ` Will Deacon 2021-11-01 9:01 ` Will Deacon 2021-11-01 9:34 ` Suzuki K Poulose 2021-11-01 9:34 ` Suzuki K Poulose 2021-11-01 9:40 ` Will Deacon 2021-11-01 9:40 ` Will Deacon 2021-11-01 9:52 ` Suzuki K Poulose 2021-11-01 9:52 ` Suzuki K Poulose 2021-11-01 11:13 ` Greg Kroah-Hartman 2021-11-01 11:13 ` Greg Kroah-Hartman 2021-11-01 15:32 ` Mathieu Poirier [this message] 2021-11-01 15:32 ` Mathieu Poirier 2021-11-02 23:16 ` Suzuki K Poulose 2021-11-02 23:16 ` Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANLsYkyQssRivPCPJQf11UeUwp089byhpB1MvoGy50r3Yz+ULQ@mail.gmail.com \ --to=mathieu.poirier@linaro.org \ --cc=anshuman.khandual@arm.com \ --cc=arnd@arndb.de \ --cc=arnd@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=dbrazdil@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.