All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0
@ 2018-02-15 20:45 Jared Bents
  2018-02-15 20:45 ` [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990 Jared Bents
  2018-02-15 21:53 ` [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Matthew Weber
  0 siblings, 2 replies; 11+ messages in thread
From: Jared Bents @ 2018-02-15 20:45 UTC (permalink / raw)
  To: buildroot

Update to use libqmi 1.20.0

Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
---
 package/libqmi/libqmi.hash | 2 +-
 package/libqmi/libqmi.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libqmi/libqmi.hash b/package/libqmi/libqmi.hash
index 1c54231..297e1f0 100644
--- a/package/libqmi/libqmi.hash
+++ b/package/libqmi/libqmi.hash
@@ -1,4 +1,4 @@
 # Locally computed:
-sha256 a0a42c55935e75a630208e2f70840bd4407f56fe1c5258f5b0f6c0aaedf88cec  libqmi-1.18.0.tar.xz
+sha256 21428cd3749c56246565123f707fee51238651a22c60bdc85ebce97388626eb4  libqmi-1.20.0.tar.xz
 sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
index 0887564..a7140dc 100644
--- a/package/libqmi/libqmi.mk
+++ b/package/libqmi/libqmi.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBQMI_VERSION = 1.18.0
+LIBQMI_VERSION = 1.20.0
 LIBQMI_SITE = http://www.freedesktop.org/software/libqmi
 LIBQMI_SOURCE = libqmi-$(LIBQMI_VERSION).tar.xz
 LIBQMI_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990
  2018-02-15 20:45 [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Jared Bents
@ 2018-02-15 20:45 ` Jared Bents
  2018-02-15 21:54   ` Matthew Weber
  2018-02-16  5:18   ` Baruch Siach
  2018-02-15 21:53 ` [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Matthew Weber
  1 sibling, 2 replies; 11+ messages in thread
From: Jared Bents @ 2018-02-15 20:45 UTC (permalink / raw)
  To: buildroot

Update to modem manager 1.7.990 which does not require
udev.  Added option to build without udev but if udev
exists in the build, it will default to build with
libgudev.

Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
---
 package/modem-manager/Config.in          | 12 +++++++++---
 package/modem-manager/modem-manager.hash |  2 +-
 package/modem-manager/modem-manager.mk   | 11 +++++++++--
 3 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index 8e995b4..38e017b 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -1,12 +1,10 @@
 config BR2_PACKAGE_MODEM_MANAGER
 	bool "modemmanager"
-	depends on BR2_PACKAGE_HAS_UDEV
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus
 	select BR2_PACKAGE_DBUS # runtime dependency
 	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_LIBGUDEV
 	help
 	  ModemManager is a DBus-activated daemon which controls mobile
 	  broadband (2G/3G/4G) devices and connections.
@@ -26,9 +24,17 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
 	select BR2_PACKAGE_LIBQMI
 	help
 	  This option enables support for QMI protocol
+
+config BR2_PACKAGE_MODEM_MANAGER_UDEV
+	bool "Use udev"
+	default y if BR2_PACKAGE_HAS_UDEV
+	select BR2_PACKAGE_LIBGUDEV
+	help
+	  This option allows support for builds without udev. If udev
+	  is not included, say N.
 endif
 
-comment "modemmanager needs udev /dev management and a toolchain w/ wchar, threads"
+comment "modemmanager needs /dev management and a toolchain w/ wchar, threads"
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_PACKAGE_HAS_UDEV
 	depends on BR2_USE_MMU
diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
index bc08044..52cc7a6 100644
--- a/package/modem-manager/modem-manager.hash
+++ b/package/modem-manager/modem-manager.hash
@@ -1,4 +1,4 @@
 # Locally computed
-sha256  bc74326fa69ae8012f806e235f3d296144922669b952d4d4987dd0af645d5f68  ModemManager-1.6.10.tar.xz
+sha256  d465094fc6fc173354f5a00d212049056829cc245d60a9083f3c53f86a8f90ec  ModemManager-1.7.990.tar.xz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index b741acf..3015b00 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -4,12 +4,12 @@
 #
 ################################################################################
 
-MODEM_MANAGER_VERSION = 1.6.10
+MODEM_MANAGER_VERSION = 1.7.990
 MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2 libgudev
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
 MODEM_MANAGER_INSTALL_STAGING = YES
 
 ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
@@ -26,6 +26,13 @@ else
 MODEM_MANAGER_CONF_OPTS += --without-mbim
 endif
 
+ifeq ($(BR2_PACKAGE_MODEM_MANAGER_UDEV),y)
+MODEM_MANAGER_DEPENDENCIES += libgudev
+MODEM_MANAGER_CONF_OPTS += --with-udev
+else
+MODEM_MANAGER_CONF_OPTS += --without-udev
+endif
+
 define MODEM_MANAGER_INSTALL_INIT_SYSV
 	$(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager \
 		$(TARGET_DIR)/etc/init.d/S44modem-manager
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0
  2018-02-15 20:45 [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Jared Bents
  2018-02-15 20:45 ` [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990 Jared Bents
@ 2018-02-15 21:53 ` Matthew Weber
  2018-02-15 22:16   ` Jared Bents
  2018-02-16 15:38   ` Matthew Weber
  1 sibling, 2 replies; 11+ messages in thread
From: Matthew Weber @ 2018-02-15 21:53 UTC (permalink / raw)
  To: buildroot

Jared,

On Thu, Feb 15, 2018 at 2:45 PM, Jared Bents
<jared.bents@rockwellcollins.com> wrote:
>
> Update to use libqmi 1.20.0
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> ---
>  package/libqmi/libqmi.hash | 2 +-
>  package/libqmi/libqmi.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/libqmi/libqmi.hash b/package/libqmi/libqmi.hash
> index 1c54231..297e1f0 100644
> --- a/package/libqmi/libqmi.hash
> +++ b/package/libqmi/libqmi.hash
> @@ -1,4 +1,4 @@
>  # Locally computed:
> -sha256 a0a42c55935e75a630208e2f70840bd4407f56fe1c5258f5b0f6c0aaedf88cec  libqmi-1.18.0.tar.xz
> +sha256 21428cd3749c56246565123f707fee51238651a22c60bdc85ebce97388626eb4  libqmi-1.20.0.tar.xz
>  sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>  sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB

Please check that both of these library files didn't change.

Matt

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990
  2018-02-15 20:45 ` [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990 Jared Bents
@ 2018-02-15 21:54   ` Matthew Weber
  2018-02-15 22:19     ` Jared Bents
  2018-02-16  5:18   ` Baruch Siach
  1 sibling, 1 reply; 11+ messages in thread
From: Matthew Weber @ 2018-02-15 21:54 UTC (permalink / raw)
  To: buildroot

Jared,

On Thu, Feb 15, 2018 at 2:45 PM, Jared Bents
<jared.bents@rockwellcollins.com> wrote:
> Update to modem manager 1.7.990 which does not require
> udev.  Added option to build without udev but if udev
> exists in the build, it will default to build with
> libgudev.
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> ---
>  package/modem-manager/Config.in          | 12 +++++++++---
>  package/modem-manager/modem-manager.hash |  2 +-
>  package/modem-manager/modem-manager.mk   | 11 +++++++++--
>  3 files changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index 8e995b4..38e017b 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -1,12 +1,10 @@
>  config BR2_PACKAGE_MODEM_MANAGER
>         bool "modemmanager"
> -       depends on BR2_PACKAGE_HAS_UDEV
>         depends on BR2_USE_WCHAR # libglib2 and gnutls
>         depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>         depends on BR2_USE_MMU # dbus
>         select BR2_PACKAGE_DBUS # runtime dependency
>         select BR2_PACKAGE_LIBGLIB2
> -       select BR2_PACKAGE_LIBGUDEV
>         help
>           ModemManager is a DBus-activated daemon which controls mobile
>           broadband (2G/3G/4G) devices and connections.
> @@ -26,9 +24,17 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
>         select BR2_PACKAGE_LIBQMI
>         help
>           This option enables support for QMI protocol
> +
> +config BR2_PACKAGE_MODEM_MANAGER_UDEV
> +       bool "Use udev"
> +       default y if BR2_PACKAGE_HAS_UDEV
> +       select BR2_PACKAGE_LIBGUDEV
> +       help
> +         This option allows support for builds without udev. If udev
> +         is not included, say N.
>  endif
>
> -comment "modemmanager needs udev /dev management and a toolchain w/ wchar, threads"
> +comment "modemmanager needs /dev management and a toolchain w/ wchar, threads"
>         depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
>                 !BR2_PACKAGE_HAS_UDEV
>         depends on BR2_USE_MMU
> diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> index bc08044..52cc7a6 100644
> --- a/package/modem-manager/modem-manager.hash
> +++ b/package/modem-manager/modem-manager.hash
> @@ -1,4 +1,4 @@
>  # Locally computed
> -sha256  bc74326fa69ae8012f806e235f3d296144922669b952d4d4987dd0af645d5f68  ModemManager-1.6.10.tar.xz
> +sha256  d465094fc6fc173354f5a00d212049056829cc245d60a9083f3c53f86a8f90ec  ModemManager-1.7.990.tar.xz
>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB


Please check these license hash didn't change.

Matt

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0
  2018-02-15 21:53 ` [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Matthew Weber
@ 2018-02-15 22:16   ` Jared Bents
  2018-02-16 15:38   ` Matthew Weber
  1 sibling, 0 replies; 11+ messages in thread
From: Jared Bents @ 2018-02-15 22:16 UTC (permalink / raw)
  To: buildroot

Matt,

I have verified the sha256 for both library files did not change

Jared

On Thu, Feb 15, 2018 at 3:53 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Jared,
>
> On Thu, Feb 15, 2018 at 2:45 PM, Jared Bents
> <jared.bents@rockwellcollins.com> wrote:
>>
>> Update to use libqmi 1.20.0
>>
>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
>> ---
>>  package/libqmi/libqmi.hash | 2 +-
>>  package/libqmi/libqmi.mk   | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/libqmi/libqmi.hash b/package/libqmi/libqmi.hash
>> index 1c54231..297e1f0 100644
>> --- a/package/libqmi/libqmi.hash
>> +++ b/package/libqmi/libqmi.hash
>> @@ -1,4 +1,4 @@
>>  # Locally computed:
>> -sha256 a0a42c55935e75a630208e2f70840bd4407f56fe1c5258f5b0f6c0aaedf88cec  libqmi-1.18.0.tar.xz
>> +sha256 21428cd3749c56246565123f707fee51238651a22c60bdc85ebce97388626eb4  libqmi-1.20.0.tar.xz
>>  sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>>  sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
>
> Please check that both of these library files didn't change.
>
> Matt

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990
  2018-02-15 21:54   ` Matthew Weber
@ 2018-02-15 22:19     ` Jared Bents
  0 siblings, 0 replies; 11+ messages in thread
From: Jared Bents @ 2018-02-15 22:19 UTC (permalink / raw)
  To: buildroot

On Thu, Feb 15, 2018 at 3:54 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Jared,
>
> On Thu, Feb 15, 2018 at 2:45 PM, Jared Bents
> <jared.bents@rockwellcollins.com> wrote:
>> Update to modem manager 1.7.990 which does not require
>> udev.  Added option to build without udev but if udev
>> exists in the build, it will default to build with
>> libgudev.
>>
>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
>> ---
>>  package/modem-manager/Config.in          | 12 +++++++++---
>>  package/modem-manager/modem-manager.hash |  2 +-
>>  package/modem-manager/modem-manager.mk   | 11 +++++++++--
>>  3 files changed, 19 insertions(+), 6 deletions(-)
>>
>> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
>> index 8e995b4..38e017b 100644
>> --- a/package/modem-manager/Config.in
>> +++ b/package/modem-manager/Config.in
>> @@ -1,12 +1,10 @@
>>  config BR2_PACKAGE_MODEM_MANAGER
>>         bool "modemmanager"
>> -       depends on BR2_PACKAGE_HAS_UDEV
>>         depends on BR2_USE_WCHAR # libglib2 and gnutls
>>         depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>>         depends on BR2_USE_MMU # dbus
>>         select BR2_PACKAGE_DBUS # runtime dependency
>>         select BR2_PACKAGE_LIBGLIB2
>> -       select BR2_PACKAGE_LIBGUDEV
>>         help
>>           ModemManager is a DBus-activated daemon which controls mobile
>>           broadband (2G/3G/4G) devices and connections.
>> @@ -26,9 +24,17 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
>>         select BR2_PACKAGE_LIBQMI
>>         help
>>           This option enables support for QMI protocol
>> +
>> +config BR2_PACKAGE_MODEM_MANAGER_UDEV
>> +       bool "Use udev"
>> +       default y if BR2_PACKAGE_HAS_UDEV
>> +       select BR2_PACKAGE_LIBGUDEV
>> +       help
>> +         This option allows support for builds without udev. If udev
>> +         is not included, say N.
>>  endif
>>
>> -comment "modemmanager needs udev /dev management and a toolchain w/ wchar, threads"
>> +comment "modemmanager needs /dev management and a toolchain w/ wchar, threads"
>>         depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
>>                 !BR2_PACKAGE_HAS_UDEV
>>         depends on BR2_USE_MMU
>> diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
>> index bc08044..52cc7a6 100644
>> --- a/package/modem-manager/modem-manager.hash
>> +++ b/package/modem-manager/modem-manager.hash
>> @@ -1,4 +1,4 @@
>>  # Locally computed
>> -sha256  bc74326fa69ae8012f806e235f3d296144922669b952d4d4987dd0af645d5f68  ModemManager-1.6.10.tar.xz
>> +sha256  d465094fc6fc173354f5a00d212049056829cc245d60a9083f3c53f86a8f90ec  ModemManager-1.7.990.tar.xz
>>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
>
>
> Please check these license hash didn't change.

Matt,

I have verified the sha256 for both library files did not change

Jared

>
> Matt

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990
  2018-02-15 20:45 ` [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990 Jared Bents
  2018-02-15 21:54   ` Matthew Weber
@ 2018-02-16  5:18   ` Baruch Siach
  2018-02-16 16:08     ` Jared Bents
  1 sibling, 1 reply; 11+ messages in thread
From: Baruch Siach @ 2018-02-16  5:18 UTC (permalink / raw)
  To: buildroot

Hi Jared,

On Thu, Feb 15, 2018 at 02:45:06PM -0600, Jared Bents wrote:
> Update to modem manager 1.7.990 which does not require
> udev.  Added option to build without udev but if udev
> exists in the build, it will default to build with
> libgudev.
> 
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> ---
>  package/modem-manager/Config.in          | 12 +++++++++---
>  package/modem-manager/modem-manager.hash |  2 +-
>  package/modem-manager/modem-manager.mk   | 11 +++++++++--
>  3 files changed, 19 insertions(+), 6 deletions(-)
> 
> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index 8e995b4..38e017b 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -1,12 +1,10 @@
>  config BR2_PACKAGE_MODEM_MANAGER
>  	bool "modemmanager"
> -	depends on BR2_PACKAGE_HAS_UDEV
>  	depends on BR2_USE_WCHAR # libglib2 and gnutls
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>  	depends on BR2_USE_MMU # dbus
>  	select BR2_PACKAGE_DBUS # runtime dependency
>  	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_LIBGUDEV
>  	help
>  	  ModemManager is a DBus-activated daemon which controls mobile
>  	  broadband (2G/3G/4G) devices and connections.
> @@ -26,9 +24,17 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
>  	select BR2_PACKAGE_LIBQMI
>  	help
>  	  This option enables support for QMI protocol
> +
> +config BR2_PACKAGE_MODEM_MANAGER_UDEV
> +	bool "Use udev"
> +	default y if BR2_PACKAGE_HAS_UDEV
> +	select BR2_PACKAGE_LIBGUDEV
> +	help
> +	  This option allows support for builds without udev. If udev
> +	  is not included, say N.

Is udev an actual run-time dependency when building with libgudev? If not, you 
can remove this part, and make libgudev an optional dependency. See below.

Even if udev is really needed, I don't think it should be user selectable. 
Just do

  select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV

This reduced the number of options, which is something we always try to do.

>  endif
>  
> -comment "modemmanager needs udev /dev management and a toolchain w/ wchar, threads"
> +comment "modemmanager needs /dev management and a toolchain w/ wchar, threads"
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
>  		!BR2_PACKAGE_HAS_UDEV
>  	depends on BR2_USE_MMU
> diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> index bc08044..52cc7a6 100644
> --- a/package/modem-manager/modem-manager.hash
> +++ b/package/modem-manager/modem-manager.hash
> @@ -1,4 +1,4 @@
>  # Locally computed
> -sha256  bc74326fa69ae8012f806e235f3d296144922669b952d4d4987dd0af645d5f68  ModemManager-1.6.10.tar.xz
> +sha256  d465094fc6fc173354f5a00d212049056829cc245d60a9083f3c53f86a8f90ec  ModemManager-1.7.990.tar.xz
>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index b741acf..3015b00 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -4,12 +4,12 @@
>  #
>  ################################################################################
>  
> -MODEM_MANAGER_VERSION = 1.6.10
> +MODEM_MANAGER_VERSION = 1.7.990

Looks like a beta release. Any reason you need this specific release?

>  MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
>  MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
>  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
>  MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
> -MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2 libgudev
> +MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
>  MODEM_MANAGER_INSTALL_STAGING = YES
>  
>  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
> @@ -26,6 +26,13 @@ else
>  MODEM_MANAGER_CONF_OPTS += --without-mbim
>  endif
>  
> +ifeq ($(BR2_PACKAGE_MODEM_MANAGER_UDEV),y)
> +MODEM_MANAGER_DEPENDENCIES += libgudev
> +MODEM_MANAGER_CONF_OPTS += --with-udev
> +else
> +MODEM_MANAGER_CONF_OPTS += --without-udev
> +endif

Something like (copied from libmbim.mk):

ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
LIBMBIM_DEPENDENCIES += libgudev
LIBMBIM_CONF_OPTS += --with-udev
else
LIBMBIM_CONF_OPTS += --without-udev
endif

with the needed changes.

> +
>  define MODEM_MANAGER_INSTALL_INIT_SYSV
>  	$(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager \
>  		$(TARGET_DIR)/etc/init.d/S44modem-manager

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0
  2018-02-15 21:53 ` [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Matthew Weber
  2018-02-15 22:16   ` Jared Bents
@ 2018-02-16 15:38   ` Matthew Weber
  2018-02-19  0:21     ` Carlos Santos
  1 sibling, 1 reply; 11+ messages in thread
From: Matthew Weber @ 2018-02-16 15:38 UTC (permalink / raw)
  To: buildroot

Jared,

On Thu, Feb 15, 2018 at 3:53 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Jared,
>
> On Thu, Feb 15, 2018 at 2:45 PM, Jared Bents
> <jared.bents@rockwellcollins.com> wrote:
>>
>> Update to use libqmi 1.20.0
>>
>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>

Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990
  2018-02-16  5:18   ` Baruch Siach
@ 2018-02-16 16:08     ` Jared Bents
  2018-02-16 16:16       ` Matthew Weber
  0 siblings, 1 reply; 11+ messages in thread
From: Jared Bents @ 2018-02-16 16:08 UTC (permalink / raw)
  To: buildroot

Hi Baruch,

On Thu, Feb 15, 2018 at 11:18 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Jared,
>
> On Thu, Feb 15, 2018 at 02:45:06PM -0600, Jared Bents wrote:
>> Update to modem manager 1.7.990 which does not require
>> udev.  Added option to build without udev but if udev
>> exists in the build, it will default to build with
>> libgudev.
>>
>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
>> ---
>>  package/modem-manager/Config.in          | 12 +++++++++---
>>  package/modem-manager/modem-manager.hash |  2 +-
>>  package/modem-manager/modem-manager.mk   | 11 +++++++++--
>>  3 files changed, 19 insertions(+), 6 deletions(-)
>>
>> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
>> index 8e995b4..38e017b 100644
>> --- a/package/modem-manager/Config.in
>> +++ b/package/modem-manager/Config.in
>> @@ -1,12 +1,10 @@
>>  config BR2_PACKAGE_MODEM_MANAGER
>>       bool "modemmanager"
>> -     depends on BR2_PACKAGE_HAS_UDEV
>>       depends on BR2_USE_WCHAR # libglib2 and gnutls
>>       depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>>       depends on BR2_USE_MMU # dbus
>>       select BR2_PACKAGE_DBUS # runtime dependency
>>       select BR2_PACKAGE_LIBGLIB2
>> -     select BR2_PACKAGE_LIBGUDEV
>>       help
>>         ModemManager is a DBus-activated daemon which controls mobile
>>         broadband (2G/3G/4G) devices and connections.
>> @@ -26,9 +24,17 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
>>       select BR2_PACKAGE_LIBQMI
>>       help
>>         This option enables support for QMI protocol
>> +
>> +config BR2_PACKAGE_MODEM_MANAGER_UDEV
>> +     bool "Use udev"
>> +     default y if BR2_PACKAGE_HAS_UDEV
>> +     select BR2_PACKAGE_LIBGUDEV
>> +     help
>> +       This option allows support for builds without udev. If udev
>> +       is not included, say N.
>
> Is udev an actual run-time dependency when building with libgudev? If not, you
> can remove this part, and make libgudev an optional dependency. See below.
>
> Even if udev is really needed, I don't think it should be user selectable.
> Just do
>
>   select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
>
> This reduced the number of options, which is something we always try to do.
>

I will update with a v2 that automatically selects based on if udev is
present without user input.

>>  endif
>>
>> -comment "modemmanager needs udev /dev management and a toolchain w/ wchar, threads"
>> +comment "modemmanager needs /dev management and a toolchain w/ wchar, threads"
>>       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
>>               !BR2_PACKAGE_HAS_UDEV
>>       depends on BR2_USE_MMU
>> diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
>> index bc08044..52cc7a6 100644
>> --- a/package/modem-manager/modem-manager.hash
>> +++ b/package/modem-manager/modem-manager.hash
>> @@ -1,4 +1,4 @@
>>  # Locally computed
>> -sha256  bc74326fa69ae8012f806e235f3d296144922669b952d4d4987dd0af645d5f68  ModemManager-1.6.10.tar.xz
>> +sha256  d465094fc6fc173354f5a00d212049056829cc245d60a9083f3c53f86a8f90ec  ModemManager-1.7.990.tar.xz
>>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
>> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
>> index b741acf..3015b00 100644
>> --- a/package/modem-manager/modem-manager.mk
>> +++ b/package/modem-manager/modem-manager.mk
>> @@ -4,12 +4,12 @@
>>  #
>>  ################################################################################
>>
>> -MODEM_MANAGER_VERSION = 1.6.10
>> +MODEM_MANAGER_VERSION = 1.7.990
>
> Looks like a beta release. Any reason you need this specific release?
>

I believe this is the first release that allows building and using
without udev.  I recently came across a use case that needs modem
manager but is running SE Linux that does not allow udev.

>>  MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
>>  MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
>>  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
>>  MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
>> -MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2 libgudev
>> +MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
>>  MODEM_MANAGER_INSTALL_STAGING = YES
>>
>>  ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
>> @@ -26,6 +26,13 @@ else
>>  MODEM_MANAGER_CONF_OPTS += --without-mbim
>>  endif
>>
>> +ifeq ($(BR2_PACKAGE_MODEM_MANAGER_UDEV),y)
>> +MODEM_MANAGER_DEPENDENCIES += libgudev
>> +MODEM_MANAGER_CONF_OPTS += --with-udev
>> +else
>> +MODEM_MANAGER_CONF_OPTS += --without-udev
>> +endif
>
> Something like (copied from libmbim.mk):
>
> ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
> LIBMBIM_DEPENDENCIES += libgudev
> LIBMBIM_CONF_OPTS += --with-udev
> else
> LIBMBIM_CONF_OPTS += --without-udev
> endif
>
> with the needed changes.
>

I will update in v2 with the change to auto select based on udev being present

>> +
>>  define MODEM_MANAGER_INSTALL_INIT_SYSV
>>       $(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager \
>>               $(TARGET_DIR)/etc/init.d/S44modem-manager
>
> baruch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Jared

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990
  2018-02-16 16:08     ` Jared Bents
@ 2018-02-16 16:16       ` Matthew Weber
  0 siblings, 0 replies; 11+ messages in thread
From: Matthew Weber @ 2018-02-16 16:16 UTC (permalink / raw)
  To: buildroot

Jared,

On Fri, Feb 16, 2018 at 10:08 AM, Jared Bents
<jared.bents@rockwellcollins.com> wrote:
>
[snip]
> I believe this is the first release that allows building and using
> without udev.  I recently came across a use case that needs modem
> manager but is running SE Linux that does not allow udev.

SE Linux does work with udev but it's usually preferred to not use it.

Matt

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0
  2018-02-16 15:38   ` Matthew Weber
@ 2018-02-19  0:21     ` Carlos Santos
  0 siblings, 0 replies; 11+ messages in thread
From: Carlos Santos @ 2018-02-19  0:21 UTC (permalink / raw)
  To: buildroot

> From: "Matthew Weber" <matthew.weber@rockwellcollins.com>
> To: "Jared Bents" <jared.bents@rockwellcollins.com>
> Cc: "buildroot" <buildroot@buildroot.org>
> Sent: Friday, February 16, 2018 1:38:45 PM
> Subject: Re: [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0

> Jared,
> 
> On Thu, Feb 15, 2018 at 3:53 PM, Matthew Weber
> <matthew.weber@rockwellcollins.com> wrote:
>> Jared,
>>
>> On Thu, Feb 15, 2018 at 2:45 PM, Jared Bents
>> <jared.bents@rockwellcollins.com> wrote:
>>>
>>> Update to use libqmi 1.20.0
>>>
>>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> 
> Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>

It's already there: https://patchwork.ozlabs.org/patch/871057/

-- 
Carlos Santos (Casantos) - DATACOM, P&D
?The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.? ? Christopher Hitchens

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-02-19  0:21 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-15 20:45 [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Jared Bents
2018-02-15 20:45 ` [Buildroot] [PATCH 2/2] modem-manager: Update to version 1.7.990 Jared Bents
2018-02-15 21:54   ` Matthew Weber
2018-02-15 22:19     ` Jared Bents
2018-02-16  5:18   ` Baruch Siach
2018-02-16 16:08     ` Jared Bents
2018-02-16 16:16       ` Matthew Weber
2018-02-15 21:53 ` [Buildroot] [PATCH 1/2] libqmi: Update to use libqmi 1.20.0 Matthew Weber
2018-02-15 22:16   ` Jared Bents
2018-02-16 15:38   ` Matthew Weber
2018-02-19  0:21     ` Carlos Santos

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.