* [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion
@ 2019-10-23 23:42 Evan Chime
2019-10-24 9:38 ` Ian Abbott
0 siblings, 1 reply; 7+ messages in thread
From: Evan Chime @ 2019-10-23 23:42 UTC (permalink / raw)
To: gregkh; +Cc: hsweeten, abbotti, outreachy-kernel
Remove wrapper function "comedi_buf_map_get" declaration
as part of remove all wrappers in drivers/staging/comedi/TODO
Signed-off-by: Evan Chime <chime.evan.dri.devel@gmail.com>
---
drivers/staging/comedi/comedi_internal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
index 515f293a5d26..df3b1af109f7 100644
--- a/drivers/staging/comedi/comedi_internal.h
+++ b/drivers/staging/comedi/comedi_internal.h
@@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s,
unsigned long new_size);
void comedi_buf_reset(struct comedi_subdevice *s);
bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
-void comedi_buf_map_get(struct comedi_buf_map *bm);
int comedi_buf_map_put(struct comedi_buf_map *bm);
int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long offset,
void *buf, int len, int write);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion
2019-10-23 23:42 [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion Evan Chime
@ 2019-10-24 9:38 ` Ian Abbott
2019-10-24 9:53 ` evan chime
0 siblings, 1 reply; 7+ messages in thread
From: Ian Abbott @ 2019-10-24 9:38 UTC (permalink / raw)
To: Evan Chime, gregkh; +Cc: hsweeten, outreachy-kernel
On 24/10/2019 00:42, Evan Chime wrote:
> Remove wrapper function "comedi_buf_map_get" declaration
> as part of remove all wrappers in drivers/staging/comedi/TODO
>
> Signed-off-by: Evan Chime <chime.evan.dri.devel@gmail.com>
> ---
> drivers/staging/comedi/comedi_internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
> index 515f293a5d26..df3b1af109f7 100644
> --- a/drivers/staging/comedi/comedi_internal.h
> +++ b/drivers/staging/comedi/comedi_internal.h
> @@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s,
> unsigned long new_size);
> void comedi_buf_reset(struct comedi_subdevice *s);
> bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
> -void comedi_buf_map_get(struct comedi_buf_map *bm);
> int comedi_buf_map_put(struct comedi_buf_map *bm);
> int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long offset,
> void *buf, int len, int write);
>
Sorry, I don't really see the point of this patch series. For a start,
the comedi_buf_map functions were added a long time after the TODO file
was written. I can't even remember what the "remove all wrappers" line
in the TODO file is referring to.
Besides that, as pointed out by Julia, the patches have been ordered in
such a way as to break the build between the patches.
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion
2019-10-24 9:38 ` Ian Abbott
@ 2019-10-24 9:53 ` evan chime
2019-10-24 14:40 ` evan chime
0 siblings, 1 reply; 7+ messages in thread
From: evan chime @ 2019-10-24 9:53 UTC (permalink / raw)
To: Ian Abbott; +Cc: gregkh, hsweeten, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]
Hello Ian
Thanks for the reply. Got it
Kind Regards
Evan
On Thu, 24 Oct 2019 at 10:38, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 24/10/2019 00:42, Evan Chime wrote:
> > Remove wrapper function "comedi_buf_map_get" declaration
> > as part of remove all wrappers in drivers/staging/comedi/TODO
> >
> > Signed-off-by: Evan Chime <chime.evan.dri.devel@gmail.com>
> > ---
> > drivers/staging/comedi/comedi_internal.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/comedi_internal.h
> b/drivers/staging/comedi/comedi_internal.h
> > index 515f293a5d26..df3b1af109f7 100644
> > --- a/drivers/staging/comedi/comedi_internal.h
> > +++ b/drivers/staging/comedi/comedi_internal.h
> > @@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev, struct
> comedi_subdevice *s,
> > unsigned long new_size);
> > void comedi_buf_reset(struct comedi_subdevice *s);
> > bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
> > -void comedi_buf_map_get(struct comedi_buf_map *bm);
> > int comedi_buf_map_put(struct comedi_buf_map *bm);
> > int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long
> offset,
> > void *buf, int len, int write);
> >
>
> Sorry, I don't really see the point of this patch series. For a start,
> the comedi_buf_map functions were added a long time after the TODO file
> was written. I can't even remember what the "remove all wrappers" line
> in the TODO file is referring to.
>
> Besides that, as pointed out by Julia, the patches have been ordered in
> such a way as to break the build between the patches.
>
> --
> -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
> -=( MEV Ltd. is a company registered in England & Wales. )=-
> -=( Registered number: 02862268. Registered address: )=-
> -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
>
[-- Attachment #2: Type: text/html, Size: 2742 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion
2019-10-24 9:53 ` evan chime
@ 2019-10-24 14:40 ` evan chime
2019-10-24 18:22 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 7+ messages in thread
From: evan chime @ 2019-10-24 14:40 UTC (permalink / raw)
To: Ian Abbott; +Cc: gregkh, hsweeten, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2115 bytes --]
So should we maybe email the names on the TODOs, next time, to clarify the
tasks
On Thu, 24 Oct 2019 at 10:53, evan chime <chime.evan.dri.devel@gmail.com>
wrote:
> Hello Ian
>
> Thanks for the reply. Got it
>
> Kind Regards
> Evan
>
> On Thu, 24 Oct 2019 at 10:38, Ian Abbott <abbotti@mev.co.uk> wrote:
>
>> On 24/10/2019 00:42, Evan Chime wrote:
>> > Remove wrapper function "comedi_buf_map_get" declaration
>> > as part of remove all wrappers in drivers/staging/comedi/TODO
>> >
>> > Signed-off-by: Evan Chime <chime.evan.dri.devel@gmail.com>
>> > ---
>> > drivers/staging/comedi/comedi_internal.h | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/drivers/staging/comedi/comedi_internal.h
>> b/drivers/staging/comedi/comedi_internal.h
>> > index 515f293a5d26..df3b1af109f7 100644
>> > --- a/drivers/staging/comedi/comedi_internal.h
>> > +++ b/drivers/staging/comedi/comedi_internal.h
>> > @@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev,
>> struct comedi_subdevice *s,
>> > unsigned long new_size);
>> > void comedi_buf_reset(struct comedi_subdevice *s);
>> > bool comedi_buf_is_mmapped(struct comedi_subdevice *s);
>> > -void comedi_buf_map_get(struct comedi_buf_map *bm);
>> > int comedi_buf_map_put(struct comedi_buf_map *bm);
>> > int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long
>> offset,
>> > void *buf, int len, int write);
>> >
>>
>> Sorry, I don't really see the point of this patch series. For a start,
>> the comedi_buf_map functions were added a long time after the TODO file
>> was written. I can't even remember what the "remove all wrappers" line
>> in the TODO file is referring to.
>>
>> Besides that, as pointed out by Julia, the patches have been ordered in
>> such a way as to break the build between the patches.
>>
>> --
>> -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
>> -=( MEV Ltd. is a company registered in England & Wales. )=-
>> -=( Registered number: 02862268. Registered address: )=-
>> -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
>>
>
[-- Attachment #2: Type: text/html, Size: 3216 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion
2019-10-24 14:40 ` evan chime
@ 2019-10-24 18:22 ` Julia Lawall
2019-10-24 18:29 ` evan chime
0 siblings, 1 reply; 7+ messages in thread
From: Julia Lawall @ 2019-10-24 18:22 UTC (permalink / raw)
To: evan chime; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2923 bytes --]
On Thu, 24 Oct 2019, evan chime wrote:
> So should we maybe email the names on the TODOs, next time, to clarify the
> tasks
Please don't top post.
julia
>
> On Thu, 24 Oct 2019 at 10:53, evan chime <chime.evan.dri.devel@gmail.com>
> wrote:
> Hello Ian
>
> Thanks for the reply. Got it
>
> Kind Regards
> Evan
>
> On Thu, 24 Oct 2019 at 10:38, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 24/10/2019 00:42, Evan Chime wrote:
> > Remove wrapper function "comedi_buf_map_get" declaration
> > as part of remove all wrappers in
> drivers/staging/comedi/TODO
> >
> > Signed-off-by: Evan Chime
> <chime.evan.dri.devel@gmail.com>
> > ---
> > drivers/staging/comedi/comedi_internal.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/comedi_internal.h
> b/drivers/staging/comedi/comedi_internal.h
> > index 515f293a5d26..df3b1af109f7 100644
> > --- a/drivers/staging/comedi/comedi_internal.h
> > +++ b/drivers/staging/comedi/comedi_internal.h
> > @@ -28,7 +28,6 @@ int comedi_buf_alloc(struct
> comedi_device *dev, struct comedi_subdevice *s,
> > unsigned long new_size);
> > void comedi_buf_reset(struct comedi_subdevice *s);
> > bool comedi_buf_is_mmapped(struct comedi_subdevice
> *s);
> > -void comedi_buf_map_get(struct comedi_buf_map *bm);
> > int comedi_buf_map_put(struct comedi_buf_map *bm);
> > int comedi_buf_map_access(struct comedi_buf_map *bm,
> unsigned long offset,
> > void *buf, int len, int write);
> >
>
> Sorry, I don't really see the point of this patch series.
> For a start,
> the comedi_buf_map functions were added a long time after
> the TODO file
> was written. I can't even remember what the "remove all
> wrappers" line
> in the TODO file is referring to.
>
> Besides that, as pointed out by Julia, the patches have
> been ordered in
> such a way as to break the build between the patches.
>
> --
> -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk
> )=-
> -=( MEV Ltd. is a company registered in England & Wales.
> )=-
> -=( Registered number: 02862268. Registered address:
> )=-
> -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK.
> )=-
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jaTcgtXzkPH-O6vTNo
> CjQXyHSTe-zY35y%3DO9p9WBQ%3DX7A%40mail.gmail.com.
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion
2019-10-24 18:22 ` [Outreachy kernel] " Julia Lawall
@ 2019-10-24 18:29 ` evan chime
2019-10-24 20:06 ` Julia Lawall
0 siblings, 1 reply; 7+ messages in thread
From: evan chime @ 2019-10-24 18:29 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 3841 bytes --]
Hello Julia
Please what does it mean by don’t top the post? I normally do reply all
from my gmail
Kind regards
Evan
On Thu, 24 Oct 2019 at 19:22, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Thu, 24 Oct 2019, evan chime wrote:
>
> > So should we maybe email the names on the TODOs, next time, to clarify
> the
> > tasks
>
> Please don't top post.
>
> julia
>
> >
> > On Thu, 24 Oct 2019 at 10:53, evan chime <chime.evan.dri.devel@gmail.com
> >
> > wrote:
> > Hello Ian
> >
> > Thanks for the reply. Got it
> >
> > Kind Regards
> > Evan
> >
> > On Thu, 24 Oct 2019 at 10:38, Ian Abbott <abbotti@mev.co.uk> wrote:
> > On 24/10/2019 00:42, Evan Chime wrote:
> > > Remove wrapper function "comedi_buf_map_get" declaration
> > > as part of remove all wrappers in
> > drivers/staging/comedi/TODO
> > >
> > > Signed-off-by: Evan Chime
> > <chime.evan.dri.devel@gmail.com>
> > > ---
> > > drivers/staging/comedi/comedi_internal.h | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/comedi/comedi_internal.h
> > b/drivers/staging/comedi/comedi_internal.h
> > > index 515f293a5d26..df3b1af109f7 100644
> > > --- a/drivers/staging/comedi/comedi_internal.h
> > > +++ b/drivers/staging/comedi/comedi_internal.h
> > > @@ -28,7 +28,6 @@ int comedi_buf_alloc(struct
> > comedi_device *dev, struct comedi_subdevice *s,
> > > unsigned long new_size);
> > > void comedi_buf_reset(struct comedi_subdevice *s);
> > > bool comedi_buf_is_mmapped(struct comedi_subdevice
> > *s);
> > > -void comedi_buf_map_get(struct comedi_buf_map *bm);
> > > int comedi_buf_map_put(struct comedi_buf_map *bm);
> > > int comedi_buf_map_access(struct comedi_buf_map *bm,
> > unsigned long offset,
> > > void *buf, int len, int write);
> > >
> >
> > Sorry, I don't really see the point of this patch series.
> > For a start,
> > the comedi_buf_map functions were added a long time after
> > the TODO file
> > was written. I can't even remember what the "remove all
> > wrappers" line
> > in the TODO file is referring to.
> >
> > Besides that, as pointed out by Julia, the
> <https://www.google.com/maps/search/Besides+that,+as+pointed+out+by+Julia,+the+?entry=gmail&source=g>patches
> have
> > been ordered in
> > such a way as to break the build between the patches.
> >
> > --
> > -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk
> > )=-
> > -=( MEV Ltd. is a company registered in England & Wales.
> > )=-
> > -=( Registered number: 02862268. Registered address:
> > )=-
> > -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK.
> > )=-
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/CANR89jaTcgtXzkPH-O6vTNo
> > CjQXyHSTe-zY35y%3DO9p9WBQ%3DX7A%40mail.gmail.com.
> >
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1910242021470.2621%40hadrien
> .
>
[-- Attachment #2: Type: text/html, Size: 5823 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion
2019-10-24 18:29 ` evan chime
@ 2019-10-24 20:06 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2019-10-24 20:06 UTC (permalink / raw)
To: evan chime; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 5127 bytes --]
On Thu, 24 Oct 2019, evan chime wrote:
> Hello Julia
>
> Please what does it mean by don’t top the post? I normally do reply all from
> my gmail
You should type your response under the text that you are responding to.
That way the reader can understand exactly what you are talking about.
Please read through the tutorial again carefully.
julia
>
> Kind regards
> Evan
>
> On Thu, 24 Oct 2019 at 19:22, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Thu, 24 Oct 2019, evan chime wrote:
>
> > So should we maybe email the names on the TODOs, next time, to
> clarify the
> > tasks
>
> Please don't top post.
>
> julia
>
> >
> > On Thu, 24 Oct 2019 at 10:53, evan chime
> <chime.evan.dri.devel@gmail.com>
> > wrote:
> > Hello Ian
> >
> > Thanks for the reply. Got it
> >
> > Kind Regards
> > Evan
> >
> > On Thu, 24 Oct 2019 at 10:38, Ian Abbott <abbotti@mev.co.uk>
> wrote:
> > On 24/10/2019 00:42, Evan Chime wrote:
> > > Remove wrapper function "comedi_buf_map_get"
> declaration
> > > as part of remove all wrappers in
> > drivers/staging/comedi/TODO
> > >
> > > Signed-off-by: Evan Chime
> > <chime.evan.dri.devel@gmail.com>
> > > ---
> > > drivers/staging/comedi/comedi_internal.h | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/comedi/comedi_internal.h
> > b/drivers/staging/comedi/comedi_internal.h
> > > index 515f293a5d26..df3b1af109f7 100644
> > > --- a/drivers/staging/comedi/comedi_internal.h
> > > +++ b/drivers/staging/comedi/comedi_internal.h
> > > @@ -28,7 +28,6 @@ int comedi_buf_alloc(struct
> > comedi_device *dev, struct comedi_subdevice *s,
> > > unsigned long new_size);
> > > void comedi_buf_reset(struct comedi_subdevice *s);
> > > bool comedi_buf_is_mmapped(struct comedi_subdevice
> > *s);
> > > -void comedi_buf_map_get(struct comedi_buf_map *bm);
> > > int comedi_buf_map_put(struct comedi_buf_map *bm);
> > > int comedi_buf_map_access(struct comedi_buf_map *bm,
> > unsigned long offset,
> > > void *buf, int len, int
> write);
> > >
> >
> > Sorry, I don't really see the point of this patch
> series.
> > For a start,
> > the comedi_buf_map functions were added a long time
> after
> > the TODO file
> > was written. I can't even remember what the "remove all
> > wrappers" line
> > in the TODO file is referring to.
> >
> > Besides that, as pointed out by Julia, the patches have
> > been ordered in
> > such a way as to break the build between the patches.
> >
> > --
> > -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk
> > )=-
> > -=( MEV Ltd. is a company registered in England & Wales.
> > )=-
> > -=( Registered number: 02862268. Registered address:
> > )=-
> > -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK.
> > )=-
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jaTcgtXzkPH-O
> 6vTNo
> > CjQXyHSTe-zY35y%3DO9p9WBQ%3DX7A%40mail.gmail.com.
> >
> >
>
> --
> You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from
> it, send an email to
> outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.19102420
> 21470.2621%40hadrien.
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jYskb%3D4rJ6r%3DWF
> S2QZRonHFs9_oiHok7SqC5iWCnc4qBg%40mail.gmail.com.
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-24 20:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 23:42 [PATCH 1/7] Staging: comedi: Remove wrapper function declarartion Evan Chime
2019-10-24 9:38 ` Ian Abbott
2019-10-24 9:53 ` evan chime
2019-10-24 14:40 ` evan chime
2019-10-24 18:22 ` [Outreachy kernel] " Julia Lawall
2019-10-24 18:29 ` evan chime
2019-10-24 20:06 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.