From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Will Deacon <will.deacon@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Akira Yokosawa <akiyks@gmail.com>,
Daniel Lustig <dlustig@nvidia.com>,
linux-arch@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Eli Friedman <efriedma@codeaurora.org>,
Joe Perches <joe@perches.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
linux-sparse@vger.kernel.org,
Eric Christopher <echristo@google.com>
Subject: Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR
Date: Wed, 9 Jan 2019 11:35:52 +0100 [thread overview]
Message-ID: <CANiq72nEiw8+cZNnBOwF1ehv232ZJe5qzhdbaTEg0rOoV2p4sg@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdk3b6mnpTEEyY-JFrej8K12w9oTMLqi7q5aNiRMyJo6Ow@mail.gmail.com>
On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> Also for more context, see:
> commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against
> dead store elimination")
By the way, shouldn't that barrier_data() be directly in compiler.h
too, since it is for both gcc & clang?
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> + Miguel
> Miguel, would you mind taking this into your compiler-attributes tree?
Sure, at least we get quickly some linux-next time.
Note it would be nice to separate the patch into two (one for the
comments, another for OPTIMIZER_HIDE_VAR), and also possibly another
for barrier_data().
Cheers,
Miguel
WARNING: multiple messages have this Message-ID (diff)
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Will Deacon <will.deacon@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Akira Yokosawa <akiyks@gmail.com>,
Daniel Lustig <dlustig@nvidia.com>,
linux-arch@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Eli Friedman <efriedma@codeaurora.org>,
Joe Perches <joe@p
Subject: Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR
Date: Wed, 9 Jan 2019 11:35:52 +0100 [thread overview]
Message-ID: <CANiq72nEiw8+cZNnBOwF1ehv232ZJe5qzhdbaTEg0rOoV2p4sg@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdk3b6mnpTEEyY-JFrej8K12w9oTMLqi7q5aNiRMyJo6Ow@mail.gmail.com>
On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> Also for more context, see:
> commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against
> dead store elimination")
By the way, shouldn't that barrier_data() be directly in compiler.h
too, since it is for both gcc & clang?
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> + Miguel
> Miguel, would you mind taking this into your compiler-attributes tree?
Sure, at least we get quickly some linux-next time.
Note it would be nice to separate the patch into two (one for the
comments, another for OPTIMIZER_HIDE_VAR), and also possibly another
for barrier_data().
Cheers,
Miguel
WARNING: multiple messages have this Message-ID (diff)
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Will Deacon <will.deacon@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Akira Yokosawa <akiyks@gmail.com>,
Daniel Lustig <dlustig@nvidia.com>,
linux-arch@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Eli Friedman <efriedma@codeaurora.org>, Joe Perches <joe@p>
Subject: Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR
Date: Wed, 9 Jan 2019 11:35:52 +0100 [thread overview]
Message-ID: <CANiq72nEiw8+cZNnBOwF1ehv232ZJe5qzhdbaTEg0rOoV2p4sg@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdk3b6mnpTEEyY-JFrej8K12w9oTMLqi7q5aNiRMyJo6Ow@mail.gmail.com>
On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> Also for more context, see:
> commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against
> dead store elimination")
By the way, shouldn't that barrier_data() be directly in compiler.h
too, since it is for both gcc & clang?
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> + Miguel
> Miguel, would you mind taking this into your compiler-attributes tree?
Sure, at least we get quickly some linux-next time.
Note it would be nice to separate the patch into two (one for the
comments, another for OPTIMIZER_HIDE_VAR), and also possibly another
for barrier_data().
Cheers,
Miguel
next prev parent reply other threads:[~2019-01-09 10:36 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 20:57 [PATCH RFC 0/4] barriers using data dependency Michael S. Tsirkin
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-02 20:57 ` [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR Michael S. Tsirkin
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-08 17:44 ` Nick Desaulniers
2019-01-08 17:44 ` Nick Desaulniers
2019-01-08 17:44 ` Nick Desaulniers
2019-01-08 18:50 ` Michael S. Tsirkin
2019-01-08 18:50 ` Michael S. Tsirkin
2019-01-08 18:50 ` Michael S. Tsirkin
2019-01-08 18:50 ` Michael S. Tsirkin
2019-01-09 10:35 ` Miguel Ojeda [this message]
2019-01-09 10:35 ` Miguel Ojeda
2019-01-09 10:35 ` Miguel Ojeda
2019-01-09 14:50 ` Michael S. Tsirkin
2019-01-09 14:50 ` Michael S. Tsirkin
2019-01-09 14:50 ` Michael S. Tsirkin
2019-01-19 18:35 ` Miguel Ojeda
2019-01-19 18:35 ` Miguel Ojeda
2019-01-20 14:43 ` Michael S. Tsirkin
2019-01-20 14:43 ` Michael S. Tsirkin
2019-01-20 14:43 ` Michael S. Tsirkin
2019-01-20 15:36 ` Miguel Ojeda
2019-01-20 15:36 ` Miguel Ojeda
2019-01-09 14:50 ` Michael S. Tsirkin
2019-01-10 2:36 ` Michael S. Tsirkin
2019-01-10 2:36 ` Michael S. Tsirkin
2019-01-10 2:36 ` Michael S. Tsirkin
2019-01-10 13:41 ` Dan Carpenter
2019-01-10 13:41 ` Dan Carpenter
2019-01-10 13:41 ` Dan Carpenter
2019-01-10 14:08 ` Michael S. Tsirkin
2019-01-10 14:08 ` Michael S. Tsirkin
2019-01-10 14:08 ` Michael S. Tsirkin
2019-01-10 13:41 ` Dan Carpenter
2019-01-10 2:36 ` Michael S. Tsirkin
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-02 20:57 ` [PATCH RFC 2/4] include/linux/compiler.h: allow memory operands Michael S. Tsirkin
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-07 17:54 ` Will Deacon
2019-01-07 17:54 ` Will Deacon
2019-01-07 18:16 ` Michael S. Tsirkin
2019-01-07 18:16 ` Michael S. Tsirkin
2019-01-02 20:57 ` [PATCH RFC 3/4] barriers: convert a control to a data dependency Michael S. Tsirkin
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-02 21:00 ` Matthew Wilcox
2019-01-02 21:00 ` Matthew Wilcox
2019-01-02 21:00 ` Matthew Wilcox
2019-01-02 21:00 ` Matthew Wilcox
2019-01-02 21:24 ` Michael S. Tsirkin
2019-01-02 21:24 ` Michael S. Tsirkin
2019-01-02 21:24 ` Michael S. Tsirkin
2019-01-02 21:24 ` Michael S. Tsirkin
2019-01-07 3:58 ` Jason Wang
2019-01-07 3:58 ` Jason Wang
2019-01-07 4:23 ` Michael S. Tsirkin
2019-01-07 4:23 ` Michael S. Tsirkin
2019-01-07 4:23 ` Michael S. Tsirkin
2019-01-07 4:23 ` Michael S. Tsirkin
2019-01-07 6:50 ` Jason Wang
2019-01-07 6:50 ` Jason Wang
2019-01-07 6:50 ` Jason Wang
2019-01-07 6:50 ` Jason Wang
2019-01-07 9:46 ` Peter Zijlstra
2019-01-07 9:46 ` Peter Zijlstra
2019-01-07 13:36 ` Michael S. Tsirkin
2019-01-07 13:36 ` Michael S. Tsirkin
2019-01-07 15:54 ` Peter Zijlstra
2019-01-07 15:54 ` Peter Zijlstra
2019-01-07 16:22 ` Michael S. Tsirkin
2019-01-07 16:22 ` Michael S. Tsirkin
2019-01-07 16:22 ` Michael S. Tsirkin
2019-01-07 16:22 ` Michael S. Tsirkin
2019-01-07 19:02 ` Paul E. McKenney
2019-01-07 19:02 ` Paul E. McKenney
2019-01-07 19:02 ` Paul E. McKenney
2019-01-07 19:13 ` Michael S. Tsirkin
2019-01-07 19:13 ` Michael S. Tsirkin
2019-01-07 19:13 ` Michael S. Tsirkin
2019-01-07 19:13 ` Michael S. Tsirkin
2019-01-07 19:25 ` Paul E. McKenney
2019-01-07 19:25 ` Paul E. McKenney
2019-01-07 19:25 ` Paul E. McKenney
2019-01-02 20:57 ` Michael S. Tsirkin
2019-01-02 20:58 ` [PATCH RFC 4/4] virtio: use dependent_ptr_mb Michael S. Tsirkin
2019-01-02 20:58 ` Michael S. Tsirkin
2019-01-02 21:36 ` [PATCH RFC 0/4] barriers using data dependency Alan Stern
2019-01-02 21:36 ` Alan Stern
2019-01-02 23:04 ` Michael S. Tsirkin
2019-01-02 23:04 ` Michael S. Tsirkin
2019-01-03 15:11 ` Alan Stern
2019-01-03 15:11 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72nEiw8+cZNnBOwF1ehv232ZJe5qzhdbaTEg0rOoV2p4sg@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=echristo@google.com \
--cc=efriedma@codeaurora.org \
--cc=j.alglave@ucl.ac.uk \
--cc=jasowang@redhat.com \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=luc.vanoostenryck@gmail.com \
--cc=mst@redhat.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.