Re: [RFC 7/8] fpga-region: add sysfs interface

From: Alan Tull <delicious.quinoa@gmail.com>
To: "Nadathur, Sundar" <sundar.nadathur@intel.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>,
	Yves Vandervennet <yves.vandervennet@linux.intel.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	"matthew.gerlach@linux.intel.com"
	<matthew.gerlach@linux.intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>
Subject: Re: [RFC 7/8] fpga-region: add sysfs interface
Date: Sat, 18 Feb 2017 14:10:43 -0600	[thread overview]
Message-ID: <CANk1AXT7EMDw-5qWqKCDJcwySQjhhVGf_1m-b9NTbyzVRkO7cg@mail.gmail.com> (raw)
In-Reply-To: <1CC272501B5BC543A05DB90AA509DED50AF5EC@fmsmsx122.amr.corp.intel.com>

On Sat, Feb 18, 2017 at 6:45 AM, Nadathur, Sundar
<sundar.nadathur@intel.com> wrote:

> Hi all,
>    Interesting discussion. The discussion so far has brought out many concerns such as OS independence. There is an existing format, well-known to developers, with widespread support, and which is quite extensible: Type-Length-Value triples.
>
> To elaborate, a TLV-based format has many advantages:
> * It is highly extensible in many ways
>    -- You can express structures and arrays using TLVs. Our needs right now may seem limited but requirements grow over time.
>    -- The space of Type values can be decomposed into standard pre-defined values that are in upstreamed code, and possibly experimental or feature-specific values.
>    -- Forward compatibility: We can write parsers that can skip unexpected type values, thus allowing old parsers to work with new additions. With some tweaks, old parsers can also reject unexpected values in some ranges while accepting them in other ranges.
> * It is OS-independent.
> * It can be easily parsed, in kernel or user space.
> * It can be validated, in terms of Type values, acceptable lengths, etc.
>
> It  is not directly human-readable but that can be easily addressed with a tool that parses TLVs.
>
> Compared to some other proposals:
> * Compared to DTs, TLVs are OS-independent.
> * Compared to strings as key-value pairs, TLVs can express structures/arrays, can be validated, etc.
>
> So, I suggest we use TLVs to express metadata in image files.
>
> Thank you very much,
> Sundar Nadathur

Hi Sundar,

IIUC, each field is position dependent.  One of the strengths of key
value pairs is
that any key can be added in any order and ones that aren't applicable for
a particular architecture or use case can be left out.  If the header
is position
dependent, it becomes less flexible.  Once a field is added, we are
stuck with it
forever unless we drop it in some incremented version of the header format.

Alan