All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Mat Martineau <mathew.j.martineau@linux.intel.com>,
	Ayush Sawal <ayush.sawal@chelsio.com>,
	MPTCP Upstream <mptcp@lists.linux.dev>
Subject: Re: [RFC PATCH 0/5] net: remove sk skb caches
Date: Fri, 17 Sep 2021 09:47:57 -0700	[thread overview]
Message-ID: <CANn89iLOL0er35k=G=BeDKtOcA6Rn3n3k+pgVQX8bVFdA1w_Dw@mail.gmail.com> (raw)
In-Reply-To: <cover.1631888517.git.pabeni@redhat.com>

On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> Eric noted we would be better off reverting the sk
> skb caches.
>
> MPTCP relies on such a feature, so we need a
> little refactor of the MPTCP tx path before the mentioned
> revert.
>
> The first patch avoids that the next one will cause a name
> clash. The second exposes additional TCP helpers. The 3rd patch
> changes the MPTCP code to do locally the whole skb allocation
> and updating, so it does not rely anymore on core TCP helpers
> for that nor the sk skb cache.
>
> As a side effect, we can drop the tcp_build_frag helper.
>
> Finally, we can pull Eric's revert.
>
> Note that patch 3/5 will conflict with the pending -net fix
> for a recently reported syzkaller splat.
>

Thanks for working on this Paolo !

  parent reply	other threads:[~2021-09-17 16:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 15:38 [RFC PATCH 0/5] net: remove sk skb caches Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 1/5] chtls: rename skb_entail() to chtls_skb_entail() Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 2/5] tcp: expose the tcp_mark_push() and skb_entail() helpers Paolo Abeni
2021-09-17 16:43   ` Eric Dumazet
2021-09-17 16:43     ` Eric Dumazet
2021-09-17 17:28     ` Paolo Abeni
2021-09-17 17:28       ` Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 3/5] mptcp: stop relying on tcp_tx_skb_cache Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()" Paolo Abeni
2021-09-17 16:41   ` Eric Dumazet
2021-09-17 16:41     ` Eric Dumazet
2021-09-17 17:31     ` Paolo Abeni
2021-09-17 17:31       ` Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 5/5] tcp: remove sk_{tr}x_skb_cache Paolo Abeni
2021-09-17 16:47 ` Eric Dumazet [this message]
2021-09-17 16:47   ` [RFC PATCH 0/5] net: remove sk skb caches Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANn89iLOL0er35k=G=BeDKtOcA6Rn3n3k+pgVQX8bVFdA1w_Dw@mail.gmail.com' \
    --to=edumazet@google.com \
    --cc=ayush.sawal@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.