newbie: submitting a driver patch the first time

newbie: submitting a driver patch the first time

[Geißler, Andreas]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8-sig", Size: 1399 bytes --]

Hello everyone,

I would like to integrate some of our company drivers into the Vanilla Linux kernel, but I have never done this before.
Some esteemed colleagues did this a few years earlier, but unfortunately they are no longer with the company and we lost all information on how to do it.

We want to set up a process to keep the knowledge, but we have to start over. I am the chosen one who shall do this.

So I read a lot of guidelines and kernel documentation and create a first patch-set of one driver to be submitted. Before going to the actual mailing lists (scripts/get_maintainer.pl), I would like to send this patch-set to the linux-newbie list for hopefully some constructive comments.


The driver is a BMC driver that supports the company's generic BMC called "14Y007", which is assembled on many of our hardware components. The BMC is connected via I2C. The driver is a further development of the menf21bmc driver, which is already in the kernel.
The driver is not yet finished and can be adjusted at anytime.

First question: Does it make sense to publish the driver at linux-newbie for a review before doing it on the actual mailing lists?

Regards,
Andreas

-- 
Andreas Geissler - Software Engineer

MEN Mikro Elektronik GmbH
Neuwieder Straße 1-7 90411 Nürnberg
Geschäftsführer: Dr. Michael Goldbach - Matthias Kamolz - Yilmaz Kocak - Handelsregister AG Nürnberg HRB 5540

Re: newbie: submitting a driver patch the first time

[Eric Curtin]

Hi Andreas,

See the process documentation folder:

https://github.com/torvalds/linux/tree/master/Documentation/process
https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst
https://github.com/torvalds/linux/blob/master/Documentation/process/email-clients.rst
https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst

There's a couple of very helpful youtube videos from Greg that
describe the process:

https://www.youtube.com/watch?v=LLBrBBImJt4&t=24s
https://www.youtube.com/watch?v=XXix80GCvpo

Feel free to email this mailing list again if you get stuck!

On Tue, 26 May 2020 at 15:50, Geißler, Andreas
<andreas.geissler@duagon.com> wrote:
>
> Hello everyone,
>
> I would like to integrate some of our company drivers into the Vanilla Linux kernel, but I have never done this before.
> Some esteemed colleagues did this a few years earlier, but unfortunately they are no longer with the company and we lost all information on how to do it.
>
> We want to set up a process to keep the knowledge, but we have to start over. I am the chosen one who shall do this.
>
> So I read a lot of guidelines and kernel documentation and create a first patch-set of one driver to be submitted. Before going to the actual mailing lists (scripts/get_maintainer.pl), I would like to send this patch-set to the linux-newbie list for hopefully some constructive comments.
>
>
> The driver is a BMC driver that supports the company's generic BMC called "14Y007", which is assembled on many of our hardware components. The BMC is connected via I2C. The driver is a further development of the menf21bmc driver, which is already in the kernel.
> The driver is not yet finished and can be adjusted at anytime.
>
> First question: Does it make sense to publish the driver at linux-newbie for a review before doing it on the actual mailing lists?
>
> Regards,
> Andreas
>
> --
> Andreas Geissler - Software Engineer
>
> MEN Mikro Elektronik GmbH
> Neuwieder Straße 1-7 90411 Nürnberg
> Geschäftsführer: Dr. Michael Goldbach - Matthias Kamolz - Yilmaz Kocak - Handelsregister AG Nürnberg HRB 5540
>

Re: newbie: submitting a driver patch the first time

[Hubert CHAUMETTE]

> First question: Does it make sense to publish the driver at
> linux-newbie for a review before doing it on the actual mailing lists?

Hi Andreas,

This list is usually used to help newbies on specific problems, I think 
you will get better results (and faster too) by directly sending your 
RFC to the concerned maintainers.

Regards,

Hubert

Re: newbie: submitting a driver patch the first time

[Andreas Geissler]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8-sig"; format="flowed", Size: 660 bytes --]




On 27.05.20 10:39, Hubert CHAUMETTE wrote:
>> First question: Does it make sense to publish the driver at
>> linux-newbie for a review before doing it on the actual mailing lists?
> 
> Hi Andreas,
> 
> This list is usually used to help newbies on specific problems, I think you will get better results (and faster too) by directly sending your RFC to the concerned maintainers.
ok thanks then i will do that
> 
> Regards,
> 
> Hubert

-- 
Andreas Geissler - Software Engineer
MEN Mikro Elektronik GmbH
Neuwieder Straße 1-7 90411 Nürnberg
Geschäftsführer: Dr. Michael Goldbach - Matthias Kamolz - Yilmaz Kocak - Handelsregister AG Nürnberg HRB 5540