All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Peter Chen <peter.chen@nxp.com>,
	USB list <linux-usb@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: Re: [PATCH] usb: chipidea: Fix ULPI on imx51
Date: Wed, 20 Jun 2018 19:22:55 -0300	[thread overview]
Message-ID: <CAOMZO5DJj=oQfsB-vNP=81HCiy-69j-5U+Km9P6LxGpnLx9xzg@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5AyAegbvUtX42by99mU8yQfi91bmhJfd9iqu1Ak0dEHiw@mail.gmail.com>

On Wed, Jun 20, 2018 at 7:07 PM, Fabio Estevam <festevam@gmail.com> wrote:

> This patches causes a regression on a imx51-babbage running 4.18-rc1:
> I get a kernel hang.
>
> If I revert it on top of 4.18-rc1, then it boots fine and USB host is
> functional.
>
> I understand this patch fixes a kernel hang for you, so which commit
> is responsible for the hang you observe?
>
> It seems this commit fixes a hang for you and causes another hang for me :-)
>
> Any ideas?

I am able to boot again if I skip passing the CI_HDRC_OVERRIDE_PHY_CONTROL flag:

--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -294,7 +294,6 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
        if ((of_device_is_compatible(np, "fsl,imx53-usb") ||
             of_device_is_compatible(np, "fsl,imx51-usb")) && pdata.usb_phy &&
            of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) {
-               pdata.flags |= CI_HDRC_OVERRIDE_PHY_CONTROL;
                data->override_phy_control = true;
                usb_phy_init(pdata.usb_phy);
        }

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Peter Chen <peter.chen@nxp.com>,
	USB list <linux-usb@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: usb: chipidea: Fix ULPI on imx51
Date: Wed, 20 Jun 2018 19:22:55 -0300	[thread overview]
Message-ID: <CAOMZO5DJj=oQfsB-vNP=81HCiy-69j-5U+Km9P6LxGpnLx9xzg@mail.gmail.com> (raw)

On Wed, Jun 20, 2018 at 7:07 PM, Fabio Estevam <festevam@gmail.com> wrote:

> This patches causes a regression on a imx51-babbage running 4.18-rc1:
> I get a kernel hang.
>
> If I revert it on top of 4.18-rc1, then it boots fine and USB host is
> functional.
>
> I understand this patch fixes a kernel hang for you, so which commit
> is responsible for the hang you observe?
>
> It seems this commit fixes a hang for you and causes another hang for me :-)
>
> Any ideas?

I am able to boot again if I skip passing the CI_HDRC_OVERRIDE_PHY_CONTROL flag:
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -294,7 +294,6 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
        if ((of_device_is_compatible(np, "fsl,imx53-usb") ||
             of_device_is_compatible(np, "fsl,imx51-usb")) && pdata.usb_phy &&
            of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) {
-               pdata.flags |= CI_HDRC_OVERRIDE_PHY_CONTROL;
                data->override_phy_control = true;
                usb_phy_init(pdata.usb_phy);
        }

WARNING: multiple messages have this Message-ID (diff)
From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: chipidea: Fix ULPI on imx51
Date: Wed, 20 Jun 2018 19:22:55 -0300	[thread overview]
Message-ID: <CAOMZO5DJj=oQfsB-vNP=81HCiy-69j-5U+Km9P6LxGpnLx9xzg@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5AyAegbvUtX42by99mU8yQfi91bmhJfd9iqu1Ak0dEHiw@mail.gmail.com>

On Wed, Jun 20, 2018 at 7:07 PM, Fabio Estevam <festevam@gmail.com> wrote:

> This patches causes a regression on a imx51-babbage running 4.18-rc1:
> I get a kernel hang.
>
> If I revert it on top of 4.18-rc1, then it boots fine and USB host is
> functional.
>
> I understand this patch fixes a kernel hang for you, so which commit
> is responsible for the hang you observe?
>
> It seems this commit fixes a hang for you and causes another hang for me :-)
>
> Any ideas?

I am able to boot again if I skip passing the CI_HDRC_OVERRIDE_PHY_CONTROL flag:

--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -294,7 +294,6 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
        if ((of_device_is_compatible(np, "fsl,imx53-usb") ||
             of_device_is_compatible(np, "fsl,imx51-usb")) && pdata.usb_phy &&
            of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) {
-               pdata.flags |= CI_HDRC_OVERRIDE_PHY_CONTROL;
                data->override_phy_control = true;
                usb_phy_init(pdata.usb_phy);
        }

  reply	other threads:[~2018-06-20 22:23 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 17:34 [PATCH] usb: chipidea: Fix ULPI on imx51 Andrey Smirnov
2018-05-30 17:34 ` Andrey Smirnov
2018-05-30 17:34 ` Andrey Smirnov
2018-05-30 18:10 ` [PATCH] " Fabio Estevam
2018-05-30 18:10   ` Fabio Estevam
2018-05-30 18:10   ` Fabio Estevam
2018-05-31  9:20 ` [PATCH] " Nikita Yushchenko
2018-05-31  9:20   ` Nikita Yushchenko
2018-05-31  9:20   ` Nikita Yushchenko
2018-06-20 22:07 ` [PATCH] " Fabio Estevam
2018-06-20 22:07   ` Fabio Estevam
2018-06-20 22:07   ` Fabio Estevam
2018-06-20 22:22   ` Fabio Estevam [this message]
2018-06-20 22:22     ` [PATCH] " Fabio Estevam
2018-06-20 22:22     ` Fabio Estevam
2018-06-21 12:47     ` [PATCH] " Andrey Smirnov
2018-06-21 12:47       ` Andrey Smirnov
2018-06-21 12:47       ` Andrey Smirnov
2018-06-21 14:08       ` [PATCH] " Fabio Estevam
2018-06-21 14:08         ` Fabio Estevam
2018-06-21 14:08         ` Fabio Estevam
2018-06-21 21:44         ` [PATCH] " Andrey Smirnov
2018-06-21 21:44           ` Andrey Smirnov
2018-06-21 21:44           ` Andrey Smirnov
2018-06-22 16:27           ` [PATCH] " Fabio Estevam
2018-06-22 16:27             ` Fabio Estevam
2018-06-22 16:27             ` Fabio Estevam
2018-06-24 22:40             ` [PATCH] " Andrey Smirnov
2018-06-24 22:40               ` Andrey Smirnov
2018-06-24 22:40               ` Andrey Smirnov
2018-06-24 23:51               ` [PATCH] " Fabio Estevam
2018-06-24 23:51                 ` Fabio Estevam
2018-06-24 23:51                 ` Fabio Estevam
2018-06-25 12:18                 ` [PATCH] " Sebastian Reichel
2018-06-25 12:18                   ` Sebastian Reichel
2018-06-25 12:18                   ` Sebastian Reichel
2018-06-25 12:26                   ` [PATCH] " Fabio Estevam
2018-06-25 12:26                     ` Fabio Estevam
2018-06-25 12:26                     ` Fabio Estevam
2018-06-21 14:12       ` [PATCH] " Nikita Yushchenko
2018-06-21 14:12         ` Nikita Yushchenko
2018-06-21 14:12         ` Nikita Yushchenko
2018-06-21 14:25         ` [PATCH] " Nikita Yushchenko
2018-06-21 14:25           ` Nikita Yushchenko
2018-06-21 14:25           ` Nikita Yushchenko
2018-06-22  0:49           ` [PATCH] " Peter Chen
2018-06-22  0:49             ` Peter Chen
2018-06-22  0:49             ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5DJj=oQfsB-vNP=81HCiy-69j-5U+Km9P6LxGpnLx9xzg@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=peter.chen@nxp.com \
    --cc=sebastian.reichel@collabora.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.