* [PATCH] dw_dmac: print out DW_PARAMS and DWC_PARAMS when debug
@ 2013-01-18 15:10 Andy Shevchenko
2013-01-20 3:51 ` Viresh Kumar
2013-01-28 12:10 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2013-01-18 15:10 UTC (permalink / raw)
To: Viresh Kumar, Vinod Koul, linux-kernel, spear-devel; +Cc: Andy Shevchenko
It's usefull to have the values of the DW_PARAMS and DWC_PARAMS printed when
debug mode is enabled.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/dw_dmac.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 1498b27..72e6316 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1610,6 +1610,8 @@ static int dw_probe(struct platform_device *pdev)
dw_params = dma_read_byaddr(regs, DW_PARAMS);
autocfg = dw_params >> DW_PARAMS_EN & 0x1;
+ dev_dbg(&pdev->dev, "DW_PARAMS: 0x%08x\n", dw_params);
+
pdata = dev_get_platdata(&pdev->dev);
if (!pdata)
pdata = dw_dma_parse_dt(pdev);
@@ -1723,6 +1725,9 @@ static int dw_probe(struct platform_device *pdev)
dwc_params = dma_read_byaddr(regs + r * sizeof(u32),
DWC_PARAMS);
+ dev_dbg(&pdev->dev, "DWC_PARAMS[%d]: 0x%08x\n", i,
+ dwc_params);
+
/* Decode maximum block size for given channel. The
* stored 4 bit value represents blocks from 0x00 for 3
* up to 0x0a for 4095. */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dw_dmac: print out DW_PARAMS and DWC_PARAMS when debug
2013-01-18 15:10 [PATCH] dw_dmac: print out DW_PARAMS and DWC_PARAMS when debug Andy Shevchenko
@ 2013-01-20 3:51 ` Viresh Kumar
2013-01-28 12:10 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2013-01-20 3:51 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Vinod Koul, linux-kernel, spear-devel
On Fri, Jan 18, 2013 at 8:40 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> It's usefull to have the values of the DW_PARAMS and DWC_PARAMS printed when
> debug mode is enabled.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dw_dmac: print out DW_PARAMS and DWC_PARAMS when debug
2013-01-18 15:10 [PATCH] dw_dmac: print out DW_PARAMS and DWC_PARAMS when debug Andy Shevchenko
2013-01-20 3:51 ` Viresh Kumar
@ 2013-01-28 12:10 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2013-01-28 12:10 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Viresh Kumar, linux-kernel, spear-devel
On Fri, Jan 18, 2013 at 05:10:59PM +0200, Andy Shevchenko wrote:
> It's usefull to have the values of the DW_PARAMS and DWC_PARAMS printed when
> debug mode is enabled.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-28 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-18 15:10 [PATCH] dw_dmac: print out DW_PARAMS and DWC_PARAMS when debug Andy Shevchenko
2013-01-20 3:51 ` Viresh Kumar
2013-01-28 12:10 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.