From: Ulf Hansson <ulf.hansson@linaro.org> To: "Jérôme Pouiller" <jerome.pouiller@silabs.com> Cc: linux-wireless <linux-wireless@vger.kernel.org>, netdev <netdev@vger.kernel.org>, driverdevel <devel@driverdev.osuosl.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Kalle Valo" <kvalo@codeaurora.org>, "David S . Miller" <davem@davemloft.net>, DTML <devicetree@vger.kernel.org>, "Rob Herring" <robh+dt@kernel.org>, linux-mmc <linux-mmc@vger.kernel.org>, "Pali Rohár" <pali@kernel.org> Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c Date: Tue, 23 Mar 2021 15:11:56 +0100 [thread overview] Message-ID: <CAPDyKFoXgV3m-rMKfjqRj91PNjOGaWg6odWG-EGdFKkL+dGWoA@mail.gmail.com> (raw) In-Reply-To: <4503971.bAhddQ8uqO@pc-42> On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller <jerome.pouiller@silabs.com> wrote: > > Hello Ulf, > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller > > <Jerome.Pouiller@silabs.com> wrote: > > > > > > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > --- > > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +++++++++++++++++++++ > > > 1 file changed, 259 insertions(+) > > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > [...] > > > > > +static const struct sdio_device_id wfx_sdio_ids[] = { > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, > > > + { }, > > > +}; > > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > > > + > > > +struct sdio_driver wfx_sdio_driver = { > > > + .name = "wfx-sdio", > > > + .id_table = wfx_sdio_ids, > > > + .probe = wfx_sdio_probe, > > > + .remove = wfx_sdio_remove, > > > + .drv = { > > > + .owner = THIS_MODULE, > > > + .of_match_table = wfx_sdio_of_match, > > > > It's not mandatory to support power management, like system > > suspend/resume. However, as this looks like this is a driver for an > > embedded SDIO device, you probably want this. > > > > If that is the case, please assign the dev_pm_ops here and implement > > the ->suspend|resume() callbacks. > > I have no platform to test suspend/resume, so I have only a > theoretical understanding of this subject. I see. > > I understanding is that with the current implementation, the > device will be powered off on suspend and then totally reset > (including reloading of the firmware) on resume. I am wrong? You are correct, for a *removable* SDIO card. In this case, the mmc/sdio core will remove the corresponding SDIO card/device and its corresponding SDIO func devices at system suspend. It will then be redetected at system resume (and the SDIO func driver re-probed). Although, as this is an embedded SDIO device, per definition it's not a removable card (MMC_CAP_NONREMOVABLE should be set for the corresponding mmc host), the SDIO card will stick around and instead the ->suspend|resume() callback needs to be implemented for the SDIO func driver. > > This behavior sounds correct to me. You would expect something > more? Yes, see above. Kind regards Uffe
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org> To: "Jérôme Pouiller" <jerome.pouiller@silabs.com> Cc: driverdevel <devel@driverdev.osuosl.org>, DTML <devicetree@vger.kernel.org>, netdev <netdev@vger.kernel.org>, linux-wireless <linux-wireless@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, linux-mmc <linux-mmc@vger.kernel.org>, "Pali Rohár" <pali@kernel.org>, "David S . Miller" <davem@davemloft.net>, "Kalle Valo" <kvalo@codeaurora.org> Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c Date: Tue, 23 Mar 2021 15:11:56 +0100 [thread overview] Message-ID: <CAPDyKFoXgV3m-rMKfjqRj91PNjOGaWg6odWG-EGdFKkL+dGWoA@mail.gmail.com> (raw) In-Reply-To: <4503971.bAhddQ8uqO@pc-42> On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller <jerome.pouiller@silabs.com> wrote: > > Hello Ulf, > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller > > <Jerome.Pouiller@silabs.com> wrote: > > > > > > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > --- > > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +++++++++++++++++++++ > > > 1 file changed, 259 insertions(+) > > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > [...] > > > > > +static const struct sdio_device_id wfx_sdio_ids[] = { > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, > > > + { }, > > > +}; > > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > > > + > > > +struct sdio_driver wfx_sdio_driver = { > > > + .name = "wfx-sdio", > > > + .id_table = wfx_sdio_ids, > > > + .probe = wfx_sdio_probe, > > > + .remove = wfx_sdio_remove, > > > + .drv = { > > > + .owner = THIS_MODULE, > > > + .of_match_table = wfx_sdio_of_match, > > > > It's not mandatory to support power management, like system > > suspend/resume. However, as this looks like this is a driver for an > > embedded SDIO device, you probably want this. > > > > If that is the case, please assign the dev_pm_ops here and implement > > the ->suspend|resume() callbacks. > > I have no platform to test suspend/resume, so I have only a > theoretical understanding of this subject. I see. > > I understanding is that with the current implementation, the > device will be powered off on suspend and then totally reset > (including reloading of the firmware) on resume. I am wrong? You are correct, for a *removable* SDIO card. In this case, the mmc/sdio core will remove the corresponding SDIO card/device and its corresponding SDIO func devices at system suspend. It will then be redetected at system resume (and the SDIO func driver re-probed). Although, as this is an embedded SDIO device, per definition it's not a removable card (MMC_CAP_NONREMOVABLE should be set for the corresponding mmc host), the SDIO card will stick around and instead the ->suspend|resume() callback needs to be implemented for the SDIO func driver. > > This behavior sounds correct to me. You would expect something > more? Yes, see above. Kind regards Uffe _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-03-23 14:13 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 13:24 [PATCH v5 00/24] wfx: get out from the staging area Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 02/24] dt-bindings: introduce silabs,wfx.yaml Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-23 22:42 ` Rob Herring 2021-03-23 22:42 ` Rob Herring 2021-03-15 13:24 ` [PATCH v5 03/24] wfx: add Makefile/Kconfig Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 15:11 ` Leon Romanovsky 2021-03-15 15:11 ` Leon Romanovsky 2021-03-15 16:21 ` Jérôme Pouiller 2021-03-15 16:21 ` Jérôme Pouiller 2021-03-17 4:25 ` Leon Romanovsky 2021-03-17 4:25 ` Leon Romanovsky 2021-03-15 13:24 ` [PATCH v5 04/24] wfx: add wfx.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 05/24] wfx: add main.c/main.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 06/24] wfx: add bus.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 07/24] wfx: add bus_spi.c Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 08/24] wfx: add bus_sdio.c Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-22 12:20 ` Ulf Hansson 2021-03-22 12:20 ` Ulf Hansson 2021-03-22 17:14 ` Jérôme Pouiller 2021-03-22 17:14 ` Jérôme Pouiller 2021-03-23 14:11 ` Ulf Hansson [this message] 2021-03-23 14:11 ` Ulf Hansson 2021-03-23 17:53 ` Jérôme Pouiller 2021-03-23 17:53 ` Jérôme Pouiller 2021-03-23 19:12 ` Ulf Hansson 2021-03-23 19:12 ` Ulf Hansson 2021-04-07 12:00 ` Kalle Valo 2021-04-07 12:00 ` Kalle Valo 2021-04-12 8:22 ` Ulf Hansson 2021-04-12 8:22 ` Ulf Hansson 2021-10-01 12:31 ` Kalle Valo 2021-11-08 17:27 ` Ulf Hansson 2021-03-15 13:24 ` [PATCH v5 09/24] wfx: add hwio.c/hwio.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 10/24] wfx: add fwio.c/fwio.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 11/24] wfx: add bh.c/bh.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 12/24] wfx: add hif_api_*.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 13/24] wfx: add hif_tx*.c/hif_tx*.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 14/24] wfx: add key.c/key.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 15/24] wfx: add hif_rx.c/hif_rx.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 16/24] wfx: add data_rx.c/data_rx.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 17/24] wfx: add queue.c/queue.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 18/24] wfx: add data_tx.c/data_tx.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 19/24] wfx: add sta.c/sta.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 20/24] wfx: add scan.c/scan.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 21/24] wfx: add debug.c/debug.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:24 ` [PATCH v5 22/24] wfx: add traces.h Jerome Pouiller 2021-03-15 13:24 ` Jerome Pouiller 2021-03-15 13:25 ` [PATCH v5 23/24] wfx: remove from the staging area Jerome Pouiller 2021-03-15 13:25 ` Jerome Pouiller 2021-03-15 13:25 ` [PATCH v5 24/24] wfx: get out " Jerome Pouiller 2021-03-15 13:25 ` Jerome Pouiller 2021-03-15 21:09 ` kernel test robot 2021-03-15 21:09 ` kernel test robot 2021-03-15 21:09 ` kernel test robot 2021-03-15 21:09 ` [PATCH] wfx: fix irqf_oneshot.cocci warnings kernel test robot 2021-03-15 21:09 ` kernel test robot 2021-03-15 21:09 ` kernel test robot 2021-03-16 7:53 ` Jérôme Pouiller 2021-03-16 7:53 ` Jérôme Pouiller 2021-03-16 7:53 ` Jérôme Pouiller 2021-03-16 8:03 ` [kbuild-all] " Li, Philip 2021-03-16 8:03 ` Li, Philip 2021-03-16 8:03 ` [kbuild-all] " Li, Philip
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPDyKFoXgV3m-rMKfjqRj91PNjOGaWg6odWG-EGdFKkL+dGWoA@mail.gmail.com \ --to=ulf.hansson@linaro.org \ --cc=davem@davemloft.net \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jerome.pouiller@silabs.com \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pali@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.