From: Drew Fustini <drew@beagleboard.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, Josh S <josh@macchina.cc>
Subject: Re: mcp251xfd on RPi 5.4 downstream
Date: Sat, 24 Oct 2020 23:30:41 -0500 [thread overview]
Message-ID: <CAPgEAj6nQOAQ9NNB2QBbARuqWm5K62QW+NsqPROzcQOZqe-F+g@mail.gmail.com> (raw)
In-Reply-To: <CAPgEAj7JLUjWiN8LdGV9OfQScsUkPVcs9bSE+w_9G0c9BNd-sg@mail.gmail.com>
On Thu, Oct 22, 2020 at 1:42 PM Drew Fustini <drew@beagleboard.org> wrote:
>
> On Thu, Oct 22, 2020 at 1:33 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> >
> > On 10/22/20 8:00 AM, Drew Fustini wrote:
> > > It appears it was simpler to get it to compile than I expected.
> >
> > \o/
> >
> > > cs_change_delay.unit becomes cs_change_delay_unit, and
> > > cs_change_delay.value becomes cs_change_delay.
> > >
> > > The other issue was 728fc9ff73d3 ("can: rx-offload:
> > > can_rx_offload_add_manual(): add new initialization function") which
> > > was simply solved by adding can_rx_offload_add_manual() to:
> > > include/linux/can/rx-offload.h
> > > drivers/net/can/rx-offload.c
> > >
> > > The driver builds ok:
> >
> > With your help :) I backported current linus/master to the rpi-5.4:
> >
> > https://github.com/marckleinebudde/linux/tree/v5.4-rpi/mcp251xfd-20201022-54
> >
> > Can you test that?
>
> Thanks, will do. I am currently trying to finish up my ELC-E talk
> prep :) but will get back to you with the results of testing later.
I noticed up doing a modprobe that there are several Unknown symbol errors.
Any ideas?
[ 358.686691] mcp251xfd: Unknown symbol can_rx_offload_del (err -2)
[ 358.686744] mcp251xfd: Unknown symbol can_put_echo_skb (err -2)
[ 358.686796] mcp251xfd: Unknown symbol can_len2dlc (err -2)
[ 358.686844] mcp251xfd: Unknown symbol alloc_canfd_skb (err -2)
[ 358.686942] mcp251xfd: Unknown symbol open_candev (err -2)
[ 358.687042] mcp251xfd: Unknown symbol alloc_can_skb (err -2)
[ 358.687093] mcp251xfd: Unknown symbol unregister_candev (err -2)
[ 358.687139] mcp251xfd: Unknown symbol can_change_state (err -2)
[ 358.687183] mcp251xfd: Unknown symbol can_change_mtu (err -2)
[ 358.687227] mcp251xfd: Unknown symbol can_rx_offload_add_manual (err -2)
[ 358.687294] mcp251xfd: Unknown symbol free_candev (err -2)
[ 358.687345] mcp251xfd: Unknown symbol alloc_candev_mqs (err -2)
[ 358.687416] mcp251xfd: Unknown symbol close_candev (err -2)
[ 358.687475] mcp251xfd: Unknown symbol can_bus_off (err -2)
[ 358.687519] mcp251xfd: Unknown symbol can_rx_offload_enable (err -2)
[ 358.687569] mcp251xfd: Unknown symbol can_rx_offload_get_echo_skb (err -2)
[ 358.687656] mcp251xfd: Unknown symbol can_dlc2len (err -2)
[ 358.687710] mcp251xfd: Unknown symbol alloc_can_err_skb (err -2)
[ 358.687773] mcp251xfd: Unknown symbol can_rx_offload_queue_sorted (err -2)
[ 358.687819] mcp251xfd: Unknown symbol register_candev (err -2)
[ 369.092608] CAN device driver interface
root@raspberrypi:~# modinfo mcp251xfd
filename:
/lib/modules/5.4.72-v7l+/kernel/drivers/net/can/spi/mcp251xfd/mcp251xfd.ko
license: GPL v2
description: Microchip MCP251xFD Family CAN controller driver
author: Marc Kleine-Budde <mkl@pengutronix.de>
srcversion: 1E05EEB5939E9AB22BA2E1B
alias: spi:mcp251xfd
alias: spi:mcp2518fd
alias: spi:mcp2517fd
alias: of:N*T*Cmicrochip,mcp251xfdC*
alias: of:N*T*Cmicrochip,mcp251xfd
alias: of:N*T*Cmicrochip,mcp2518fdC*
alias: of:N*T*Cmicrochip,mcp2518fd
alias: of:N*T*Cmicrochip,mcp2517fdC*
alias: of:N*T*Cmicrochip,mcp2517fd
depends: can-dev
intree: Y
name: mcp251xfd
vermagic: 5.4.72-v7l+ SMP mod_unload modversions ARMv7 p2v8
root@raspberrypi:~# lsmod |grep mcp
mcp251xfd 36864 0
can_dev 28672 1 mcp251xfd
Thanks,
Drew
next prev parent reply other threads:[~2020-10-25 4:30 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 3:10 mcp251xfd on RPi 5.4 downstream Drew Fustini
2020-10-22 6:00 ` Drew Fustini
2020-10-22 6:33 ` Marc Kleine-Budde
2020-10-22 18:42 ` Drew Fustini
2020-10-25 4:30 ` Drew Fustini [this message]
2020-10-25 8:49 ` Oliver Hartkopp
2020-10-25 10:58 ` Marc Kleine-Budde
2020-10-25 17:43 ` Patrick Menschel
2020-10-25 18:14 ` Marc Kleine-Budde
2020-10-25 18:42 ` Patrick Menschel
2020-10-26 1:59 ` Drew Fustini
2020-10-26 2:50 ` Drew Fustini
2020-10-26 5:16 ` Patrick Menschel
2020-10-26 7:45 ` Marc Kleine-Budde
2020-10-26 9:40 ` Marc Kleine-Budde
2020-10-26 16:51 ` Patrick Menschel
2020-10-26 17:00 ` Marc Kleine-Budde
2020-10-27 2:22 ` Drew Fustini
2020-10-27 6:35 ` Drew Fustini
2020-10-27 7:06 ` Marc Kleine-Budde
2020-10-27 18:18 ` Patrick Menschel
2020-10-27 18:22 ` Marc Kleine-Budde
2020-10-28 1:57 ` Drew Fustini
2020-10-28 3:47 ` Drew Fustini
2020-10-28 7:57 ` Marc Kleine-Budde
2020-10-31 12:27 ` Drew Fustini
2020-10-31 15:14 ` Patrick Menschel
2020-10-31 15:35 ` Patrick Menschel
2020-10-31 21:57 ` Drew Fustini
2020-11-01 22:49 ` Drew Fustini
2020-11-02 7:25 ` Marc Kleine-Budde
2020-11-02 8:18 ` Marc Kleine-Budde
[not found] ` <CAPgEAj7LcX3cb+syhtR1i3Uo1XkYYFQ_wDPV8GniaA-YwPk2Hg@mail.gmail.com>
2020-11-02 11:00 ` Marc Kleine-Budde
[not found] ` <CAPgEAj7BTJyiBg4QkKuekYH0zyrA-10dby3Lgb5qj2uiD4ZOYQ@mail.gmail.com>
2020-11-02 14:22 ` mcp251xfd: loopback test on waveshare canfd hat Marc Kleine-Budde
2020-11-02 14:35 ` Drew Fustini
2020-11-02 14:38 ` Marc Kleine-Budde
2020-11-02 17:34 ` mcp251xfd on RPi 5.4 downstream Patrick Menschel
2020-11-02 18:47 ` Patrick Menschel
2020-11-02 18:57 ` Thomas.Kopp
2020-11-02 19:32 ` Patrick Menschel
2020-11-04 18:48 ` Patrick Menschel
2020-11-05 7:15 ` Marc Kleine-Budde
2020-11-05 18:11 ` Patrick Menschel
2020-11-06 9:00 ` Marc Kleine-Budde
2020-11-06 11:31 ` Patrick Menschel
2020-11-06 11:36 ` Marc Kleine-Budde
2020-11-06 11:46 ` Patrick Menschel
2020-11-05 8:08 ` Marc Kleine-Budde
2020-11-05 8:07 ` Marc Kleine-Budde
2020-11-02 7:55 ` Marc Kleine-Budde
2020-11-02 7:26 ` Marc Kleine-Budde
2020-10-26 7:43 ` Marc Kleine-Budde
2020-11-20 12:32 ` Marc Kleine-Budde
[not found] ` <CAEf4M_B68X2T0rkaq0tqahBFPc+Gbvac7-+G0j5jd-g4j+j01g@mail.gmail.com>
2020-11-20 13:16 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPgEAj6nQOAQ9NNB2QBbARuqWm5K62QW+NsqPROzcQOZqe-F+g@mail.gmail.com \
--to=drew@beagleboard.org \
--cc=josh@macchina.cc \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.