[U-Boot] [PATCH v1] mmc: sdhci: SDHCI controllers also need power

From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] mmc: sdhci: SDHCI controllers also need power
Date: Sun, 19 Mar 2017 20:30:04 -0600	[thread overview]
Message-ID: <CAPnjgZ0Qhu8AGP1ROs-GAbA97jCkK2hSHYxKEAa1rpeL9sxp1w@mail.gmail.com> (raw)
In-Reply-To: <20170315182521.4359-1-andriy.shevchenko@linux.intel.com>

Hi Andy,

On 15 March 2017 at 12:25, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On some systems SDHCI controllers may be powered off and it's required
> to bring them on before accessing.
>
> SDHCI generic driver currently lacks any mean of doing it. Call the same
> board_power_mmc_init() at sdhci_init() stage.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mmc/sdhci.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> index 93cefd89cd..54a7e379ff 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -469,6 +469,8 @@ static int sdhci_init(struct mmc *mmc)
>  {
>         struct sdhci_host *host = mmc->priv;
>
> +       board_mmc_power_init();

You should be using driver model for this (CONFIG_DM_MMC*). So either
get the power supply from the device tree and enable it, or do this in
the board code.

> +
>         sdhci_reset(host, SDHCI_RESET_ALL);
>
>         if ((host->quirks & SDHCI_QUIRK_32BIT_DMA_ADDR) && !aligned_buffer) {
> --
> 2.11.0
>

Regards,
Simon