[PATCH] lib: rsa: rsa-sign: Minor bug in debug message

[PATCH] lib: rsa: rsa-sign: Minor bug in debug message

[Chan, Donald]

*sig_size isn't set until later so use the correct variables.

Signed-off-by: Donald Chan <hoiho@lab126.com>
---
  lib/rsa/rsa-sign.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c
index f70f352311..5b85d61a13 100644
--- a/lib/rsa/rsa-sign.c
+++ b/lib/rsa/rsa-sign.c
@@ -482,7 +482,7 @@ static int rsa_sign_with_key(EVP_PKEY *pkey, struct 
padding_algo *padding_algo,
  	#endif
  	EVP_MD_CTX_destroy(context);

-	debug("Got signature: %d bytes, expected %zu\n", *sig_size, size);
+	debug("Got signature: %zu bytes, expected %d\n", size, 
EVP_PKEY_size(pkey));
  	*sigp = sig;
  	*sig_size = size;

-- 
2.16.6

Re: [PATCH] lib: rsa: rsa-sign: Minor bug in debug message

[Simon Glass]

On Mon, 19 Jul 2021 at 10:18, Chan, Donald <hoiho@lab126.com> wrote:
>
> *sig_size isn't set until later so use the correct variables.
>
> Signed-off-by: Donald Chan <hoiho@lab126.com>
> ---
>   lib/rsa/rsa-sign.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH] lib: rsa: rsa-sign: Minor bug in debug message

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

On Mon, Jul 19, 2021 at 09:18:54AM -0700, Chan, Donald wrote:

> *sig_size isn't set until later so use the correct variables.
> 
> Signed-off-by: Donald Chan <hoiho@lab126.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]