All of lore.kernel.org
 help / color / mirror / Atom feed
* remove static integer at uvd power gate to fix two gpu core boot up
@ 2016-12-21  7:31 Tao, Yintian
       [not found] ` <CY1PR12MB08399D7CE3500C4373CF023EE5930-1s8aH8ViOEfL8a+y8HKU/gdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Tao, Yintian @ 2016-12-21  7:31 UTC (permalink / raw)
  To: Deucher, Alexander; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW


[-- Attachment #1.1: Type: text/plain, Size: 87 bytes --]

Hi  Alex


Please help have a review. Thanks a lot.


Best Regards
Yintian Tao

[-- Attachment #1.2: Type: text/html, Size: 2148 bytes --]

[-- Attachment #2: 0001-drm-amdgpu-remove-static-integer-for-uvd-pp-state.patch --]
[-- Type: application/octet-stream, Size: 1211 bytes --]

From 4dc506b04bf2c27326b20a54539cf3717c7543c1 Mon Sep 17 00:00:00 2001
From: Yintian Tao <yttao@amd.com>
Date: Wed, 21 Dec 2016 14:32:21 +0800
Subject: [PATCH] drm/amdgpu: remove static integer for uvd pp state

At two gpu core condition, static integer will cause that second gpu
core uvd state setting will be directly skipped due to the first one
setting

Change-Id: I71eb7bd842b9551ba41e9a448e5b79bef42a55ae
Signed-off-by: Yintian Tao <yttao@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c
index a79e283..6de6bec 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c
@@ -791,15 +791,10 @@ static int uvd_v5_0_set_clockgating_state(void *handle,
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 	bool enable = (state == AMD_CG_STATE_GATE) ? true : false;
-	static int curstate = -1;
 
 	if (!(adev->cg_flags & AMD_CG_SUPPORT_UVD_MGCG))
 		return 0;
 
-	if (curstate == state)
-		return 0;
-
-	curstate = state;
 	if (enable) {
 		/* wait for STATUS to clear */
 		if (uvd_v5_0_wait_for_idle(handle))
-- 
1.9.1


[-- Attachment #3: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: remove static integer at uvd power gate to fix two gpu core boot up
       [not found] ` <CY1PR12MB08399D7CE3500C4373CF023EE5930-1s8aH8ViOEfL8a+y8HKU/gdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-12-21 16:42   ` Deucher, Alexander
  0 siblings, 0 replies; 2+ messages in thread
From: Deucher, Alexander @ 2016-12-21 16:42 UTC (permalink / raw)
  To: Tao, Yintian; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW


[-- Attachment #1.1: Type: text/plain, Size: 396 bytes --]

Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

From: Tao, Yintian
Sent: Wednesday, December 21, 2016 2:31 AM
To: Deucher, Alexander
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: remove static integer at uvd power gate to fix two gpu core boot up

Hi  Alex


Please help have a review. Thanks a lot.


Best Regards
Yintian Tao

[-- Attachment #1.2: Type: text/html, Size: 3077 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-21 16:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-21  7:31 remove static integer at uvd power gate to fix two gpu core boot up Tao, Yintian
     [not found] ` <CY1PR12MB08399D7CE3500C4373CF023EE5930-1s8aH8ViOEfL8a+y8HKU/gdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-12-21 16:42   ` Deucher, Alexander

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.