[PATCH 0/1] riscv: dts: fu740: Add PDMA node

[PATCH 0/1] riscv: dts: fu740: Add PDMA node

[v.v.mitrofanov]

Sifive FU740 supports PDMA but is not implemented in DT. The same
PDMA module implemented in FU750 chip. I added DT description with all
required fields. I also tested PDMA robust with drivers/dma/dmatest.ko test.

v.v.mitrofanov (1):
  riscv: dts: fu740: Add PDMA node

 arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.30.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH 1/1] riscv: dts: fu740: Add PDMA node

[v.v.mitrofanov]

HiFive unmatched supports PDMA but is not implemented in DT.

Add the PDMA node in SiFive FU740 soc-specific DT file.

Signed-off-by: v.v.mitrofanov <v.v.mitrofanov@yadro.com>
---
 arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
index 64ff2e758336..833fb4f4376b 100644
--- a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
@@ -164,6 +164,13 @@ prci: clock-controller@10000000 {
 			#clock-cells = <1>;
 			#reset-cells = <1>;
 		};
+		dma: dma@3000000 {
+			compatible = "sifive,fu540-c000-pdma";
+			reg = <0x0 0x3000000 0x0 0x8000>;
+			interrupt-parent = <&plic0>;
+			interrupts = <11 12 13 14 15 16 17 18>;
+			#dma-cells = <1>;
+		};
 		uart0: serial@10010000 {
 			compatible = "sifive,fu740-c000-uart", "sifive,uart0";
 			reg = <0x0 0x10010000 0x0 0x1000>;
-- 
2.30.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 1/1] riscv: dts: fu740: Add PDMA node

[Jessica Clarke]

On 3 Dec 2021, at 09:57, v.v.mitrofanov <v.v.mitrofanov@yadro.com> wrote:
> 
> HiFive unmatched supports PDMA but is not implemented in DT.
> 
> Add the PDMA node in SiFive FU740 soc-specific DT file.
> 
> Signed-off-by: v.v.mitrofanov <v.v.mitrofanov@yadro.com>
> ---
> arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> index 64ff2e758336..833fb4f4376b 100644
> --- a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> @@ -164,6 +164,13 @@ prci: clock-controller@10000000 {
> 			#clock-cells = <1>;
> 			#reset-cells = <1>;
> 		};
> +		dma: dma@3000000 {
> +			compatible = "sifive,fu540-c000-pdma";

I know the PLIC and CGEM devices abuse fu540-specific compatible
strings (which it would be great to fix; FreeBSD is already prepared
for that, though it’d also be nice to introduce a generic compatible
string for the SiFive CGEM rather than having just a SoC-specific one
given the FU540 and FU740 have the same interface), but let’s not make
things worse. This should say fu740, and there should also be a generic
SiFive PDMA compatible so we don’t need to add a new compatible to an
otherwise-unchanged driver every time a new SiFive SoC appears.

Jess

Re: [PATCH 1/1] riscv: dts: fu740: Add PDMA node

[Jessica Clarke]

On 3 Dec 2021, at 09:57, v.v.mitrofanov <v.v.mitrofanov@yadro.com> wrote:
> 
> HiFive unmatched supports PDMA but is not implemented in DT.
> 
> Add the PDMA node in SiFive FU740 soc-specific DT file.
> 
> Signed-off-by: v.v.mitrofanov <v.v.mitrofanov@yadro.com>
> ---
> arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> index 64ff2e758336..833fb4f4376b 100644
> --- a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> @@ -164,6 +164,13 @@ prci: clock-controller@10000000 {
> 			#clock-cells = <1>;
> 			#reset-cells = <1>;
> 		};
> +		dma: dma@3000000 {
> +			compatible = "sifive,fu540-c000-pdma";

I know the PLIC and CGEM devices abuse fu540-specific compatible
strings (which it would be great to fix; FreeBSD is already prepared
for that, though it’d also be nice to introduce a generic compatible
string for the SiFive CGEM rather than having just a SoC-specific one
given the FU540 and FU740 have the same interface), but let’s not make
things worse. This should say fu740, and there should also be a generic
SiFive PDMA compatible so we don’t need to add a new compatible to an
otherwise-unchanged driver every time a new SiFive SoC appears.

Jess


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv