[Buildroot] [PATCH 1/1] utils/getdeveloperlib.py: force foward-slash for pattern matching

[Buildroot] [PATCH 1/1] utils/getdeveloperlib.py: force foward-slash for pattern matching

[James Knight]

Force relative file path resolution of DEVELOPERS file entries to use
forward-slash separators since pattern matching assumes forward slashes.
This is to help permit uses invoking `get-developers` on Platforms where
`os.sep` may not be a forward slash.

Signed-off-by: James Knight <james.d.knight@live.com>
---
 utils/getdeveloperlib.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/utils/getdeveloperlib.py b/utils/getdeveloperlib.py
index b205817033d1d488c13e88f3b1bdbf82aa6b1224..fb8c7546d74f764468e6ffeb0d18b169aefb80d9 100644
--- a/utils/getdeveloperlib.py
+++ b/utils/getdeveloperlib.py
@@ -249,7 +249,10 @@ def parse_developers():
                 if len(dev_files) == 0:
                     print("WARNING: '%s' doesn't match any file" % fname,
                           file=sys.stderr)
-                files += [os.path.relpath(f, brpath) for f in dev_files]
+                for f in dev_files:
+                    dev_file = os.path.relpath(f, brpath)
+                    dev_file = dev_file.replace(os.sep, '/')  # force unix sep
+                    files.append(dev_file)
             elif line == "":
                 if not name:
                     continue
-- 
2.28.0.windows.1

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] utils/getdeveloperlib.py: force foward-slash for pattern matching

[Arnout Vandecappelle]

On 05/09/2021 03:35, James Knight wrote:
> Force relative file path resolution of DEVELOPERS file entries to use
> forward-slash separators since pattern matching assumes forward slashes.
> This is to help permit uses invoking `get-developers` on Platforms where
> `os.sep` may not be a forward slash.
> 
> Signed-off-by: James Knight <james.d.knight@live.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  utils/getdeveloperlib.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/getdeveloperlib.py b/utils/getdeveloperlib.py
> index b205817033d1d488c13e88f3b1bdbf82aa6b1224..fb8c7546d74f764468e6ffeb0d18b169aefb80d9 100644
> --- a/utils/getdeveloperlib.py
> +++ b/utils/getdeveloperlib.py
> @@ -249,7 +249,10 @@ def parse_developers():
>                  if len(dev_files) == 0:
>                      print("WARNING: '%s' doesn't match any file" % fname,
>                            file=sys.stderr)
> -                files += [os.path.relpath(f, brpath) for f in dev_files]
> +                for f in dev_files:
> +                    dev_file = os.path.relpath(f, brpath)
> +                    dev_file = dev_file.replace(os.sep, '/')  # force unix sep
> +                    files.append(dev_file)
>              elif line == "":
>                  if not name:
>                      continue
> 
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] utils/getdeveloperlib.py: force foward-slash for pattern matching

[Peter Korsgaard]

>>>>> "James" == James Knight <james.d.knight@live.com> writes:

 > Force relative file path resolution of DEVELOPERS file entries to use
 > forward-slash separators since pattern matching assumes forward slashes.
 > This is to help permit uses invoking `get-developers` on Platforms where
 > `os.sep` may not be a forward slash.

 > Signed-off-by: James Knight <james.d.knight@live.com>

Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot