* [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table
@ 2022-03-31 8:40 ` Peng Fan (OSS)
0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-03-31 8:40 UTC (permalink / raw)
To: bjorn.andersson, mathieu.poirier, shawnguo, s.hauer
Cc: linux-remoteproc, linux-kernel, kernel, festevam, linux-imx,
linux-arm-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Resource table is used by Linux to get information pubished by
remote processor. It should be not be used for memory allocation, so
not create rproc mem entry.
Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
Update commit log
Update Fixes tag
V2:
Add Fixes tag
Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
Address typo
drivers/remoteproc/imx_rproc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 7a096f1891e6..f2bfc9077c19 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
if (!strcmp(it.node->name, "vdev0buffer"))
continue;
+ if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
+ continue;
+
rmem = of_reserved_mem_lookup(it.node);
if (!rmem) {
dev_err(priv->dev, "unable to acquire memory-region\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table
@ 2022-03-31 8:40 ` Peng Fan (OSS)
0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-03-31 8:40 UTC (permalink / raw)
To: bjorn.andersson, mathieu.poirier, shawnguo, s.hauer
Cc: linux-remoteproc, linux-kernel, kernel, festevam, linux-imx,
linux-arm-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Resource table is used by Linux to get information pubished by
remote processor. It should be not be used for memory allocation, so
not create rproc mem entry.
Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
Update commit log
Update Fixes tag
V2:
Add Fixes tag
Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
Address typo
drivers/remoteproc/imx_rproc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 7a096f1891e6..f2bfc9077c19 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
if (!strcmp(it.node->name, "vdev0buffer"))
continue;
+ if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
+ continue;
+
rmem = of_reserved_mem_lookup(it.node);
if (!rmem) {
dev_err(priv->dev, "unable to acquire memory-region\n");
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table
2022-03-31 8:40 ` Peng Fan (OSS)
@ 2022-04-14 16:10 ` Mathieu Poirier
-1 siblings, 0 replies; 6+ messages in thread
From: Mathieu Poirier @ 2022-04-14 16:10 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: bjorn.andersson, shawnguo, s.hauer, linux-remoteproc,
linux-kernel, kernel, festevam, linux-imx, linux-arm-kernel,
Peng Fan
On Thu, Mar 31, 2022 at 04:40:07PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Resource table is used by Linux to get information pubished by
s/pubished/published
> remote processor. It should be not be used for memory allocation, so
> not create rproc mem entry.
>
> Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V3:
> Update commit log
> Update Fixes tag
>
> V2:
> Add Fixes tag
> Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
> Address typo
>
> drivers/remoteproc/imx_rproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..f2bfc9077c19 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> if (!strcmp(it.node->name, "vdev0buffer"))
> continue;
>
> + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> + continue;
> +
Any reason the handling of vdev0buffer is using strcmp() and the resource table
strncmp()?
Thanks,
Mathieu
> rmem = of_reserved_mem_lookup(it.node);
> if (!rmem) {
> dev_err(priv->dev, "unable to acquire memory-region\n");
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table
@ 2022-04-14 16:10 ` Mathieu Poirier
0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Poirier @ 2022-04-14 16:10 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: bjorn.andersson, shawnguo, s.hauer, linux-remoteproc,
linux-kernel, kernel, festevam, linux-imx, linux-arm-kernel,
Peng Fan
On Thu, Mar 31, 2022 at 04:40:07PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Resource table is used by Linux to get information pubished by
s/pubished/published
> remote processor. It should be not be used for memory allocation, so
> not create rproc mem entry.
>
> Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V3:
> Update commit log
> Update Fixes tag
>
> V2:
> Add Fixes tag
> Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
> Address typo
>
> drivers/remoteproc/imx_rproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..f2bfc9077c19 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> if (!strcmp(it.node->name, "vdev0buffer"))
> continue;
>
> + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> + continue;
> +
Any reason the handling of vdev0buffer is using strcmp() and the resource table
strncmp()?
Thanks,
Mathieu
> rmem = of_reserved_mem_lookup(it.node);
> if (!rmem) {
> dev_err(priv->dev, "unable to acquire memory-region\n");
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table
2022-04-14 16:10 ` Mathieu Poirier
@ 2022-04-15 2:47 ` Peng Fan
-1 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2022-04-15 2:47 UTC (permalink / raw)
To: Mathieu Poirier, Peng Fan (OSS)
Cc: bjorn.andersson, shawnguo, s.hauer, linux-remoteproc,
linux-kernel, kernel, festevam, dl-linux-imx, linux-arm-kernel
> Subject: Re: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for
> resource table
>
> On Thu, Mar 31, 2022 at 04:40:07PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Resource table is used by Linux to get information pubished by
>
> s/pubished/published
Fix in v4.
>
> > remote processor. It should be not be used for memory allocation, so
> > not create rproc mem entry.
> >
> > Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse
> > fw hook")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V3:
> > Update commit log
> > Update Fixes tag
> >
> > V2:
> > Add Fixes tag
> > Separate the patch from
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > hwork.kernel.org%2Fproject%2Flinux-
> remoteproc%2Fpatch%2F20220111033333
> > .403448-7-
> peng.fan%40oss.nxp.com%2F&data=04%7C01%7Cpeng.fan%40nxp.
> >
> com%7C091803e93988488b2cbc08da1e313fe7%7C686ea1d3bc2b4c6fa92cd99c
> 5c301
> >
> 635%7C0%7C0%7C637855494116073554%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wL
> >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&s
> data
> >
> =TDWgH8DNxGTQsen64f6Bqvr5t%2FmB7bA8qOF6Q9TlP34%3D&reserved=
> 0
> > Address typo
> >
> > drivers/remoteproc/imx_rproc.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> > if (!strcmp(it.node->name, "vdev0buffer"))
> > continue;
> >
> > + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > + continue;
> > +
>
> Any reason the handling of vdev0buffer is using strcmp() and the resource table
> strncmp()?
I thought rsc-table0/1 maybe there for cm40/cm41, but rsc-table should also be
ok, will use strcmp in v4.
Thanks,
Peng.
>
> Thanks,
> Mathieu
>
> > rmem = of_reserved_mem_lookup(it.node);
> > if (!rmem) {
> > dev_err(priv->dev, "unable to acquire memory-
> region\n");
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table
@ 2022-04-15 2:47 ` Peng Fan
0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2022-04-15 2:47 UTC (permalink / raw)
To: Mathieu Poirier, Peng Fan (OSS)
Cc: bjorn.andersson, shawnguo, s.hauer, linux-remoteproc,
linux-kernel, kernel, festevam, dl-linux-imx, linux-arm-kernel
> Subject: Re: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for
> resource table
>
> On Thu, Mar 31, 2022 at 04:40:07PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Resource table is used by Linux to get information pubished by
>
> s/pubished/published
Fix in v4.
>
> > remote processor. It should be not be used for memory allocation, so
> > not create rproc mem entry.
> >
> > Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse
> > fw hook")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V3:
> > Update commit log
> > Update Fixes tag
> >
> > V2:
> > Add Fixes tag
> > Separate the patch from
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > hwork.kernel.org%2Fproject%2Flinux-
> remoteproc%2Fpatch%2F20220111033333
> > .403448-7-
> peng.fan%40oss.nxp.com%2F&data=04%7C01%7Cpeng.fan%40nxp.
> >
> com%7C091803e93988488b2cbc08da1e313fe7%7C686ea1d3bc2b4c6fa92cd99c
> 5c301
> >
> 635%7C0%7C0%7C637855494116073554%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wL
> >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&s
> data
> >
> =TDWgH8DNxGTQsen64f6Bqvr5t%2FmB7bA8qOF6Q9TlP34%3D&reserved=
> 0
> > Address typo
> >
> > drivers/remoteproc/imx_rproc.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> > if (!strcmp(it.node->name, "vdev0buffer"))
> > continue;
> >
> > + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > + continue;
> > +
>
> Any reason the handling of vdev0buffer is using strcmp() and the resource table
> strncmp()?
I thought rsc-table0/1 maybe there for cm40/cm41, but rsc-table should also be
ok, will use strcmp in v4.
Thanks,
Peng.
>
> Thanks,
> Mathieu
>
> > rmem = of_reserved_mem_lookup(it.node);
> > if (!rmem) {
> > dev_err(priv->dev, "unable to acquire memory-
> region\n");
> > --
> > 2.25.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-15 2:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 8:40 [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table Peng Fan (OSS)
2022-03-31 8:40 ` Peng Fan (OSS)
2022-04-14 16:10 ` Mathieu Poirier
2022-04-14 16:10 ` Mathieu Poirier
2022-04-15 2:47 ` Peng Fan
2022-04-15 2:47 ` Peng Fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.