All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
@ 2021-09-29 21:18 ` David Heidelberg
  0 siblings, 0 replies; 6+ messages in thread
From: David Heidelberg @ 2021-09-29 21:18 UTC (permalink / raw)
  To: derek.fang
  Cc: broonie, lgirdwood, robh+dt, devicetree, linux-kernel,
	alsa-devel, lars, flove, oder_chiou, jack.yu, shumingf

Our CI seems to be happy again. Thanks

Reviewed-by: David Heidelberg <david@ixit.cz>
Best regards
David Heidelberg



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
@ 2021-09-29 21:18 ` David Heidelberg
  0 siblings, 0 replies; 6+ messages in thread
From: David Heidelberg @ 2021-09-29 21:18 UTC (permalink / raw)
  To: derek.fang
  Cc: oder_chiou, devicetree, alsa-devel, lars, jack.yu, lgirdwood,
	robh+dt, linux-kernel, broonie, shumingf, flove

Our CI seems to be happy again. Thanks

Reviewed-by: David Heidelberg <david@ixit.cz>
Best regards
David Heidelberg



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
  2021-09-29 13:04 ` derek.fang
@ 2021-09-30 14:58   ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-09-30 14:58 UTC (permalink / raw)
  To: derek.fang, lgirdwood
  Cc: Mark Brown, robh+dt, flove, alsa-devel, devicetree, jack.yu,
	linux-kernel, lars, shumingf, oder_chiou

On Wed, 29 Sep 2021 21:04:06 +0800, derek.fang@realtek.com wrote:
> From: Derek Fang <derek.fang@realtek.com>
> 
> Fix the device-tree schema errors that be reported by using 'make
> dt_binding_check'.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
      commit: 91cf45595021bd6f6279748aa472de7fc7864084

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
@ 2021-09-30 14:58   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-09-30 14:58 UTC (permalink / raw)
  To: derek.fang, lgirdwood
  Cc: oder_chiou, devicetree, alsa-devel, lars, jack.yu, linux-kernel,
	robh+dt, Mark Brown, shumingf, flove

On Wed, 29 Sep 2021 21:04:06 +0800, derek.fang@realtek.com wrote:
> From: Derek Fang <derek.fang@realtek.com>
> 
> Fix the device-tree schema errors that be reported by using 'make
> dt_binding_check'.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
      commit: 91cf45595021bd6f6279748aa472de7fc7864084

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
@ 2021-09-29 13:04 ` derek.fang
  0 siblings, 0 replies; 6+ messages in thread
From: derek.fang @ 2021-09-29 13:04 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: robh+dt, devicetree, linux-kernel, alsa-devel, lars, flove,
	oder_chiou, jack.yu, shumingf, Derek Fang

From: Derek Fang <derek.fang@realtek.com>

Fix the device-tree schema errors that be reported by using 'make
dt_binding_check'.

Signed-off-by: Derek Fang <derek.fang@realtek.com>
---
 .../devicetree/bindings/sound/realtek,rt5682s.yaml   | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index 7a5f1d0fd3e2..2b8b7b51fe55 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -29,6 +29,8 @@ properties:
       - 0 # dmic1 data is not used
       - 1 # using GPIO2 pin as dmic1 data pin
       - 2 # using GPIO5 pin as dmic1 data pin
+    description: |
+      Specify which GPIO pin be used as DMIC1 data pin.
 
   realtek,dmic1-clk-pin:
     $ref: /schemas/types.yaml#/definitions/uint32
@@ -36,12 +38,16 @@ properties:
       - 0 # dmic1 clk is not used
       - 1 # using GPIO1 pin as dmic1 clock pin
       - 2 # using GPIO3 pin as dmic1 clock pin
+    description: |
+      Specify which GPIO pin be used as DMIC1 clk pin.
 
   realtek,jd-src:
     $ref: /schemas/types.yaml#/definitions/uint32
     enum:
       - 0 # No JD is used
       - 1 # using JD1 as JD source
+    description: |
+      Specify which JD source be used.
 
   realtek,ldo1-en-gpios:
     description: |
@@ -72,9 +78,9 @@ properties:
     const: 1
 
   clock-output-names:
-    items:
-      - description: Name given for DAI word clock output.
-      - description: Name given for DAI bit clock output.
+    minItems: 2
+    maxItems: 2
+    description: Name given for DAI word clock and bit clock outputs.
 
 additionalProperties: false
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
@ 2021-09-29 13:04 ` derek.fang
  0 siblings, 0 replies; 6+ messages in thread
From: derek.fang @ 2021-09-29 13:04 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: oder_chiou, devicetree, alsa-devel, lars, jack.yu, linux-kernel,
	robh+dt, Derek Fang, shumingf, flove

From: Derek Fang <derek.fang@realtek.com>

Fix the device-tree schema errors that be reported by using 'make
dt_binding_check'.

Signed-off-by: Derek Fang <derek.fang@realtek.com>
---
 .../devicetree/bindings/sound/realtek,rt5682s.yaml   | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index 7a5f1d0fd3e2..2b8b7b51fe55 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -29,6 +29,8 @@ properties:
       - 0 # dmic1 data is not used
       - 1 # using GPIO2 pin as dmic1 data pin
       - 2 # using GPIO5 pin as dmic1 data pin
+    description: |
+      Specify which GPIO pin be used as DMIC1 data pin.
 
   realtek,dmic1-clk-pin:
     $ref: /schemas/types.yaml#/definitions/uint32
@@ -36,12 +38,16 @@ properties:
       - 0 # dmic1 clk is not used
       - 1 # using GPIO1 pin as dmic1 clock pin
       - 2 # using GPIO3 pin as dmic1 clock pin
+    description: |
+      Specify which GPIO pin be used as DMIC1 clk pin.
 
   realtek,jd-src:
     $ref: /schemas/types.yaml#/definitions/uint32
     enum:
       - 0 # No JD is used
       - 1 # using JD1 as JD source
+    description: |
+      Specify which JD source be used.
 
   realtek,ldo1-en-gpios:
     description: |
@@ -72,9 +78,9 @@ properties:
     const: 1
 
   clock-output-names:
-    items:
-      - description: Name given for DAI word clock output.
-      - description: Name given for DAI bit clock output.
+    minItems: 2
+    maxItems: 2
+    description: Name given for DAI word clock and bit clock outputs.
 
 additionalProperties: false
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-30 15:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 21:18 [PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors David Heidelberg
2021-09-29 21:18 ` David Heidelberg
  -- strict thread matches above, loose matches on Subject: below --
2021-09-29 13:04 derek.fang
2021-09-29 13:04 ` derek.fang
2021-09-30 14:58 ` Mark Brown
2021-09-30 14:58   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.