All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 3/4] clk: renesas: cpg-mssr: add register pointers into struct cpg_mssr_priv
Date: Fri, 11 Sep 2020 04:16:17 +0000	[thread overview]
Message-ID: <OSAPR01MB368368C89C7D39910EAA0E7CD8240@OSAPR01MB3683.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdV=svSDGJu4HoaeiEdWT2nk4eQFARMZKn3x7kvJx2QBgQ@mail.gmail.com>

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Thursday, September 10, 2020 10:11 PM
> 
> Hi Shimoda-san,
> 
> On Wed, Sep 9, 2020 at 3:13 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > To support other register layout in the future, add register pointers
> > of control_regs and status_regs into struct cpg_mssr_priv. After that,
> > we can remove unused macros like MSTPSR(). No behavior changes.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/drivers/clk/renesas/renesas-cpg-mssr.c
> > +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
> 
> > @@ -137,6 +130,8 @@ struct cpg_mssr_priv {
> >         unsigned int last_dt_core_clk;
> >
> >         struct raw_notifier_head notifiers;
> > +       const u16 *status_regs;
> > +       const u16 *control_regs;
> 
> Please add new fields to the struct's kerneldoc comments above.

Oops. I'll add such comments.

> Note that you need to use a similar dispatching for the Software Reset
> and Software Reset Clearing Registers, as their offsets differ from
> previous SoCs.

Indeed. I'll add these pointers.

> The reset looks good to me, thanks!

Thank you for your review!

Best regards,
Yoshihiro Shimoda


  reply	other threads:[~2020-09-11  4:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 13:13 [PATCH v2 0/4] clk: renesas: cpg-mssr: add support for V3U Yoshihiro Shimoda
2020-09-09 13:13 ` [PATCH v2 1/4] dt-bindings: clock: Add r8a779a0 CPG Core Clock Definitions Yoshihiro Shimoda
2020-09-10 12:56   ` Geert Uytterhoeven
2020-09-09 13:13 ` [PATCH v2 2/4] clk: renesas: cpg-mssr: Use enum clk_reg_layout instead of a boolean flag Yoshihiro Shimoda
2020-09-10 13:06   ` Geert Uytterhoeven
2020-09-10 13:06     ` Geert Uytterhoeven
2020-09-11  0:35       ` Yoshihiro Shimoda
2020-09-09 13:13 ` [PATCH v2 3/4] clk: renesas: cpg-mssr: add register pointers into struct cpg_mssr_priv Yoshihiro Shimoda
2020-09-10 13:11   ` Geert Uytterhoeven
2020-09-11  4:16     ` Yoshihiro Shimoda [this message]
2020-09-09 13:13 ` [PATCH v2 4/4] clk: renesas: cpg-mssr: Add support for R-Car V3U Yoshihiro Shimoda
2020-09-10 13:19   ` Geert Uytterhoeven
2020-09-11  4:41     ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSAPR01MB368368C89C7D39910EAA0E7CD8240@OSAPR01MB3683.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.